package/busybox: drop empty configure command
PATCH 1/1 package/busybox: drop empty configure command
Since commit 50dc350c65 (package/busybox: update to 1.29.0), we no longer define the BUSYBOX_NOCLOBBER_INSTALL macro, so it expands to an empty string, so we end up with no action in BUSYBOX_CONFIGURE_CMDS.
Drop BUSYBOX_CONFIGURE_CMDS now that it serves no purpose.
--- package/busybox/busybox.mk | 4 ---- 1 file changed, 4 deletions(-)
package/busybox/busybox.mk +0 -4
@@ -323,10 +323,6 @@ define BUSYBOX_KCONFIG_FIXUP_CMDS $(BUSYBOX_SET_INDIVIDUAL_BINARIES) endef -define BUSYBOX_CONFIGURE_CMDS - $(BUSYBOX_NOCLOBBER_INSTALL) -endef - define BUSYBOX_BUILD_CMDS $(BUSYBOX_MAKE_ENV) $(MAKE) $(BUSYBOX_MAKE_OPTS) -C $(@D) endef
Signature · 15 lines
2.17.1 _________________________________________________________________________________________________________________________ Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration, Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci. This message and its attachments may contain confidential or privileged information that may be protected by law; they should not be distributed, used or copied without authorisation. If you have received this email in error, please notify the sender and delete this message and its attachments. As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified. Thank you.
PATCH 1/1 package/busybox: drop empty configure command
Quoted 6 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
<[email protected]> writes:
Since commit
50dc350c65(package/busybox: update to 1.29.0), we no longer define theBUSYBOX_NOCLOBBER_INSTALLmacro, so it expands to an empty string, so we end up with no action inBUSYBOX_CONFIGURE_CMDS.
Quoted 6 lines
Drop
BUSYBOX_CONFIGURE_CMDSnow that it serves no purpose.Signed-off-by Yann MORIN <[email protected]>Cc "Yann E. MORIN" <[email protected]>Cc Adam Duskett <[email protected]>Cc Carlos Santos <[email protected]>
Committed, thanks.
Signature · 1 line
Bye, Peter Korsgaard
PATCH 1/1 package/busybox: drop empty configure command
In reply to yann.morin at orange.comQuoted 9 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
<[email protected]> writes:
Since commit
50dc350c65(package/busybox: update to 1.29.0), we no longer define theBUSYBOX_NOCLOBBER_INSTALLmacro, so it expands to an empty string, so we end up with no action inBUSYBOX_CONFIGURE_CMDS.Drop
BUSYBOX_CONFIGURE_CMDSnow that it serves no purpose.Signed-off-by Yann MORIN <[email protected]>
FYI, your author name was not configured correctly (was your email address):
remote:
remote: Refusing to update refs/heads/master:
remote: fc9fd5a8780966970525b4da8313091a0f0bbc80..8cbcb445b951b3b9e19d7cde7253ec6ce61f06f6
remote:
remote: Author name is not set properly (needs to be first and last name, and it is 'yann.morin at orange.com' instead)
I've fixed that and committed, thanks.
Signature · 1 line
Bye, Peter Korsgaard
PATCH 1/1 package/busybox: drop empty configure command
Peter, All,
On 2019-01-29 16:37 +0100, Peter Korsgaard spake thusly:
Quoted 6 lines
Quoted 5 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
<[email protected]> writes:
Since commit
50dc350c65(package/busybox: update to 1.29.0), we no longer define theBUSYBOX_NOCLOBBER_INSTALLmacro, so it expands to an empty string, so we end up with no action inBUSYBOX_CONFIGURE_CMDS.
Quoted 6 lines
Quoted 3 lines
Drop
BUSYBOX_CONFIGURE_CMDSnow that it serves no purpose.Signed-off-by Yann MORIN <[email protected]>FYI, your author name was not configured correctly (was your email address):
Yeah, I have no idea why that is, because here, my 'From' was really what you'd expect:
From: "Yann E. MORIN" <[email protected]>
But it seems my intelligent mail server stripped it out... Let's see how that one will fare...
Quoted 7 lines
remote:
remote: Refusing to update refs/heads/master:
remote:fc9fd5a8780966970525b4da8313091a0f0bbc80..8cbcb445b951b3b9e19d7cde7253ec6ce61f06f6
remote:
remote: Author name is not set properly (needs to be first and last name, and it is 'yann.morin at orange.com' instead)I've fixed that and committed, thanks.
Thanks!
Regards,
Yann E. MORIN.
Signature · 21 lines
____________ .-----------------.--------------------: _ :------------------. | Yann E. MORIN | Real-Time Embedded | __/ ) | /"\ ASCII RIBBON | | +33 534.541.179 | Software Designer | _/ - /' | \ / CAMPAIGN | | +33 638.411.245 '--------------------: (_ `--, | X AGAINST | | yann.morin (at) orange.com |_=" ,--' | / \ HTML MAIL | '--------------------------------------:______/_____:------------------' _________________________________________________________________________________________________________________________ Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration, Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci. This message and its attachments may contain confidential or privileged information that may be protected by law; they should not be distributed, used or copied without authorisation. If you have received this email in error, please notify the sender and delete this message and its attachments. As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified. Thank you.
PATCH 1/1 package/busybox: drop empty configure command
Quoted 17 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
<[email protected]> writes:
Peter, All,
On 2019-01-29 16:37 +0100, Peter Korsgaard spake thusly:Quoted 6 lines
Quoted 5 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
<[email protected]> writes:
Since commit
50dc350c65(package/busybox: update to 1.29.0), we no longer define theBUSYBOX_NOCLOBBER_INSTALLmacro, so it expands to an empty string, so we end up with no action inBUSYBOX_CONFIGURE_CMDS.Quoted 6 lines
Quoted 3 lines
Drop
BUSYBOX_CONFIGURE_CMDSnow that it serves no purpose.Signed-off-by Yann MORIN <[email protected]>FYI, your author name was not configured correctly (was your email address):
Quoted 7 lines
Yeah, I have no idea why that is, because here, my 'From' was really what you'd expect:
From: "Yann E. MORIN" <[email protected]>
But it seems my intelligent mail server stripped it out... Let's see how that one will fare...
Still the same ;)
Signature · 1 line
Bye, Peter Korsgaard