arm: dts: am4372: fix DTC warnings

PATCH New Felipe Balbi 2 participants 4 messages Mar 21, 2018 – Mar 22, 2018 Arm (32-bit)

lore

Share & tools

lore

Felipe Balbi

author

2018-03-21 13:44 UTC #0 lore raw

PATCH 1/1 arm: dts: am4372: fix DTC warnings

The following warnings are fixed:

arch/arm/dts/am43x-epos-evm.dtb: Warning (interrupts_property): interrupts size is (8), expected multiple of 12 in /ocp/mcasp at 48038000 arch/arm/dts/am43x-epos-evm.dtb: Warning (interrupts_property): interrupts size is (8), expected multiple of 12 in /ocp/mcasp at 4803C000 arch/arm/dts/am43x-epos-evm.dtb: Warning (interrupts_property): Missing interrupt-controller or interrupt-map property in /ocp/gpmc at 50000000 arch/arm/dts/am43x-epos-evm.dtb: Warning (interrupts_property): Missing #interrupt-cells in interrupt-parent /ocp/gpmc at 50000000 arch/arm/dts/am437x-gp-evm.dtb: Warning (interrupts_property): interrupts size is (8), expected multiple of 12 in /ocp/mcasp at 48038000 arch/arm/dts/am437x-gp-evm.dtb: Warning (interrupts_property): interrupts size is (8), expected multiple of 12 in /ocp/mcasp at 4803C000 arch/arm/dts/am437x-idk-evm.dtb: Warning (interrupts_property): interrupts size is (8), expected multiple of 12 in /ocp/mcasp at 48038000 arch/arm/dts/am437x-idk-evm.dtb: Warning (interrupts_property): interrupts size is (8), expected multiple of 12 in /ocp/mcasp at 4803C000 arch/arm/dts/am437x-sk-evm.dtb: Warning (interrupts_property): interrupts size is (8), expected multiple of 12 in /ocp/mcasp at 48038000 arch/arm/dts/am437x-sk-evm.dtb: Warning (interrupts_property): interrupts size is (8), expected multiple of 12 in /ocp/mcasp at 4803C000

The fix was basically to copy the missing data from mainline linux.

Signed-off-by Felipe Balbi <[email protected]>

---
 arch/arm/dts/am4372.dtsi | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

arch/arm/dts/am4372.dtsi +6 -2

index 3ffa8e016e08..5c205f0ff0fa 100644
@@ -764,7 +764,8 @@
 			reg = <0x48038000 0x2000>,
 			      <0x46000000 0x400000>;
 			reg-names = "mpu", "dat";
-			interrupts = <80>, <81>;
+			interrupts = <GIC_SPI 80 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 81 IRQ_TYPE_LEVEL_HIGH>;
 			interrupt-names = "tx", "rx";
 			status = "disabled";
 			dmas = <&edma 8>,

@@ -778,7 +779,8 @@
 			reg = <0x4803C000 0x2000>,
 			      <0x46400000 0x400000>;
 			reg-names = "mpu", "dat";
-			interrupts = <82>, <83>;
+			interrupts = <GIC_SPI 82 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 83 IRQ_TYPE_LEVEL_HIGH>;
 			interrupt-names = "tx", "rx";
 			status = "disabled";
 			dmas = <&edma 10>,

@@ -807,6 +809,8 @@
 			gpmc,num-waitpins = <2>;
 			#address-cells = <2>;
 			#size-cells = <1>;
+			interrupt-controller;
+			#interrupt-cells = <2>;
 			status = "disabled";
 		};

Signature · 1 line

2.16.1

Tom Rini

2018-03-21 13:51 UTC #1 lore raw

PATCH 1/1 arm: dts: am4372: fix DTC warnings

Quoted 13 lines · Felipe Balbi

The following warnings are fixed:
arch/arm/dts/am43x-epos-evm.dtb: Warning (interrupts_property): interrupts size is (8), expected multiple of 12 in /ocp/mcasp at 48038000 arch/arm/dts/am43x-epos-evm.dtb: Warning (interrupts_property): interrupts size is (8), expected multiple of 12 in /ocp/mcasp at 4803C000 arch/arm/dts/am43x-epos-evm.dtb: Warning (interrupts_property): Missing interrupt-controller or interrupt-map property in /ocp/gpmc at 50000000 arch/arm/dts/am43x-epos-evm.dtb: Warning (interrupts_property): Missing #interrupt-cells in interrupt-parent /ocp/gpmc at 50000000 arch/arm/dts/am437x-gp-evm.dtb: Warning (interrupts_property): interrupts size is (8), expected multiple of 12 in /ocp/mcasp at 48038000 arch/arm/dts/am437x-gp-evm.dtb: Warning (interrupts_property): interrupts size is (8), expected multiple of 12 in /ocp/mcasp at 4803C000 arch/arm/dts/am437x-idk-evm.dtb: Warning (interrupts_property): interrupts size is (8), expected multiple of 12 in /ocp/mcasp at 48038000 arch/arm/dts/am437x-idk-evm.dtb: Warning (interrupts_property): interrupts size is (8), expected multiple of 12 in /ocp/mcasp at 4803C000 arch/arm/dts/am437x-sk-evm.dtb: Warning (interrupts_property): interrupts size is (8), expected multiple of 12 in /ocp/mcasp at 48038000 arch/arm/dts/am437x-sk-evm.dtb: Warning (interrupts_property): interrupts size is (8), expected multiple of 12 in /ocp/mcasp at 4803C000

Quoted 1 line

The fix was basically to copy the missing data from mainline linux.

Shouldn't we just re-sync with v4.16-rc? Thanks!

Signature · 8 lines

Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180321/2aeb4a8b/attachment.sig>

Felipe Balbi

author

2018-03-22 07:57 UTC #2 lore raw

PATCH 1/1 arm: dts: am4372: fix DTC warnings

Hi,

Quoted 14 lines · Tom Rini

Quoted 13 lines · Felipe Balbi
The following warnings are fixed:
arch/arm/dts/am43x-epos-evm.dtb: Warning (interrupts_property): interrupts size is (8), expected multiple of 12 in /ocp/mcasp at 48038000 arch/arm/dts/am43x-epos-evm.dtb: Warning (interrupts_property): interrupts size is (8), expected multiple of 12 in /ocp/mcasp at 4803C000 arch/arm/dts/am43x-epos-evm.dtb: Warning (interrupts_property): Missing interrupt-controller or interrupt-map property in /ocp/gpmc at 50000000 arch/arm/dts/am43x-epos-evm.dtb: Warning (interrupts_property): Missing #interrupt-cells in interrupt-parent /ocp/gpmc at 50000000 arch/arm/dts/am437x-gp-evm.dtb: Warning (interrupts_property): interrupts size is (8), expected multiple of 12 in /ocp/mcasp at 48038000 arch/arm/dts/am437x-gp-evm.dtb: Warning (interrupts_property): interrupts size is (8), expected multiple of 12 in /ocp/mcasp at 4803C000 arch/arm/dts/am437x-idk-evm.dtb: Warning (interrupts_property): interrupts size is (8), expected multiple of 12 in /ocp/mcasp at 48038000 arch/arm/dts/am437x-idk-evm.dtb: Warning (interrupts_property): interrupts size is (8), expected multiple of 12 in /ocp/mcasp at 4803C000 arch/arm/dts/am437x-sk-evm.dtb: Warning (interrupts_property): interrupts size is (8), expected multiple of 12 in /ocp/mcasp at 48038000 arch/arm/dts/am437x-sk-evm.dtb: Warning (interrupts_property): interrupts size is (8), expected multiple of 12 in /ocp/mcasp at 4803C000

Quoted 3 lines

Quoted 1 line
The fix was basically to copy the missing data from mainline linux.
Shouldn't we just re-sync with v4.16-rc? Thanks!

sure, if you prefer doing that. But in that case, it seems like extracting Linux's DTS to its own project (linux-dts.git??) and using that as submodule would be far better.

Signature · 8 lines

balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180322/b18d4b22/attachment.sig>

Tom Rini

2018-03-22 11:15 UTC #3 lore raw

PATCH 1/1 arm: dts: am4372: fix DTC warnings

Quoted 18 lines · Felipe Balbi

Hi,
Quoted 14 lines · Tom Rini
Quoted 13 lines · Felipe Balbi
The following warnings are fixed:
arch/arm/dts/am43x-epos-evm.dtb: Warning (interrupts_property): interrupts size is (8), expected multiple of 12 in /ocp/mcasp at 48038000 arch/arm/dts/am43x-epos-evm.dtb: Warning (interrupts_property): interrupts size is (8), expected multiple of 12 in /ocp/mcasp at 4803C000 arch/arm/dts/am43x-epos-evm.dtb: Warning (interrupts_property): Missing interrupt-controller or interrupt-map property in /ocp/gpmc at 50000000 arch/arm/dts/am43x-epos-evm.dtb: Warning (interrupts_property): Missing #interrupt-cells in interrupt-parent /ocp/gpmc at 50000000 arch/arm/dts/am437x-gp-evm.dtb: Warning (interrupts_property): interrupts size is (8), expected multiple of 12 in /ocp/mcasp at 48038000 arch/arm/dts/am437x-gp-evm.dtb: Warning (interrupts_property): interrupts size is (8), expected multiple of 12 in /ocp/mcasp at 4803C000 arch/arm/dts/am437x-idk-evm.dtb: Warning (interrupts_property): interrupts size is (8), expected multiple of 12 in /ocp/mcasp at 48038000 arch/arm/dts/am437x-idk-evm.dtb: Warning (interrupts_property): interrupts size is (8), expected multiple of 12 in /ocp/mcasp at 4803C000 arch/arm/dts/am437x-sk-evm.dtb: Warning (interrupts_property): interrupts size is (8), expected multiple of 12 in /ocp/mcasp at 48038000 arch/arm/dts/am437x-sk-evm.dtb: Warning (interrupts_property): interrupts size is (8), expected multiple of 12 in /ocp/mcasp at 4803C000

Quoted 7 lines

Quoted 3 lines
Quoted 1 line
The fix was basically to copy the missing data from mainline linux.
Shouldn't we just re-sync with v4.16-rc? Thanks!
sure, if you prefer doing that. But in that case, it seems like extracting Linux's DTS to its own project (linux-dts.git??) and using that as submodule would be far better.

Except we also have our own files in arch/*/dts/ so we expect people to just sync the DTS files they use as-needed.

Signature · 8 lines

Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180322/4a3cf1b6/attachment.sig>