Skip to contentSkip to conversation

ARM: orion: remove unreferenced board-d2net.c

PATCH New Ben Dooks 5 participants 9 messages Jun 9, 2016 – Jul 27, 2016

Subsystems (3)
Arm (32-bit) Arm sub-architectures Arm/Marvell Dove/MV78xx0/Orion SoC support
lore
Share & tools
lore

Ben Dooks

author
#0 lore raw

PATCH 1/1 ARM: orion: remove unreferenced board-d2net.c

Either this has been mis-converted (and needs to be fixed) or is no longer referenced and can be safely removed.

Signed-off-by Ben Dooks <[email protected]>

---
Cc: Jason Cooper <[email protected]>
Cc: Andrew Lunn <[email protected]>
Cc: Sebastian Hesselbarth <[email protected]>
Cc: Gregory Clement <[email protected]>
Cc: linux-arm-kernel at lists.infradead.org

---
 arch/arm/mach-orion5x/Kconfig       |   7 ---
 arch/arm/mach-orion5x/Makefile      |   1 -
 arch/arm/mach-orion5x/board-d2net.c | 109 ------------------------------------
 3 files changed, 117 deletions(-)
 delete mode 100644 arch/arm/mach-orion5x/board-d2net.c
arch/arm/mach-orion5x/Kconfig +0 -7
index a2af158..32897e8 100644
@@ -130,13 +130,6 @@ config MACH_MV2120
 	  Say 'Y' here if you want your kernel to support the
 	  HP Media Vault mv2120 or mv5100.
 
-config MACH_D2NET_DT
-	bool "LaCie d2 Network / Big Disk Network (Flattened Device Tree)"
-	select ARCH_ORION5X_DT
-	help
-	  Say 'Y' here if you want your kernel to support the
-	  LaCie d2 Network NAS.
-
 config MACH_NET2BIG
 	bool "LaCie 2Big Network"
 	select I2C_BOARDINFO if I2C
arch/arm/mach-orion5x/Makefile +0 -1
index 4b2502b..cf0ca8b 100644
@@ -21,6 +21,5 @@ obj-$(CONFIG_MACH_RD88F6183AP_GE)	+= rd88f6183ap-ge-setup.o
 obj-$(CONFIG_MACH_LINKSTATION_LSCHL)	+= ls-chl-setup.o
 
 obj-$(CONFIG_ARCH_ORION5X_DT)		+= board-dt.o
-obj-$(CONFIG_MACH_D2NET_DT)	+= board-d2net.o
 obj-$(CONFIG_MACH_MSS2_DT)	+= board-mss2.o
 obj-$(CONFIG_MACH_RD88F5182_DT)	+= board-rd88f5182.o
arch/arm/mach-orion5x/board-d2net.c deleted +0 -109

109 lines not on this page · raw message

Signature · 1 line
2.8.1
maintainer
#1 lore raw

PATCH 1/1 ARM: orion: remove unreferenced board-d2net.c

Quoted 2 lines · Ben Dooks

Either this has been mis-converted (and needs to be fixed) or is no longer referenced and can be safely removed.

Hi Thomas

You added this code, which Ben is removing. It does look like you forgot to call d2net_init() from orion5x_dt_init().

Please could you look at this.

Thanks
Andrew

#2 lore raw

PATCH 1/1 ARM: orion: remove unreferenced board-d2net.c

Hello,

Quoted 10 lines · Andrew Lunn
Quoted 2 lines · Ben Dooks

Either this has been mis-converted (and needs to be fixed) or is no longer referenced and can be safely removed.

Hi Thomas

You added this code, which Ben is removing. It does look like you forgot to call d2net_init() from orion5x_dt_init().

Please could you look at this.

You are correct: d2net_init() should be called from orion5x_dt_init(), or called through some initcall mechanism.

That being said, this has been broken more than 2 years ago, and nobody noticed. Doesn't this mean that we could get rid of the support for this board entirely? :)

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
maintainer
#3 lore raw

PATCH 1/1 ARM: orion: remove unreferenced board-d2net.c

Hi Thomas

Quoted 3 lines

That being said, this has been broken more than 2 years ago, and nobody noticed. Doesn't this mean that we could get rid of the support for this board entirely? :)

Well, all it means is the LEDs don't blink. If the disk was not spinning, or the ethernet device missing, i would agree with you. But somebody could be using this device and don't notice the difference with the LEDs.

Andrew

#4 lore raw

PATCH 1/1 ARM: orion: remove unreferenced board-d2net.c

Hello,

Quoted 8 lines · Andrew Lunn
Quoted 3 lines

That being said, this has been broken more than 2 years ago, and nobody noticed. Doesn't this mean that we could get rid of the support for this board entirely? :)

Well, all it means is the LEDs don't blink. If the disk was not spinning, or the ethernet device missing, i would agree with you. But somebody could be using this device and don't notice the difference with the LEDs.

True. I'm probably trying to hard to clean up the dust :)

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
author
#5 lore raw

PATCH 1/1 ARM: orion: remove unreferenced board-d2net.c

Quoted 12 lines · Thomas Petazzoni

Hello,

Quoted 8 lines · Andrew Lunn
Quoted 3 lines

That being said, this has been broken more than 2 years ago, and nobody noticed. Doesn't this mean that we could get rid of the support for this board entirely? :)

Well, all it means is the LEDs don't blink. If the disk was not spinning, or the ethernet device missing, i would agree with you. But somebody could be using this device and don't notice the difference with the LEDs.

Surely DT can manage blinking LEDs??

Quoted 4 lines

True. I'm probably trying to hard to clean up the dust :)

Thomas

Signature · 2 lines
Ben Dooks				http://www.codethink.co.uk/
Senior Engineer				Codethink - Providing Genius
maintainer
#6 lore raw

PATCH 1/1 ARM: orion: remove unreferenced board-d2net.c

Quoted 9 lines · Ben Dooks
Quoted 8 lines · Thomas Petazzoni

Hello,

Quoted 4 lines · Andrew Lunn
Quoted 3 lines

That being said, this has been broken more than 2 years ago, and nobody noticed. Doesn't this mean that we could get rid of the support for this board entirely? :)

Quoted 6 lines
Quoted 4 lines
Quoted 4 lines

Well, all it means is the LEDs don't blink. If the disk was not spinning, or the ethernet device missing, i would agree with you. But somebody could be using this device and don't notice the difference with the LEDs.

Surely DT can manage blinking LEDs??

There is an additional GPIO needed. However, i think a pin hog should allow this to be represented in DT. Two years ago, i don't think this sort of hogging existed.

Andrew

#7 lore raw

PATCH 1/1 ARM: orion: remove unreferenced board-d2net.c

Quoted 15 lines · Andrew Lunn
Quoted 14 lines · Ben Dooks
Quoted 12 lines · Thomas Petazzoni

Hello,

Quoted 8 lines · Andrew Lunn
Quoted 3 lines

That being said, this has been broken more than 2 years ago, and nobody noticed. Doesn't this mean that we could get rid of the support for this board entirely? :)

Well, all it means is the LEDs don't blink. If the disk was not spinning, or the ethernet device missing, i would agree with you. But somebody could be using this device and don't notice the difference with the LEDs.

Quoted 5 lines
Quoted 1 line

Surely DT can manage blinking LEDs??

There is an additional GPIO needed. However, i think a pin hog should allow this to be represented in DT. Two years ago, i don't think this sort of hogging existed.

I think this LED device is compatible with the leds-ns2 driver. If it is true, then the LED definition can be moved into the DT file. I'll look at that.

Simon
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160610/9c5e9e8c/attachment.sig>

#8 lore raw

PATCH 1/1 ARM: orion: remove unreferenced board-d2net.c

In reply to Thomas Petazzoni

Hi Thomas,

Quoted 9 lines · Thomas Petazzoni

Hello,

Quoted 6 lines · Andrew Lunn
Quoted 2 lines · Ben Dooks

Either this has been mis-converted (and needs to be fixed) or is no longer referenced and can be safely removed.

Hi Thomas

Quoted 7 lines
Quoted 4 lines

You added this code, which Ben is removing. It does look like you forgot to call d2net_init() from orion5x_dt_init().

Please could you look at this.

You are correct: d2net_init() should be called from orion5x_dt_init(), or called through some initcall mechanism.

So should we apply the patch as is or wait for the needed fix for this board?

Gregory

Signature · 4 lines
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com