[[email protected]: intel_gpu_top broken for HSW. Ideas needed]
FWD'd from our internal list now that we have more insight.
----- Forwarded message from Ben Widawsky <[email protected]> -----
Date: Thu, 11 Jul 2013 10:32:03 -0700
From: Ben Widawsky <[email protected]>
To: [email protected]
Subject: intel_gpu_top broken for HSW. Ideas needed
Message-ID: <[email protected]>
Hi everybody.
While investigating a hard hang on Haswell. Eero noticed that intel_gpu_top helped to invoke the hang faster. I used this in my test case to validation, and they are suspecting it is a known issue which we have not yet worked around (and cannot reasonably workaround).
[internal bug sighting redacted]
To sum up, we cannot concurrently access registers within the same cacheline. It has the potential to hit a known bug.
I see some choices:
1. Don't do anything.
2. Try to eliminate shared registers as much as possible. Instdone is used by the hangcheck, and we can eliminate hangcheck with a module parameter. Eero, can you try this as a workaround, btw?
3. Somehow make the kernel collect the top data and serialize access there.
Anyone else have input? I personally do not use top very much, so I won't be volunteering to do any of these.
----- End forwarded message -----
Signature · 1 line
Ben Widawsky, Intel Open Source Technology Center
Quoted 29 lines · Ben Widawsky
FWD'd from our internal list now that we have more insight.
----- Forwarded message from Ben Widawsky <[email protected]> -----Date: Thu, 11 Jul 2013 10:32:03 -0700
From: Ben Widawsky <[email protected]>
To: [email protected]
Subject:intel_gpu_topbroken for HSW. Ideas needed
Message-ID: <[email protected]>Hi everybody.
While investigating a hard hang on Haswell. Eero noticed that
intel_gpu_tophelped to invoke the hang faster. I used this in my test case to validation, and they are suspecting it is a known issue which we have not yet worked around (and cannot reasonably workaround).[internal bug sighting redacted]
To sum up, we cannot concurrently access registers within the same cacheline. It has the potential to hit a known bug.
I see some choices:
1. Don't do anything.
2. Try to eliminate shared registers as much as possible. Instdone is used by the hangcheck, and we can eliminate hangcheck with a module parameter. Eero, can you try this as a workaround, btw?
3. Somehow make the kernel collect the top data and serialize access there.
Quoted 2 lines
Anyone else have input? I personally do not use top very much, so I won't be volunteering to do any of these.
For now I'd just vote for a warning on gen6+ on the intel-gpu-top screen that this might hang hw. If anyone cares we could add a debugfs interface (or finally get real approval for the performance counters the hw has an expose them properly). Not a intel_gpu_top user myself though.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
Quoted 35 lines · Daniel Vetter
Quoted 29 lines · Ben Widawsky
FWD'd from our internal list now that we have more insight.
----- Forwarded message from Ben Widawsky <[email protected]> -----Date: Thu, 11 Jul 2013 10:32:03 -0700
From: Ben Widawsky <[email protected]>
To: [email protected]
Subject:intel_gpu_topbroken for HSW. Ideas needed
Message-ID: <[email protected]>Hi everybody.
While investigating a hard hang on Haswell. Eero noticed that
intel_gpu_tophelped to invoke the hang faster. I used this in my test case to validation, and they are suspecting it is a known issue which we have not yet worked around (and cannot reasonably workaround).[internal bug sighting redacted]
To sum up, we cannot concurrently access registers within the same cacheline. It has the potential to hit a known bug.
I see some choices:
1. Don't do anything.
2. Try to eliminate shared registers as much as possible. Instdone is used by the hangcheck, and we can eliminate hangcheck with a module parameter. Eero, can you try this as a workaround, btw?
3. Somehow make the kernel collect the top data and serialize access there.Quoted 2 lines
Anyone else have input? I personally do not use top very much, so I won't be volunteering to do any of these.
Quoted 7 lines
For now I'd just vote for a warning on gen6+ on the intel-gpu-top screen that this might hang hw. If anyone cares we could add a debugfs interface (or finally get real approval for the performance counters the hw has an expose them properly). Not a
intel_gpu_topuser myself though.
-Daniel
Eero: I meant to add by the way, ring head/tail are also used as much as instdone. So Maybe we can get rid of that for the ring fullness check. We're *very* likely to hit that one.
Signature · 1 line
Ben Widawsky, Intel Open Source Technology Center
Quoted 29 lines · Ben Widawsky
FWD'd from our internal list now that we have more insight.
----- Forwarded message from Ben Widawsky <[email protected]> -----Date: Thu, 11 Jul 2013 10:32:03 -0700
From: Ben Widawsky <[email protected]>
To: [email protected]
Subject:intel_gpu_topbroken for HSW. Ideas needed
Message-ID: <[email protected]>Hi everybody.
While investigating a hard hang on Haswell. Eero noticed that
intel_gpu_tophelped to invoke the hang faster. I used this in my test case to validation, and they are suspecting it is a known issue which we have not yet worked around (and cannot reasonably workaround).[internal bug sighting redacted]
To sum up, we cannot concurrently access registers within the same cacheline. It has the potential to hit a known bug.
I see some choices:
1. Don't do anything.
2. Try to eliminate shared registers as much as possible. Instdone is used by the hangcheck, and we can eliminate hangcheck with a module parameter. Eero, can you try this as a workaround, btw?
3. Somehow make the kernel collect the top data and serialize access there.
Quoted 3 lines
Anyone else have input? I personally do not use top very much, so I won't be volunteering to do any of these.
BTW, of course any tool which reads or writes registers is subject to the same problem. GPU top is just the one that kind of depends upon us not synchronizing with the kernel.
Signature · 1 line
Ben Widawsky, Intel Open Source Technology Center
Quoted 18 lines · Ben Widawsky
FWD'd from our internal list now that we have more insight.
----- Forwarded message from Ben Widawsky <[email protected]> -----Date: Thu, 11 Jul 2013 10:32:03 -0700
From: Ben Widawsky <[email protected]>
To: [email protected]
Subject:intel_gpu_topbroken for HSW. Ideas needed
Message-ID: <[email protected]>Hi everybody.
While investigating a hard hang on Haswell. Eero noticed that
intel_gpu_tophelped to invoke the hang faster. I used this in my test case to validation, and they are suspecting it is a known issue which we have not yet worked around (and cannot reasonably workaround).[internal bug sighting redacted]
Quoted 8 lines
To sum up, we cannot concurrently access registers within the same cacheline. It has the potential to hit a known bug.
I see some choices:
1. Don't do anything.
2. Try to eliminate shared registers as much as possible. Instdone is used by the hangcheck, and we can eliminate hangcheck with a module parameter. Eero, can you try this as a workaround, btw?
Commit: 92cab7345131db7af18f630a799ce6b2e8e624c5 gets rid of instdone on hangcheck.
-Mika
Quoted 14 lines
3. Somehow make the kernel collect the top data and serialize access there.
Anyone else have input? I personally do not use top very much, so I won't be volunteering to do any of these.
----- End forwarded message -----
Signature · 5 lines
Ben Widawsky, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx