Skip to contentSkip to conversation

strace: fix build for x86_64

PATCH New Arnout Vandecappelle (Essensium/Mind) 2 participants 2 messages Oct 30, 2012

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 strace: fix build for x86_64

strace fails to build on x86_64 because stat64 is not available. This is because the automatic detection of stat64 in configure is overridden by buildroot, by setting ac_cv_type_stat64. Just remove that override - current strace seems to detect it correctly for non-largefile platforms.

Build-tested on x86_64 (with largefile), ARM (with and without largefile), sh4, MIPS and ppc-32 (no largefile).

---
 package/strace/strace.mk |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
package/strace/strace.mk +1 -2
index 7876848..ad1d042 100644
@@ -9,8 +9,7 @@ STRACE_SOURCE = strace-$(STRACE_VERSION).tar.xz
 STRACE_SITE = http://downloads.sourceforge.net/project/strace/strace/$(STRACE_VERSION)
 
 STRACE_CONF_ENV = ac_cv_header_linux_if_packet_h=yes \
-		  ac_cv_header_linux_netlink_h=yes \
-	          $(if $(BR2_LARGEFILE),ac_cv_type_stat64=yes,ac_cv_type_stat64=no)
+		  ac_cv_header_linux_netlink_h=yes
 
 ifeq ($(BR2_LARGEFILE),y)
 # strace gets confused when lfs mode is forced, so don't
Signature · 1 line
tg: (29266a3..) t/strace-x86_64 (depends on: master)
#1 lore raw

PATCH 1/1 strace: fix build for x86_64

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Arnout" == Arnout Vandecappelle (Essensium/Mind) <[email protected]> writes:

Arnout> strace fails to build on x86_64 because stat64 is not Arnout> available. This is because the automatic detection of stat64 Arnout> in configure is overridden by buildroot, by setting Arnout> ac_cv_type_stat64. Just remove that override - current strace Arnout> seems to detect it correctly for non-largefile platforms.

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard