logsurfer: new package
PATCH 1/1 logsurfer: new package
--- package/Config.in | 1 + package/logsurfer/Config.in | 7 +++++++ package/logsurfer/logsurfer.mk | 15 +++++++++++++++ 3 files changed, 23 insertions(+), 0 deletions(-) create mode 100644 package/logsurfer/Config.in create mode 100644 package/logsurfer/logsurfer.mk
package/Config.in +1 -0
@@ -613,6 +613,7 @@ source "package/file/Config.in" source "package/inotify-tools/Config.in" source "package/lockfile-progs/Config.in" source "package/logrotate/Config.in" +source "package/logsurfer/Config.in" source "package/screen/Config.in" source "package/sudo/Config.in" if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
package/logsurfer/Config.in new file +7 -0
@@ -0,0 +1,7 @@ +config BR2_PACKAGE_LOGSURFER + bool "logsurfer" + help + Logsurfer is a program for monitoring system logs in real-time, + and reporting on the occurrence of events. + + http://www.crypt.gen.nz/logsurfer/
package/logsurfer/logsurfer.mk new file +15 -0
@@ -0,0 +1,15 @@ +############################################################# +# +# logsurfer +# +############################################################# + +LOGSURFER_VERSION = 1.8 +LOGSURFER_SOURCE = logsurfer-$(LOGSURFER_VERSION).tar.gz +LOGSURFER_SITE = http://$(BR2_SOURCEFORGE_MIRROR).dl.sourceforge.net/sourceforge/logsurfer/logsurfer/logsurfer-${LOGSURFER_VERSION} + +define LOGSURFER_INSTALL_TARGET_CMDS + $(INSTALL) -D -m 0755 $(@D)/src/logsurfer $(TARGET_DIR)/bin +endef + +$(eval $(call AUTOTARGETS,package,logsurfer))
Signature · 1 line
1.7.2.5
PATCH 1/1 logsurfer: new package
Hoi Dominik,
Thank you for your contribution. You patch looks very good, with a few
small remarks.
Please add a Signed-off-by line for yourself. This is a short way for you to
assert that you are entitled to contribute the patch under buildroot's GPL license. See http://kerneltrap.org/files/Jeremy/DCO.txt for more details.
On 05/15/12 09:36, Dominik F?ssler wrote:
[snip]
package/logsurfer/logsurfer.mk line 9
Quoted 12 lines
package/logsurfer/logsurfer.mk new file +9
-0@@ -0,0 +1,15 @@ +############################################################# +# +# logsurfer +# +############################################################# + +LOGSURFER_VERSION = 1.8 +LOGSURFER_SOURCE = logsurfer-$(LOGSURFER_VERSION).tar.gz +LOGSURFER_SITE = http://$(BR2_SOURCEFORGE_MIRROR).dl.sourceforge.net/sourceforge/logsurfer/logsurfer/logsurfer-${LOGSURFER_VERSION}
We try to be consistent in using $() to reference variables, rather than
${}.
package/logsurfer/logsurfer.mk line 15
Quoted 5 lines
package/logsurfer/logsurfer.mk new file +5
-0+define LOGSURFER_INSTALL_TARGET_CMDS + $(INSTALL) -D -m 0755 $(@D)/src/logsurfer $(TARGET_DIR)/bin +endef + +$(eval $(call AUTOTARGETS,package,logsurfer))
The arguments to AUTOTARGETS are no longer necessary.
Regards,
Arnout
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286540 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
PATCH 1/1 logsurfer: new package
In reply to Dominik FässlerQuoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Dominik" == Dominik F?ssler <[email protected]> writes:
Dominik> ---
Dominik> package/Config.in | 1 + Dominik> package/logsurfer/Config.in | 7 +++++++ Dominik> package/logsurfer/logsurfer.mk | 15 +++++++++++++++ Dominik> 3 files changed, 23 insertions(+), 0 deletions(-) Dominik> create mode 100644 package/logsurfer/Config.in Dominik> create mode 100644 package/logsurfer/logsurfer.mk
Dominik> diff --git a/package/Config.in b/package/Config.in Dominik> index 4e3c414..091f8d6 100644
Dominik> --- a/package/Config.in
Dominik> +++ b/package/Config.in
Dominik> @@ -613,6 +613,7 @@ source "package/file/Config.in"
Dominik> source "package/inotify-tools/Config.in" Dominik> source "package/lockfile-progs/Config.in" Dominik> source "package/logrotate/Config.in" Dominik> +source "package/logsurfer/Config.in" Dominik> source "package/screen/Config.in" Dominik> source "package/sudo/Config.in" Dominik> if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
Dominik> diff --git a/package/logsurfer/Config.in b/package/logsurfer/Config.in
Dominik> new file mode 100644
Dominik> index 0000000..27d1881
Dominik> --- /dev/null
Dominik> +++ b/package/logsurfer/Config.in
Dominik> @@ -0,0 +1,7 @@
Dominik> +config BR2_PACKAGE_LOGSURFER
Dominik> + bool "logsurfer"
Dominik> + help
Dominik> + Logsurfer is a program for monitoring system logs in real-time,
Dominik> + and reporting on the occurrence of events.
Dominik> +
Dominik> + http://www.crypt.gen.nz/logsurfer/
Dominik> diff --git a/package/logsurfer/logsurfer.mk b/package/logsurfer/logsurfer.mk
Dominik> new file mode 100644
Dominik> index 0000000..31405ff
Dominik> --- /dev/null
Dominik> +++ b/package/logsurfer/logsurfer.mk
Dominik> @@ -0,0 +1,15 @@
Dominik> +#############################################################
Dominik> +#
Dominik> +# logsurfer
Dominik> +#
Dominik> +#############################################################
Dominik> +
Dominik> +LOGSURFER_VERSION = 1.8
Dominik> +LOGSURFER_SOURCE = logsurfer-$(LOGSURFER_VERSION).tar.gz
Dominik> +LOGSURFER_SITE = http://$(BR2_SOURCEFORGE_MIRROR).dl.sourceforge.net/sourceforge/logsurfer/logsurfer/logsurfer-${LOGSURFER_VERSION}
Dominik> +
Dominik> +define LOGSURFER_INSTALL_TARGET_CMDS
Dominik> + $(INSTALL) -D -m 0755 $(@D)/src/logsurfer $(TARGET_DIR)/bin
Dominik> +endef
Next to the feedback Arnout gave you, this line is wrong. With install -D you need to provide the destination file name as well, and it would be good to install man pages if BR2_HAVE_DOCUMENTATION is enabled.
I've fixed up these things and committed to next, thanks.
Signature · 1 line
Bye, Peter Korsgaard