drm/i915/params: use generics for parameter printing
Subsystems (2)
PATCH 1/4 drm/i915/params: use generics for parameter printing
Replace the __builtin_strcmp() if ladder with generics.
--- drivers/gpu/drm/i915/i915_params.c | 55 +++++++++++++++++++----------- 1 file changed, 36 insertions(+), 19 deletions(-)
drivers/gpu/drm/i915/i915_params.c +36 -19
@@ -222,27 +222,44 @@ i915_param_named_unsafe(lmem_size, uint, 0400,i915_param_named_unsafe (lmem_bar_size, uint,0400 ,"Set the lmem bar size(in MiB)." ); -static __always_inline void _print_param(struct drm_printer *p, -const char *name, -const char *type, -const void *x) +static void _param_print_bool (struct drm_printer *p,const char *name, +bool val) { -if (!__builtin_strcmp (type,"bool" )) -drm_printf (p,"i915.%s=%s\n" , name, -str_yes_no (*(const bool *)x)); -else if (!__builtin_strcmp (type,"int" )) -drm_printf (p,"i915.%s=%d\n" , name, *(const int *)x); -else if (!__builtin_strcmp (type,"unsigned int" )) -drm_printf (p,"i915.%s=%u\n" , name, *(const unsigned int *)x); -else if (!__builtin_strcmp (type,"unsigned long" )) -drm_printf (p,"i915.%s=%lu\n" , name, *(const unsigned long *)x); -else if (!__builtin_strcmp (type,"char *" )) -drm_printf (p,"i915.%s=%s\n" , name, *(const char **)x); -else -WARN_ONCE (1 ,"no printer defined for param type %s (i915.%s)\n" , - type, name); +drm_printf (p,"i915.%s=%s\n" , name,str_yes_no (val)); } +static void _param_print_int (struct drm_printer *p,const char *name, +int val) +{ +drm_printf (p,"i915.%s=%d\n" , name, val); +} + +static void _param_print_uint (struct drm_printer *p,const char *name, +unsigned int val) +{ +drm_printf (p,"i915.%s=%u\n" , name, val); +} + +static void _param_print_ulong (struct drm_printer *p,const char *name, +unsigned long val) +{ +drm_printf (p,"i915.%s=%lu\n" , name, val); +} + +static void _param_print_charp (struct drm_printer *p,const char *name, +const char *val) +{ +drm_printf (p,"i915.%s=%s\n" , name, val); +} + +#define _param_print (p, name, val) \ + _Generic(val, \ + bool: _param_print_bool, \ + int: _param_print_int, \ + unsigned int: _param_print_uint, \ + unsigned long: _param_print_ulong, \ + char *: _param_print_charp)(p, name, val) +/** * i915_params_dump - dump i915 modparams * @params: i915 modparams
@@ -252,7 +269,7 @@ static __always_inline void _print_param(struct drm_printer *p,*/ void i915_params_dump (const struct i915_params *params,struct drm_printer *p) { -#define T , x, ...) _print_param(p, #x, #T, ¶ms->x); +#define T , x, ...) _param_print(p, #x, params->x);I915_PARAMS_FOR_EACH (#undef PRINT }
Signature · 1 line
2.34.1
PATCH 2/4 drm/i915/params: use generics for parameter dup
Replace the __builtin_strcmp() if ladder with generics.
--- drivers/gpu/drm/i915/i915_params.c | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-)
drivers/gpu/drm/i915/i915_params.c +12 -4
@@ -274,16 +274,24 @@ void i915_params_dump(const struct i915_params *params, struct drm_printer *p)#undef PRINT } -static __always_inline void dup_param(const char *type, void *x) +static void _param_dup_charp (char **valp) { -if (!__builtin_strcmp (type,"char *" )) - *(void **)x =kstrdup (*(void **)x,GFP_ATOMIC ); + *valp =kstrdup (*valp,GFP_ATOMIC ); } +static void _param_nop (void *valp) +{ +} + +#define _param_dup (valp) \ + _Generic(valp, \ + char **: _param_dup_charp, \ + default: _param_nop)(valp) +void i915_params_copy (struct i915_params *dest,const struct i915_params *src) { *dest = *src; -#define DUP (T , x, ...) dup_param(#T, &dest->x); +#define DUP (T , x, ...) _param_dup(&dest->x);I915_PARAMS_FOR_EACH (DUP );#undef DUP }
Signature · 1 line
2.34.1
PATCH 3/4 drm/i915/params: use generics for parameter free
In reply to Jani NikulaReplace the __builtin_strcmp() if ladder with generics.
--- drivers/gpu/drm/i915/i915_params.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-)
drivers/gpu/drm/i915/i915_params.c +9 -6
@@ -296,18 +296,21 @@ void i915_params_copy(struct i915_params *dest, const struct i915_params *src)#undef DUP } -static __always_inline void free_param(const char *type, void *x) +static void _param_free_charp (char **valp) { -if (!__builtin_strcmp (type,"char *" )) { -kfree (*(void **)x); - *(void **)x =NULL ; - } +kfree (*valp); + *valp =NULL ; } +#define _param_free (valp) \ + _Generic(valp, \ + char **: _param_free_charp, \ + default: _param_nop)(valp) +/* free the allocated members, *not* the passed in params itself */ void i915_params_free (struct i915_params *params) { -#define FREE (T , x, ...) free_param(#T, ¶ms->x); +#define FREE (T , x, ...) _param_free(¶ms->x);I915_PARAMS_FOR_EACH (FREE );#undef FREE }
Signature · 1 line
2.34.1
PATCH 4/4 drm/i915/params: use generics for parameter debugfs file creation
In reply to Jani NikulaReplace the __builtin_strcmp() if ladder with generics.
--- drivers/gpu/drm/i915/i915_debugfs_params.c | 33 ++++++++-------------- 1 file changed, 11 insertions(+), 22 deletions(-)
drivers/gpu/drm/i915/i915_debugfs_params.c +11 -22
@@ -230,27 +230,16 @@ i915_debugfs_create_charp(const char *name, umode_t mode, &i915_param_charp_fops); } -static __always_inline void -_i915_param_create_file (struct dentry *parent,const char *name, -const char *type,int mode,void *value) -{ -if (!mode) -return ; - -if (!__builtin_strcmp (type,"bool" )) -debugfs_create_bool (name, mode, parent, value); -else if (!__builtin_strcmp (type,"int" )) -i915_debugfs_create_int (name, mode, parent, value); -else if (!__builtin_strcmp (type,"unsigned int" )) -i915_debugfs_create_uint (name, mode, parent, value); -else if (!__builtin_strcmp (type,"unsigned long" )) -debugfs_create_ulong (name, mode, parent, value); -else if (!__builtin_strcmp (type,"char *" )) -i915_debugfs_create_charp (name, mode, parent, value); -else -WARN (1 ,"no debugfs fops defined for param type %s (i915.%s)\n" , - type, name); -} +#define _i915_param_create_file (parent, name, mode, valp) \ + do { \ + if (mode) \ + _Generic(valp, \ + bool *: debugfs_create_bool, \ + int *: i915_debugfs_create_int, \ + unsigned int *: i915_debugfs_create_uint, \ + unsigned long *: debugfs_create_ulong, \ + char **: i915_debugfs_create_charp)(name, mode, parent, valp); \ + } while(0)/* add a subdirectory with files for each i915 param */ struct dentry *i915_debugfs_params (struct drm_i915_private *i915)
@@ -269,7 +258,7 @@ struct dentry *i915_debugfs_params(struct drm_i915_private *i915)* just let the generic create file fail silently with -EEXIST. */ -#define REGISTER (T , x, unused, mode, ...) _i915_param_create_file(dir, #x, #T, mode, ¶ms->x); +#define REGISTER (T , x, unused, mode, ...) _i915_param_create_file(dir, #x, mode, ¶ms->x);I915_PARAMS_FOR_EACH (REGISTER );#undef REGISTER
Signature · 1 line
2.34.1
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/4] drm/i915/params: use generics for parameter printing
In reply to Jani Nikula== Series Details ==
== Series Details ==
Series: series starting with [1/4] drm/i915/params: use generics for parameter printing
URL : https://patchwork.freedesktop.org/series/113033/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12605 -> Patchwork_113033v1
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113033v1/index.html
Participating hosts (43 -> 40)
------------------------------
Missing (3): fi-bsw-kefka fi-rkl-11600 fi-snb-2520m
Known issues
------------
Here are the changes found in Patchwork_113033v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_chamelium_hpd@common-hpd-after-suspend:
- fi-rkl-guc: NOTRUN -> [SKIP][1] ([i915#7828])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113033v1/fi-rkl-guc/igt@[email protected]
#### Possible fixes ####
* igt@i915_selftest@live@gt_heartbeat:
- fi-apl-guc: [DMESG-FAIL][2] ([i915#5334]) -> [PASS][3]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12605/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113033v1/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
* igt@i915_selftest@live@hangcheck:
- fi-rkl-guc: [INCOMPLETE][4] ([i915#4983]) -> [PASS][5]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12605/fi-rkl-guc/igt@i915_selftest@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113033v1/fi-rkl-guc/igt@i915_selftest@[email protected]
* igt@i915_selftest@live@reset:
- {bat-rpls-2}: [DMESG-FAIL][6] ([i915#4983]) -> [PASS][7]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12605/bat-rpls-2/igt@i915_selftest@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113033v1/bat-rpls-2/igt@i915_selftest@[email protected]
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size:
- fi-bsw-n3050: [FAIL][8] ([i915#6298]) -> [PASS][9]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12605/fi-bsw-n3050/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113033v1/fi-bsw-n3050/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#6298]: https://gitlab.freedesktop.org/drm/intel/issues/6298
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#7699]: https://gitlab.freedesktop.org/drm/intel/issues/7699
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7834]: https://gitlab.freedesktop.org/drm/intel/issues/7834
Build changes
-------------
* Linux: CI_DRM_12605 -> Patchwork_113033v1
CI-20190529: 20190529
CI_DRM_12605: 1e863b59056127f55822b29a8f0cabf476806979 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7123: 2b29e8ac07fbcfadc48b9d60e4d736a6e3b289ab @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_113033v1: 1e863b59056127f55822b29a8f0cabf476806979 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
b33545e33098 drm/i915/params: use generics for parameter debugfs file creation f5d73fe8e54c drm/i915/params: use generics for parameter free 3564c8a66db2 drm/i915/params: use generics for parameter dup 9397dd9e04f7 drm/i915/params: use generics for parameter printing
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113033v1/index.html
Patchwork
CI[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/4] drm/i915/params: use generics for parameter printing
In reply to Jani Nikula== Series Details ==
== Series Details ==
Series: series starting with [1/4] drm/i915/params: use generics for parameter printing
URL : https://patchwork.freedesktop.org/series/113033/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12605_full -> Patchwork_113033v1_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113033v1/index.html
Participating hosts (12 -> 11)
------------------------------
Additional (1): shard-rkl0
Missing (2): pig-skl-6260u pig-kbl-iris
Known issues
------------
Here are the changes found in Patchwork_113033v1_full that come from known issues:
### IGT changes ###
#### Possible fixes ####
* igt@drm_fdinfo@virtual-idle:
- {shard-rkl}: [FAIL][1] ([i915#7742]) -> [PASS][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12605/shard-rkl-4/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113033v1/shard-rkl-5/igt@[email protected]
* igt@gem_ctx_exec@basic-nohangcheck:
- {shard-rkl}: [FAIL][3] ([i915#6268]) -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12605/shard-rkl-4/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113033v1/shard-rkl-6/igt@[email protected]
* igt@gem_eio@in-flight-suspend:
- {shard-rkl}: [FAIL][5] ([fdo#103375]) -> [PASS][6] +1 similar issue
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12605/shard-rkl-4/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113033v1/shard-rkl-6/igt@[email protected]
* igt@gem_exec_fair@basic-deadline:
- shard-glk: [FAIL][7] ([i915#2846]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12605/shard-glk9/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113033v1/shard-glk8/igt@[email protected]
* igt@gem_exec_fair@basic-none@vcs0:
- shard-glk: [FAIL][9] ([i915#2842]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12605/shard-glk8/igt@gem_exec_fair@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113033v1/shard-glk5/igt@gem_exec_fair@[email protected]
* igt@gem_exec_reloc@basic-write-read-active:
- {shard-rkl}: [SKIP][11] ([i915#3281]) -> [PASS][12] +13 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12605/shard-rkl-4/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113033v1/shard-rkl-5/igt@[email protected]
* igt@gem_exec_schedule@semaphore-power:
- {shard-rkl}: [SKIP][13] ([i915#7276]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12605/shard-rkl-2/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113033v1/shard-rkl-5/igt@[email protected]
* igt@gem_partial_pwrite_pread@writes-after-reads-uncached:
- {shard-rkl}: [SKIP][15] ([i915#3282]) -> [PASS][16] +3 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12605/shard-rkl-2/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113033v1/shard-rkl-5/igt@[email protected]
* igt@gen9_exec_parse@shadow-peek:
- {shard-rkl}: [SKIP][17] ([i915#2527]) -> [PASS][18] +3 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12605/shard-rkl-4/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113033v1/shard-rkl-5/igt@[email protected]
* igt@i915_pm_rc6_residency@rc6-idle@vcs0:
- {shard-rkl}: [WARN][19] ([i915#2681]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12605/shard-rkl-5/igt@i915_pm_rc6_residency@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113033v1/shard-rkl-6/igt@i915_pm_rc6_residency@[email protected]
* igt@i915_pm_rpm@dpms-mode-unset-lpsp:
- {shard-rkl}: [SKIP][21] ([i915#1397]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12605/shard-rkl-2/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113033v1/shard-rkl-6/igt@[email protected]
- {shard-dg1}: [SKIP][23] ([i915#1397]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12605/shard-dg1-18/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113033v1/shard-dg1-14/igt@[email protected]
- {shard-tglu}: [SKIP][25] ([i915#1397]) -> [PASS][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12605/shard-tglu-6/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113033v1/shard-tglu-3/igt@[email protected]
* igt@i915_pm_rpm@system-suspend-modeset:
- {shard-rkl}: [SKIP][27] ([fdo#109308]) -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12605/shard-rkl-2/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113033v1/shard-rkl-6/igt@[email protected]
- {shard-tglu}: [SKIP][29] ([i915#3547]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12605/shard-tglu-6/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113033v1/shard-tglu-3/igt@[email protected]
* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy:
- shard-glk: [FAIL][31] ([i915#72]) -> [PASS][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12605/shard-glk3/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113033v1/shard-glk1/igt@[email protected]
* igt@kms_draw_crc@fill-fb:
- {shard-tglu}: [SKIP][33] ([i915#1845]) -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12605/shard-tglu-6/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113033v1/shard-tglu-3/igt@[email protected]
* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@bc-hdmi-a1-hdmi-a2:
- shard-glk: [FAIL][35] ([i915#79]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12605/shard-glk6/igt@kms_flip@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113033v1/shard-glk6/igt@kms_flip@[email protected]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-plflip-blt:
- {shard-tglu}: [SKIP][37] ([i915#1849]) -> [PASS][38] +1 similar issue
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12605/shard-tglu-6/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113033v1/shard-tglu-3/igt@[email protected]
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-indfb-plflip-blt:
- {shard-rkl}: [SKIP][39] ([i915#1849] / [i915#4098]) -> [PASS][40] +19 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12605/shard-rkl-2/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113033v1/shard-rkl-6/igt@[email protected]
* igt@kms_plane@plane-position-hole@pipe-b-planes:
- {shard-rkl}: [SKIP][41] ([i915#1849]) -> [PASS][42] +6 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12605/shard-rkl-5/igt@kms_plane@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113033v1/shard-rkl-6/igt@kms_plane@[email protected]
* igt@kms_psr@suspend:
- {shard-rkl}: [SKIP][43] ([i915#1072]) -> [PASS][44] +1 similar issue
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12605/shard-rkl-2/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113033v1/shard-rkl-6/igt@[email protected]
* igt@kms_universal_plane@cursor-fb-leak-pipe-c:
- {shard-tglu}: [SKIP][45] ([fdo#109274]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12605/shard-tglu-6/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113033v1/shard-tglu-3/igt@[email protected]
* igt@kms_universal_plane@disable-primary-vs-flip-pipe-b:
- {shard-rkl}: [SKIP][47] ([i915#1845] / [i915#4070] / [i915#4098]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12605/shard-rkl-2/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113033v1/shard-rkl-6/igt@[email protected]
* igt@kms_vblank@pipe-a-wait-busy:
- {shard-tglu}: [SKIP][49] ([i915#7651]) -> [PASS][50] +8 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12605/shard-tglu-6/igt@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113033v1/shard-tglu-3/igt@[email protected]
* igt@kms_vblank@pipe-b-ts-continuation-idle:
- {shard-rkl}: [SKIP][51] ([i915#1845] / [i915#4098]) -> [PASS][52] +38 similar issues
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12605/shard-rkl-2/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113033v1/shard-rkl-6/igt@[email protected]
* igt@kms_vblank@pipe-b-ts-continuation-idle-hang:
- {shard-tglu}: [SKIP][53] ([i915#1845] / [i915#7651]) -> [PASS][54] +1 similar issue
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12605/shard-tglu-6/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113033v1/shard-tglu-3/igt@[email protected]
* igt@sysfs_timeslice_duration@timeout@vcs1:
- {shard-dg1}: [FAIL][55] ([i915#1755]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12605/shard-dg1-15/igt@sysfs_timeslice_duration@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113033v1/shard-dg1-18/igt@sysfs_timeslice_duration@[email protected]
* igt@testdisplay:
- {shard-rkl}: [SKIP][57] ([i915#4098]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12605/shard-rkl-2/[email protected]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113033v1/shard-rkl-6/[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308
[fdo#109309]: https://bugs.freedesktop.org/show_bug.cgi?id=109309
[fdo#109312]: https://bugs.freedesktop.org/show_bug.cgi?id=109312
[fdo#109313]: https://bugs.freedesktop.org/show_bug.cgi?id=109313
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111644]: https://bugs.freedesktop.org/show_bug.cgi?id=111644
[fdo#111656]: https://bugs.freedesktop.org/show_bug.cgi?id=111656
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1755]: https://gitlab.freedesktop.org/drm/intel/issues/1755
[i915#1769]: https://gitlab.freedesktop.org/drm/intel/issues/1769
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2232]: https://gitlab.freedesktop.org/drm/intel/issues/2232
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#284]: https://gitlab.freedesktop.org/drm/intel/issues/284
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3323]: https://gitlab.freedesktop.org/drm/intel/issues/3323
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3469]: https://gitlab.freedesktop.org/drm/intel/issues/3469
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3547]: https://gitlab.freedesktop.org/drm/intel/issues/3547
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558
[i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3639]: https://gitlab.freedesktop.org/drm/intel/issues/3639
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
[i915#3825]: https://gitlab.freedesktop.org/drm/intel/issues/3825
[i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4387]: https://gitlab.freedesktop.org/drm/intel/issues/4387
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4767]: https://gitlab.freedesktop.org/drm/intel/issues/4767
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#5327]: https://gitlab.freedesktop.org/drm/intel/issues/5327
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439
[i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6227]: https://gitlab.freedesktop.org/drm/intel/issues/6227
[i915#6230]: https://gitlab.freedesktop.org/drm/intel/issues/6230
[i915#6245]: https://gitlab.freedesktop.org/drm/intel/issues/6245
[i915#6252]: https://gitlab.freedesktop.org/drm/intel/issues/6252
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#6334]: https://gitlab.freedesktop.org/drm/intel/issues/6334
[i915#6335]: https://gitlab.freedesktop.org/drm/intel/issues/6335
[i915#6412]: https://gitlab.freedesktop.org/drm/intel/issues/6412
[i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
[i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
[i915#6944]: https://gitlab.freedesktop.org/drm/intel/issues/6944
[i915#6946]: https://gitlab.freedesktop.org/drm/intel/issues/6946
[i915#6953]: https://gitlab.freedesktop.org/drm/intel/issues/6953
[i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
[i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
[i915#72]: https://gitlab.freedesktop.org/drm/intel/issues/72
[i915#7276]: https://gitlab.freedesktop.org/drm/intel/issues/7276
[i915#7456]: https://gitlab.freedesktop.org/drm/intel/issues/7456
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
[i915#7651]: https://gitlab.freedesktop.org/drm/intel/issues/7651
[i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697
[i915#7707]: https://gitlab.freedesktop.org/drm/intel/issues/7707
[i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
Build changes
-------------
* Linux: CI_DRM_12605 -> Patchwork_113033v1
* Piglit: piglit_4509 -> None
CI-20190529: 20190529
CI_DRM_12605: 1e863b59056127f55822b29a8f0cabf476806979 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7123: 2b29e8ac07fbcfadc48b9d60e4d736a6e3b289ab @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_113033v1: 1e863b59056127f55822b29a8f0cabf476806979 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113033v1/index.html
Quoted 4 lines · Jani Nikula
Replace the
__builtin_strcmp()if ladder with generics.Signed-off-by Jani Nikula <[email protected]>---
Neat! I learned something new. For the whole series:
Quoted 79 lines
drivers/gpu/drm/i915/i915_params.c | 55 +++++++++++++++++++----------- 1 file changed, 36 insertions(+), 19 deletions(-)drivers/gpu/drm/i915/i915_params.c +36
-19@@ -222,27 +222,44 @@ i915_param_named_unsafe(lmem_size, uint, 0400,i915_param_named_unsafe (lmem_bar_size, uint,0400 ,"Set the lmem bar size(in MiB)." ); -static __always_inline void _print_param(struct drm_printer *p, -const char *name, -const char *type, -const void *x) +static void _param_print_bool (struct drm_printer *p,const char *name, +bool val) { -if (!__builtin_strcmp (type,"bool" )) -drm_printf (p,"i915.%s=%s\n" , name, -str_yes_no (*(const bool *)x)); -else if (!__builtin_strcmp (type,"int" )) -drm_printf (p,"i915.%s=%d\n" , name, *(const int *)x); -else if (!__builtin_strcmp (type,"unsigned int" )) -drm_printf (p,"i915.%s=%u\n" , name, *(const unsigned int *)x); -else if (!__builtin_strcmp (type,"unsigned long" )) -drm_printf (p,"i915.%s=%lu\n" , name, *(const unsigned long *)x); -else if (!__builtin_strcmp (type,"char *" )) -drm_printf (p,"i915.%s=%s\n" , name, *(const char **)x); -else -WARN_ONCE (1 ,"no printer defined for param type %s (i915.%s)\n" , - type, name); +drm_printf (p,"i915.%s=%s\n" , name,str_yes_no (val)); } +static void _param_print_int (struct drm_printer *p,const char *name, +int val) +{ +drm_printf (p,"i915.%s=%d\n" , name, val); +} + +static void _param_print_uint (struct drm_printer *p,const char *name, +unsigned int val) +{ +drm_printf (p,"i915.%s=%u\n" , name, val); +} + +static void _param_print_ulong (struct drm_printer *p,const char *name, +unsigned long val) +{ +drm_printf (p,"i915.%s=%lu\n" , name, val); +} + +static void _param_print_charp (struct drm_printer *p,const char *name, +const char *val) +{ +drm_printf (p,"i915.%s=%s\n" , name, val); +} + +#define _param_print (p, name, val) \ + _Generic(val, \ + bool: _param_print_bool, \ + int: _param_print_int, \ + unsigned int: _param_print_uint, \ + unsigned long: _param_print_ulong, \ + char *: _param_print_charp)(p, name, val) +/** * i915_params_dump - dump i915 modparams * @params: i915 modparams @@ -252,7 +269,7 @@ static __always_inline void _print_param(struct drm_printer *p,*/ void i915_params_dump (const struct i915_params *params,struct drm_printer *p) { -#define T , x, ...) _print_param(p, #x, #T, ¶ms->x); +#define T , x, ...) _param_print(p, #x, params->x);I915_PARAMS_FOR_EACH (#undef PRINT }
Quoted 9 lines · Luca Coelho
Quoted 4 lines · Jani Nikula
Replace the
__builtin_strcmp()if ladder with generics.Signed-off-by Jani Nikula <[email protected]>---
Neat! I learned something new. For the whole series:
Reviewed-by Luca Coelho <[email protected]>
Thanks for the review, pushed to drm-intel-next.
BR,
Jani.
Signature · 1 line
Jani Nikula, Intel Open Source Graphics Center