Skip to contentSkip to conversation

drm/i915: Use graphics ver, rel info for media on old platforms

PATCH In review Radhakrishna Sripada 4 participants 8 messages Oct 10, 2022 – Oct 11, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915: Use graphics ver, rel info for media on old platforms

Platforms prior to MTL do not have a separate media and graphics version. On platforms where GMD id is not supported, reuse the graphics ip version, release info for media.

The rest of the IP graphics, display versions would be copied during driver creation.

While at it warn if GMD is not used for platforms greater than gen12.

Fixes c2c7075225ef ("drm/i915: Read graphics/media/display arch version from hw")
Cc Jani Nikula <[email protected]>
Cc Lucas De Marchi <[email protected]>
Cc Matt Roper <[email protected]>
---
 drivers/gpu/drm/i915/intel_device_info.c | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_device_info.c +11 -1
index 090097bb3c0a..ba178b61bceb 100644
@@ -329,8 +329,18 @@ static void intel_ipver_early_init(struct drm_i915_private *i915)
 {
 	struct intel_runtime_info *runtime = RUNTIME_INFO(i915);
 
-	if (!HAS_GMD_ID(i915))
+	if (!HAS_GMD_ID(i915)) {
+		drm_WARN_ON(&i915->drm, RUNTIME_INFO(i915)->graphics.ip.ver > 12);
+		/*
+		 * On older platforms, graphics and media share the same ip
+		 * version and release.
+		 */
+		RUNTIME_INFO(i915)->media.ip.ver =
+			RUNTIME_INFO(i915)->graphics.ip.ver;
+		RUNTIME_INFO(i915)->media.ip.rel =
+			RUNTIME_INFO(i915)->graphics.ip.rel;
 		return;
+	}
 
 	ip_ver_read(i915, i915_mmio_reg_offset(GMD_ID_GRAPHICS),
 		    &runtime->graphics.ip);
Signature · 1 line
2.34.1
#1 lore raw

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Use graphics ver, rel info for media on old platforms

== Series Details ==

== Series Details ==

Series: drm/i915: Use graphics ver, rel info for media on old platforms
URL : https://patchwork.freedesktop.org/series/109561/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_12231 -> Patchwork_109561v1
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109561v1/index.html

Participating hosts (46 -> 43)
------------------------------

Missing (3): fi-ctg-p8600 fi-icl-u2 fi-tgl-dsi

Known issues
------------

Here are the changes found in Patchwork_109561v1 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@i915_pm_rpm@module-reload:
- fi-cfl-8109u: [PASS][1] -> [DMESG-FAIL][2] ([i915#62])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12231/fi-cfl-8109u/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109561v1/fi-cfl-8109u/igt@[email protected]

* igt@i915_selftest@live@hangcheck:
- fi-snb-2600: [PASS][3] -> [INCOMPLETE][4] ([i915#6992])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12231/fi-snb-2600/igt@i915_selftest@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109561v1/fi-snb-2600/igt@i915_selftest@[email protected]

* igt@i915_selftest@live@late_gt_pm:
- fi-cfl-8109u: [PASS][5] -> [DMESG-WARN][6] ([i915#5904]) +30 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12231/fi-cfl-8109u/igt@i915_selftest@live@late_gt_pm.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109561v1/fi-cfl-8109u/igt@i915_selftest@live@late_gt_pm.html

* igt@i915_suspend@basic-s2idle-without-i915:
- fi-cfl-8109u: [PASS][7] -> [DMESG-WARN][8] ([i915#5904] / [i915#62])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12231/fi-cfl-8109u/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109561v1/fi-cfl-8109u/igt@[email protected]

* igt@kms_chamelium@common-hpd-after-suspend:
- fi-ivb-3770: NOTRUN -> [SKIP][9] ([fdo#109271] / [fdo#111827])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109561v1/fi-ivb-3770/igt@[email protected]
- fi-hsw-g3258: NOTRUN -> [SKIP][10] ([fdo#109271] / [fdo#111827])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109561v1/fi-hsw-g3258/igt@[email protected]
- fi-bdw-5557u: NOTRUN -> [SKIP][11] ([fdo#109271] / [fdo#111827])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109561v1/fi-bdw-5557u/igt@[email protected]

* igt@kms_frontbuffer_tracking@basic:
- fi-cfl-8109u: [PASS][12] -> [DMESG-WARN][13] ([i915#62]) +14 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12231/fi-cfl-8109u/igt@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109561v1/fi-cfl-8109u/igt@[email protected]

#### Possible fixes ####

* igt@gem_exec_suspend@basic-s0@smem:
- {bat-adlm-1}: [DMESG-WARN][14] ([i915#2867]) -> [PASS][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12231/bat-adlm-1/igt@gem_exec_suspend@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109561v1/bat-adlm-1/igt@gem_exec_suspend@[email protected]

* igt@i915_selftest@live@gt_pm:
- {bat-rpls-2}: [DMESG-FAIL][16] ([i915#4258]) -> [PASS][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12231/bat-rpls-2/igt@i915_selftest@live@gt_pm.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109561v1/bat-rpls-2/igt@i915_selftest@live@gt_pm.html

* igt@i915_selftest@live@hangcheck:
- fi-ivb-3770: [INCOMPLETE][18] -> [PASS][19]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12231/fi-ivb-3770/igt@i915_selftest@[email protected]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109561v1/fi-ivb-3770/igt@i915_selftest@[email protected]
- fi-hsw-g3258: [INCOMPLETE][20] ([i915#3303] / [i915#4785]) -> [PASS][21]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12231/fi-hsw-g3258/igt@i915_selftest@[email protected]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109561v1/fi-hsw-g3258/igt@i915_selftest@[email protected]

* igt@i915_suspend@basic-s3-without-i915:
- fi-bdw-5557u: [INCOMPLETE][22] ([i915#146] / [i915#6712]) -> [PASS][23]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12231/fi-bdw-5557u/igt@[email protected]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109561v1/fi-bdw-5557u/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#146]: https://gitlab.freedesktop.org/drm/intel/issues/146
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
[i915#3303]: https://gitlab.freedesktop.org/drm/intel/issues/3303
[i915#4258]: https://gitlab.freedesktop.org/drm/intel/issues/4258
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4785]: https://gitlab.freedesktop.org/drm/intel/issues/4785
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5904]: https://gitlab.freedesktop.org/drm/intel/issues/5904
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6712]: https://gitlab.freedesktop.org/drm/intel/issues/6712
[i915#6992]: https://gitlab.freedesktop.org/drm/intel/issues/6992
[i915#6997]: https://gitlab.freedesktop.org/drm/intel/issues/6997
[i915#7029]: https://gitlab.freedesktop.org/drm/intel/issues/7029
[i915#7031]: https://gitlab.freedesktop.org/drm/intel/issues/7031

Build changes
-------------

* Linux: CI_DRM_12231 -> Patchwork_109561v1

CI-20190529: 20190529
CI_DRM_12231: bb84c1baa34eed834400e9a3cf9642840be002e1 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7007: 39a979fb4453c557022f0477c609afe10a049e48 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_109561v1: bb84c1baa34eed834400e9a3cf9642840be002e1 @ git://anongit.freedesktop.org/gfx-ci/linux

### Linux commits

c7735de77003 drm/i915: Use graphics ver, rel info for media on old platforms

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109561v1/index.html

#2 lore raw

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Use graphics ver, rel info for media on old platforms

In reply to Radhakrishna Sripada
== Series Details ==

== Series Details ==

Series: drm/i915: Use graphics ver, rel info for media on old platforms
URL : https://patchwork.freedesktop.org/series/109561/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_12231_full -> Patchwork_109561v1_full
====================================================

Summary
-------

**SUCCESS**

No regressions found.

Participating hosts (9 -> 9)
------------------------------

No changes in participating hosts

Known issues
------------

Here are the changes found in Patchwork_109561v1_full that come from known issues:

### CI changes ###

#### Possible fixes ####

* boot:
- shard-skl: ([PASS][1], [PASS][2], [PASS][3], [PASS][4], [PASS][5], [PASS][6], [PASS][7], [PASS][8], [PASS][9], [PASS][10], [PASS][11], [PASS][12], [PASS][13], [PASS][14], [FAIL][15], [PASS][16], [PASS][17], [PASS][18], [PASS][19], [PASS][20], [PASS][21], [PASS][22], [PASS][23], [PASS][24]) ([i915#5032]) -> ([PASS][25], [PASS][26], [PASS][27], [PASS][28], [PASS][29], [PASS][30], [PASS][31], [PASS][32], [PASS][33], [PASS][34], [PASS][35], [PASS][36], [PASS][37], [PASS][38], [PASS][39], [PASS][40], [PASS][41], [PASS][42], [PASS][43], [PASS][44], [PASS][45], [PASS][46], [PASS][47], [PASS][48], [PASS][49])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12231/shard-skl10/boot.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12231/shard-skl10/boot.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12231/shard-skl1/boot.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12231/shard-skl1/boot.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12231/shard-skl1/boot.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12231/shard-skl3/boot.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12231/shard-skl3/boot.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12231/shard-skl3/boot.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12231/shard-skl4/boot.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12231/shard-skl4/boot.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12231/shard-skl4/boot.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12231/shard-skl5/boot.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12231/shard-skl5/boot.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12231/shard-skl5/boot.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12231/shard-skl5/boot.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12231/shard-skl6/boot.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12231/shard-skl6/boot.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12231/shard-skl6/boot.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12231/shard-skl6/boot.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12231/shard-skl7/boot.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12231/shard-skl7/boot.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12231/shard-skl7/boot.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12231/shard-skl9/boot.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12231/shard-skl9/boot.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109561v1/shard-skl9/boot.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109561v1/shard-skl9/boot.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109561v1/shard-skl9/boot.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109561v1/shard-skl9/boot.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109561v1/shard-skl7/boot.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109561v1/shard-skl7/boot.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109561v1/shard-skl7/boot.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109561v1/shard-skl6/boot.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109561v1/shard-skl6/boot.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109561v1/shard-skl6/boot.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109561v1/shard-skl5/boot.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109561v1/shard-skl5/boot.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109561v1/shard-skl5/boot.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109561v1/shard-skl4/boot.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109561v1/shard-skl4/boot.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109561v1/shard-skl4/boot.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109561v1/shard-skl3/boot.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109561v1/shard-skl3/boot.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109561v1/shard-skl1/boot.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109561v1/shard-skl1/boot.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109561v1/shard-skl1/boot.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109561v1/shard-skl1/boot.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109561v1/shard-skl10/boot.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109561v1/shard-skl10/boot.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109561v1/shard-skl10/boot.html

### IGT changes ###

#### Issues hit ####

* igt@gem_ctx_exec@basic-nohangcheck:
- shard-tglb: [PASS][50] -> [FAIL][51] ([i915#6268])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12231/shard-tglb3/igt@[email protected]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109561v1/shard-tglb5/igt@[email protected]

* igt@gem_exec_endless@dispatch@vcs0:
- shard-tglb: [PASS][52] -> [INCOMPLETE][53] ([i915#3778])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12231/shard-tglb7/igt@gem_exec_endless@[email protected]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109561v1/shard-tglb1/igt@gem_exec_endless@[email protected]

* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-apl: [PASS][54] -> [FAIL][55] ([i915#2842])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12231/shard-apl7/igt@gem_exec_fair@[email protected]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109561v1/shard-apl2/igt@gem_exec_fair@[email protected]

* igt@gem_lmem_swapping@heavy-random:
- shard-skl: NOTRUN -> [SKIP][56] ([fdo#109271] / [i915#4613]) +1 similar issue
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109561v1/shard-skl1/igt@[email protected]

* igt@gem_lmem_swapping@random:
- shard-apl: NOTRUN -> [SKIP][57] ([fdo#109271] / [i915#4613])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109561v1/shard-apl1/igt@[email protected]

* igt@gem_userptr_blits@input-checking:
- shard-apl: NOTRUN -> [DMESG-WARN][58] ([i915#4991])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109561v1/shard-apl8/igt@[email protected]

* igt@i915_selftest@live@gt_heartbeat:
- shard-glk: [PASS][59] -> [DMESG-FAIL][60] ([i915#5334])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12231/shard-glk9/igt@i915_selftest@live@gt_heartbeat.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109561v1/shard-glk7/igt@i915_selftest@live@gt_heartbeat.html
- shard-apl: [PASS][61] -> [DMESG-FAIL][62] ([i915#5334])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12231/shard-apl2/igt@i915_selftest@live@gt_heartbeat.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109561v1/shard-apl8/igt@i915_selftest@live@gt_heartbeat.html

* igt@i915_selftest@live@hangcheck:
- shard-snb: [PASS][63] -> [INCOMPLETE][64] ([i915#6992])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12231/shard-snb7/igt@i915_selftest@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109561v1/shard-snb7/igt@i915_selftest@[email protected]

* igt@i915_suspend@sysfs-reader:
- shard-apl: [PASS][65] -> [DMESG-WARN][66] ([i915#180]) +1 similar issue
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12231/shard-apl2/igt@[email protected]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109561v1/shard-apl3/igt@[email protected]

* igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][67] ([fdo#109271] / [i915#3886])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109561v1/shard-apl1/igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_gen12_mc_ccs.html

* igt@kms_ccs@pipe-a-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs_cc:
- shard-skl: NOTRUN -> [SKIP][68] ([fdo#109271] / [i915#3886]) +6 similar issues
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109561v1/shard-skl6/igt@kms_ccs@pipe-a-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs_cc.html

* igt@kms_color_chamelium@ctm-limited-range:
- shard-skl: NOTRUN -> [SKIP][69] ([fdo#109271] / [fdo#111827]) +4 similar issues
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109561v1/shard-skl6/igt@[email protected]

* igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size:
- shard-glk: [PASS][70] -> [FAIL][71] ([i915#2346]) +1 similar issue
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12231/shard-glk7/igt@kms_cursor_legacy@[email protected]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109561v1/shard-glk1/igt@kms_cursor_legacy@[email protected]

* igt@kms_cursor_legacy@flip-vs-cursor@toggle:
- shard-iclb: [PASS][72] -> [FAIL][73] ([i915#2346]) +3 similar issues
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12231/shard-iclb3/igt@kms_cursor_legacy@[email protected]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109561v1/shard-iclb7/igt@kms_cursor_legacy@[email protected]

* igt@kms_flip@flip-vs-suspend-interruptible@c-edp1:
- shard-skl: NOTRUN -> [INCOMPLETE][74] ([i915#4939])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109561v1/shard-skl6/igt@kms_flip@[email protected]

* igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1:
- shard-skl: [PASS][75] -> [FAIL][76] ([i915#2122]) +2 similar issues
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12231/shard-skl10/igt@kms_flip@[email protected]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109561v1/shard-skl5/igt@kms_flip@[email protected]

* igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-64bpp-4tile-downscaling@pipe-a-valid-mode:
- shard-iclb: NOTRUN -> [SKIP][77] ([i915#2587] / [i915#2672]) +3 similar issues
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109561v1/shard-iclb7/igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-64bpp-4tile-downscaling@pipe-a-valid-mode.html

* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-downscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][78] ([i915#3555]) +1 similar issue
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109561v1/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-downscaling@pipe-a-default-mode.html

* igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tile-downscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][79] ([i915#2672]) +3 similar issues
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109561v1/shard-iclb3/igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tile-downscaling@pipe-a-default-mode.html

* igt@kms_plane_alpha_blend@alpha-basic@pipe-a-edp-1:
- shard-skl: NOTRUN -> [FAIL][80] ([i915#4573]) +2 similar issues
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109561v1/shard-skl1/igt@kms_plane_alpha_blend@[email protected]

* igt@kms_psr2_sf@overlay-plane-move-continuous-sf:
- shard-skl: NOTRUN -> [SKIP][81] ([fdo#109271] / [i915#658])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109561v1/shard-skl6/igt@[email protected]

* igt@kms_psr2_su@page_flip-p010:
- shard-iclb: NOTRUN -> [SKIP][82] ([fdo#109642] / [fdo#111068] / [i915#658])
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109561v1/shard-iclb8/igt@kms_psr2_su@page_flip-p010.html

* igt@kms_psr@psr2_sprite_render:
- shard-iclb: [PASS][83] -> [SKIP][84] ([fdo#109441]) +2 similar issues
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12231/shard-iclb2/igt@kms_psr@psr2_sprite_render.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109561v1/shard-iclb8/igt@kms_psr@psr2_sprite_render.html

* igt@kms_rotation_crc@primary-4-tiled-reflect-x-180:
- shard-skl: NOTRUN -> [SKIP][85] ([fdo#109271]) +90 similar issues
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109561v1/shard-skl1/igt@[email protected]

* igt@kms_scaling_modes@scaling-mode-center:
- shard-apl: NOTRUN -> [SKIP][86] ([fdo#109271]) +26 similar issues
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109561v1/shard-apl3/igt@[email protected]

* igt@kms_writeback@writeback-invalid-parameters:
- shard-apl: NOTRUN -> [SKIP][87] ([fdo#109271] / [i915#2437])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109561v1/shard-apl1/igt@[email protected]

* igt@sysfs_clients@fair-1:
- shard-skl: NOTRUN -> [SKIP][88] ([fdo#109271] / [i915#2994])
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109561v1/shard-skl1/igt@[email protected]

#### Possible fixes ####

* igt@feature_discovery@psr2:
- shard-iclb: [SKIP][89] ([i915#658]) -> [PASS][90]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12231/shard-iclb5/igt@[email protected]
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109561v1/shard-iclb2/igt@[email protected]

* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [FAIL][91] ([i915#2842]) -> [PASS][92]
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12231/shard-glk8/igt@gem_exec_fair@[email protected]
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109561v1/shard-glk8/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-apl: [FAIL][93] ([i915#2842]) -> [PASS][94] +1 similar issue
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12231/shard-apl7/igt@gem_exec_fair@[email protected]
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109561v1/shard-apl7/igt@gem_exec_fair@[email protected]

* igt@i915_selftest@live@hangcheck:
- shard-tglb: [DMESG-WARN][95] ([i915#5591]) -> [PASS][96]
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12231/shard-tglb2/igt@i915_selftest@[email protected]
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109561v1/shard-tglb3/igt@i915_selftest@[email protected]

* igt@kms_async_flips@alternate-sync-async-flip@pipe-c-edp-1:
- shard-skl: [FAIL][97] ([i915#2521]) -> [PASS][98]
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12231/shard-skl7/igt@kms_async_flips@[email protected]
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109561v1/shard-skl1/igt@kms_async_flips@[email protected]

* igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-atomic:
- shard-skl: [FAIL][99] ([i915#2346]) -> [PASS][100]
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12231/shard-skl6/igt@[email protected]
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109561v1/shard-skl9/igt@[email protected]

* igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1:
- shard-skl: [FAIL][101] ([i915#79]) -> [PASS][102]
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12231/shard-skl4/igt@kms_flip@[email protected]
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109561v1/shard-skl10/igt@kms_flip@[email protected]

* igt@kms_flip@flip-vs-suspend-interruptible@b-dp1:
- shard-apl: [DMESG-WARN][103] ([i915#180]) -> [PASS][104] +2 similar issues
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12231/shard-apl2/igt@kms_flip@[email protected]
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109561v1/shard-apl1/igt@kms_flip@[email protected]

* igt@kms_flip@flip-vs-suspend@b-edp1:
- shard-skl: [INCOMPLETE][105] ([i915#4839]) -> [PASS][106]
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12231/shard-skl3/igt@kms_flip@[email protected]
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109561v1/shard-skl3/igt@kms_flip@[email protected]

* igt@kms_flip@plain-flip-ts-check@c-edp1:
- shard-skl: [FAIL][107] ([i915#2122]) -> [PASS][108] +3 similar issues
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12231/shard-skl6/igt@kms_flip@[email protected]
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109561v1/shard-skl5/igt@kms_flip@[email protected]

* igt@kms_psr@psr2_sprite_mmap_gtt:
- shard-iclb: [SKIP][109] ([fdo#109441]) -> [PASS][110] +2 similar issues
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12231/shard-iclb8/igt@kms_psr@psr2_sprite_mmap_gtt.html
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109561v1/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_gtt.html

* igt@perf@blocking:
- shard-skl: [FAIL][111] ([i915#1542]) -> [PASS][112]
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12231/shard-skl5/igt@[email protected]
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109561v1/shard-skl1/igt@[email protected]

#### Warnings ####

* igt@gem_exec_balancer@parallel-ordering:
- shard-iclb: [FAIL][113] ([i915#6117]) -> [SKIP][114] ([i915#4525])
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12231/shard-iclb1/igt@[email protected]
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109561v1/shard-iclb5/igt@[email protected]

* igt@kms_content_protection@legacy@pipe-a-dp-1:
- shard-apl: [INCOMPLETE][115] ([i915#7121]) -> [INCOMPLETE][116] ([i915#1319] / [i915#7121])
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12231/shard-apl6/igt@kms_content_protection@[email protected]
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109561v1/shard-apl7/igt@kms_content_protection@[email protected]

* igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-shrfb-draw-blt:
- shard-skl: [SKIP][117] ([fdo#109271]) -> [SKIP][118] ([fdo#109271] / [i915#1888]) +1 similar issue
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12231/shard-skl9/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-shrfb-draw-blt.html
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109561v1/shard-skl6/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-shrfb-draw-blt.html

* igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-fully-sf:
- shard-iclb: [SKIP][119] ([i915#658]) -> [SKIP][120] ([i915#2920])
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12231/shard-iclb5/igt@[email protected]
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109561v1/shard-iclb2/igt@[email protected]

* igt@kms_psr2_sf@overlay-plane-update-continuous-sf:
- shard-iclb: [SKIP][121] ([fdo#111068] / [i915#658]) -> [SKIP][122] ([i915#2920])
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12231/shard-iclb8/igt@[email protected]
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109561v1/shard-iclb2/igt@[email protected]

* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area:
- shard-iclb: [SKIP][123] ([i915#2920]) -> [SKIP][124] ([fdo#111068] / [i915#658])
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12231/shard-iclb2/igt@[email protected]
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109561v1/shard-iclb8/igt@[email protected]

[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319
[i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3778]: https://gitlab.freedesktop.org/drm/intel/issues/3778
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#4573]: https://gitlab.freedesktop.org/drm/intel/issues/4573
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4839]: https://gitlab.freedesktop.org/drm/intel/issues/4839
[i915#4939]: https://gitlab.freedesktop.org/drm/intel/issues/4939
[i915#4991]: https://gitlab.freedesktop.org/drm/intel/issues/4991
[i915#5032]: https://gitlab.freedesktop.org/drm/intel/issues/5032
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#5591]: https://gitlab.freedesktop.org/drm/intel/issues/5591
[i915#6117]: https://gitlab.freedesktop.org/drm/intel/issues/6117
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6992]: https://gitlab.freedesktop.org/drm/intel/issues/6992
[i915#7121]: https://gitlab.freedesktop.org/drm/intel/issues/7121
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79

Build changes
-------------

* Linux: CI_DRM_12231 -> Patchwork_109561v1

CI-20190529: 20190529
CI_DRM_12231: bb84c1baa34eed834400e9a3cf9642840be002e1 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7007: 39a979fb4453c557022f0477c609afe10a049e48 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_109561v1: bb84c1baa34eed834400e9a3cf9642840be002e1 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109561v1/index.html

maintainer
#3 lore raw
In reply to Radhakrishna Sripada
Quoted 27 lines · Radhakrishna Sripada

Platforms prior to MTL do not have a separate media and graphics version. On platforms where GMD id is not supported, reuse the graphics ip version, release info for media.

The rest of the IP graphics, display versions would be copied during driver creation.

While at it warn if GMD is not used for platforms greater than gen12.

Fixes c2c7075225ef ("drm/i915: Read graphics/media/display arch version from hw")
Cc Jani Nikula <[email protected]>
Cc Lucas De Marchi <[email protected]>
Cc Matt Roper <[email protected]>
---
 drivers/gpu/drm/i915/intel_device_info.c | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_device_info.c +0 -1
index 090097bb3c0a..ba178b61bceb 100644
@@ -329,8 +329,18 @@ static void intel_ipver_early_init(struct drm_i915_private *i915)
 {
 	struct intel_runtime_info *runtime = RUNTIME_INFO(i915);
 
-	if (!HAS_GMD_ID(i915))

drivers/gpu/drm/i915/intel_device_info.c static void intel_ipver_early_init(struct drm_i915_private *i915) · line 341

Quoted 10 lines
drivers/gpu/drm/i915/intel_device_info.c +10 -0
+	if (!HAS_GMD_ID(i915)) {
+		drm_WARN_ON(&i915->drm, RUNTIME_INFO(i915)->graphics.ip.ver > 12);
+		/*
+		 * On older platforms, graphics and media share the same ip
+		 * version and release.
+		 */
+		RUNTIME_INFO(i915)->media.ip.ver =
+			RUNTIME_INFO(i915)->graphics.ip.ver;
+		RUNTIME_INFO(i915)->media.ip.rel =
+			RUNTIME_INFO(i915)->graphics.ip.rel;

You could assign the whole struct ip_version (*) at once, or is there a reason you're intentionally not assigning step?

BR,
Jani.

(*) Why does that name not have intel_ prefix?

Quoted 5 lines
drivers/gpu/drm/i915/intel_device_info.c +1 -0
 		return;
+	}
 
 	ip_ver_read(i915, i915_mmio_reg_offset(GMD_ID_GRAPHICS),
 		    &runtime->graphics.ip);
Signature · 1 line
Jani Nikula, Intel Open Source Graphics Center
#4 lore raw

Hi Jani,

Quoted 43 lines

-----Original Message-----
From: Jani Nikula <[email protected]>
Sent: Tuesday, October 11, 2022 12:28 AM
To: Sripada, Radhakrishna <[email protected]>; intel- [email protected]
Cc: [email protected]; Sripada, Radhakrishna <[email protected]>; De Marchi, Lucas <[email protected]>; Roper, Matthew D <[email protected]>
Subject: Re: [PATCH] drm/i915: Use graphics ver, rel info for media on old platforms

Quoted 10 lines · Radhakrishna Sripada

Platforms prior to MTL do not have a separate media and graphics version. On platforms where GMD id is not supported, reuse the graphics ip version, release info for media.

The rest of the IP graphics, display versions would be copied during driver creation.

While at it warn if GMD is not used for platforms greater than gen12.

Fixes c2c7075225ef ("drm/i915: Read graphics/media/display arch version

from hw")

Review

Quoted 9 lines
Cc Jani Nikula <[email protected]>
Cc Lucas De Marchi <[email protected]>
Cc Matt Roper <[email protected]>
---
 drivers/gpu/drm/i915/intel_device_info.c | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)
(quoted diff) +0 -0

b/drivers/gpu/drm/i915/intel_device_info.c

drivers/gpu/drm/i915/intel_device_info.c static void intel_ipver_early_init(struct

Quoted 4 lines

index 090097bb3c0a..ba178b61bceb 100644

drivers/gpu/drm/i915/intel_device_info.c +0 -0
@@ -329,8 +329,18 @@ static void intel_ipver_early_init(struct

drm_i915_private *i915)

Quoted 3 lines
drivers/gpu/drm/i915/intel_device_info.c +0 -0
 {
 	struct intel_runtime_info *runtime = RUNTIME_INFO(i915);
 
Quoted 15 lines

drivers/gpu/drm/i915/intel_device_info.c static void intel_ipver_early_init(struct drm_i915_private *i915) · line 341

Quoted 12 lines
drivers/gpu/drm/i915/intel_device_info.c +10 -1
-	if (!HAS_GMD_ID(i915))
+	if (!HAS_GMD_ID(i915)) {
+		drm_WARN_ON(&i915->drm, RUNTIME_INFO(i915)-
 graphics.ip.ver > 12);
+		/*
+		 * On older platforms, graphics and media share the same ip
+		 * version and release.
+		 */
+		RUNTIME_INFO(i915)->media.ip.ver =
+			RUNTIME_INFO(i915)->graphics.ip.ver;
+		RUNTIME_INFO(i915)->media.ip.rel =
+			RUNTIME_INFO(i915)->graphics.ip.rel;

You could assign the whole struct ip_version (*) at once, or is there a reason you're intentionally not assigning step?

Step info would anyways be determined later in the function intel_step_init. We already have macros in place to handle common gt and media steps there.

Do you suggest we memcpy(&RUNTIME_INFO(i915)->media.ip, &RUNTIME_INFO->graphics.ip, sizeof(struct ip_version)) here?

Quoted 5 lines

BR,
Jani.

(*) Why does that name not have intel_ prefix?

Good question. Since introduced in " a5b7ef27da60 drm/i915: Add struct to hold IP version"
we have been using as is. The author might have felt that the structure is not big enough/used in as many places to have an intel_ prefix. Do you see a symbol collision here that we need to add intel_ prefix? If so should we do it in a separate patch?

Thanks,
Radhakrishna(RK) Sripada

Quoted 9 lines
Quoted 6 lines
drivers/gpu/drm/i915/intel_device_info.c +1 -0
 		return;
+	}
 
 	ip_ver_read(i915, i915_mmio_reg_offset(GMD_ID_GRAPHICS),

&runtime->graphics.ip);

--
Jani Nikula, Intel Open Source Graphics Center

maintainer
#5 lore raw
Quoted 60 lines · Radhakrishna

Hi Jani,

Quoted 43 lines

-----Original Message-----
From: Jani Nikula <[email protected]>
Sent: Tuesday, October 11, 2022 12:28 AM
To: Sripada, Radhakrishna <[email protected]>; intel- [email protected]
Cc: [email protected]; Sripada, Radhakrishna <[email protected]>; De Marchi, Lucas <[email protected]>; Roper, Matthew D <[email protected]>
Subject: Re: [PATCH] drm/i915: Use graphics ver, rel info for media on old platforms

Quoted 10 lines · Radhakrishna Sripada

Platforms prior to MTL do not have a separate media and graphics version. On platforms where GMD id is not supported, reuse the graphics ip version, release info for media.

The rest of the IP graphics, display versions would be copied during driver creation.

While at it warn if GMD is not used for platforms greater than gen12.

Fixes c2c7075225ef ("drm/i915: Read graphics/media/display arch version

from hw")

Review

Quoted 9 lines
Cc Jani Nikula <[email protected]>
Cc Lucas De Marchi <[email protected]>
Cc Matt Roper <[email protected]>
---
 drivers/gpu/drm/i915/intel_device_info.c | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)
(quoted diff) +0 -0

b/drivers/gpu/drm/i915/intel_device_info.c

drivers/gpu/drm/i915/intel_device_info.c static void intel_ipver_early_init(struct

Quoted 4 lines

index 090097bb3c0a..ba178b61bceb 100644

drivers/gpu/drm/i915/intel_device_info.c +0 -0
@@ -329,8 +329,18 @@ static void intel_ipver_early_init(struct

drm_i915_private *i915)

Quoted 3 lines
drivers/gpu/drm/i915/intel_device_info.c +0 -0
 {
 	struct intel_runtime_info *runtime = RUNTIME_INFO(i915);
 
Quoted 15 lines

drivers/gpu/drm/i915/intel_device_info.c static void intel_ipver_early_init(struct drm_i915_private *i915) · line 341

Quoted 12 lines
drivers/gpu/drm/i915/intel_device_info.c +10 -1
-	if (!HAS_GMD_ID(i915))
+	if (!HAS_GMD_ID(i915)) {
+		drm_WARN_ON(&i915->drm, RUNTIME_INFO(i915)-
 graphics.ip.ver > 12);
+		/*
+		 * On older platforms, graphics and media share the same ip
+		 * version and release.
+		 */
+		RUNTIME_INFO(i915)->media.ip.ver =
+			RUNTIME_INFO(i915)->graphics.ip.ver;
+		RUNTIME_INFO(i915)->media.ip.rel =
+			RUNTIME_INFO(i915)->graphics.ip.rel;

You could assign the whole struct ip_version (*) at once, or is there a reason you're intentionally not assigning step?

Quoted 4 lines

Step info would anyways be determined later in the function intel_step_init. We already have macros in place to handle common gt and media steps there.

Do you suggest we memcpy(&RUNTIME_INFO(i915)->media.ip, &RUNTIME_INFO->graphics.ip, sizeof(struct ip_version)) here?

Simple assign should do it for such a small struct.

BR,
Jani.

Quoted 10 lines
Quoted 6 lines

BR,
Jani.

(*) Why does that name not have intel_ prefix?

Good question. Since introduced in " a5b7ef27da60 drm/i915: Add struct to hold IP version"
we have been using as is. The author might have felt that the structure is not big enough/used in as many places to have an intel_ prefix. Do you see a symbol collision here that we
need to add intel_ prefix?

It's not just about avoiding any immediate symbol collisions, it's also about setting an example. People see this and think it's fine not to have the prefix. And then the practice proliferates until there's a collision.

Quoted 1 line

If so should we do it in a separate patch?

If there's a semantically separate change, it should always be a separate patch.

BR,
Jani.

Quoted 12 lines

Thanks,
Radhakrishna(RK) Sripada

Quoted 9 lines
Quoted 6 lines
drivers/gpu/drm/i915/intel_device_info.c +1 -0
 		return;
+	}
 
 	ip_ver_read(i915, i915_mmio_reg_offset(GMD_ID_GRAPHICS),

&runtime->graphics.ip);

--
Jani Nikula, Intel Open Source Graphics Center

Signature · 1 line
Jani Nikula, Intel Open Source Graphics Center
#6 lore raw
Quoted 61 lines · Jani Nikula
Quoted 60 lines · Radhakrishna

Hi Jani,

Quoted 58 lines

-----Original Message-----
From: Jani Nikula <[email protected]>
Sent: Tuesday, October 11, 2022 12:28 AM
To: Sripada, Radhakrishna <[email protected]>; intel- [email protected]
Cc: [email protected]; Sripada, Radhakrishna <[email protected]>; De Marchi, Lucas <[email protected]>; Roper, Matthew D <[email protected]>
Subject: Re: [PATCH] drm/i915: Use graphics ver, rel info for media on old platforms

Quoted 10 lines · Radhakrishna Sripada

Platforms prior to MTL do not have a separate media and graphics version. On platforms where GMD id is not supported, reuse the graphics ip version, release info for media.

The rest of the IP graphics, display versions would be copied during driver creation.

While at it warn if GMD is not used for platforms greater than gen12.

Fixes c2c7075225ef ("drm/i915: Read graphics/media/display arch version

from hw")

Review

Quoted 9 lines
Cc Jani Nikula <[email protected]>
Cc Lucas De Marchi <[email protected]>
Cc Matt Roper <[email protected]>
---
 drivers/gpu/drm/i915/intel_device_info.c | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)
(quoted diff) +0 -0

b/drivers/gpu/drm/i915/intel_device_info.c

drivers/gpu/drm/i915/intel_device_info.c static void intel_ipver_early_init(struct

Quoted 4 lines

index 090097bb3c0a..ba178b61bceb 100644

drivers/gpu/drm/i915/intel_device_info.c +0 -0
@@ -329,8 +329,18 @@ static void intel_ipver_early_init(struct

drm_i915_private *i915)

Quoted 5 lines
drivers/gpu/drm/i915/intel_device_info.c +1 -1
 {
 	struct intel_runtime_info *runtime = RUNTIME_INFO(i915);
 
-	if (!HAS_GMD_ID(i915))
+	if (!HAS_GMD_ID(i915)) {

drivers/gpu/drm/i915/intel_device_info.c static void intel_ipver_early_init(struct drm_i915_private *i915) · line 341

Quoted 10 lines
drivers/gpu/drm/i915/intel_device_info.c +9 -0
+		drm_WARN_ON(&i915->drm, RUNTIME_INFO(i915)-
 graphics.ip.ver > 12);
+		/*
+		 * On older platforms, graphics and media share the same ip
+		 * version and release.
+		 */
+		RUNTIME_INFO(i915)->media.ip.ver =
+			RUNTIME_INFO(i915)->graphics.ip.ver;
+		RUNTIME_INFO(i915)->media.ip.rel =
+			RUNTIME_INFO(i915)->graphics.ip.rel;

You could assign the whole struct ip_version (*) at once, or is there a reason you're intentionally not assigning step?

Quoted 6 lines
Quoted 4 lines

Step info would anyways be determined later in the function intel_step_init. We already have macros in place to handle common gt and media steps there.

Do you suggest we memcpy(&RUNTIME_INFO(i915)->media.ip, &RUNTIME_INFO->graphics.ip, sizeof(struct ip_version)) here?

Simple assign should do it for such a small struct.

IMO for any struct. Only use memcpy() when copying arrays and such.

Signature · 2 lines
Ville Syrjälä
Intel
#7 lore raw

Thank you for the feedback. Incorporated the review and posted new patches here [1].

Thanks,
Radhakrishna(RK) Sripada

[1] https://patchwork.freedesktop.org/series/109588/

Quoted 91 lines

-----Original Message-----
From: Ville Syrjälä <[email protected]>
Sent: Tuesday, October 11, 2022 3:33 AM
To: Jani Nikula <[email protected]>
Cc: Sripada, Radhakrishna <[email protected]>; intel- [email protected]; De Marchi, Lucas <[email protected]>; dri- [email protected]
Subject: Re: [Intel-gfx] [PATCH] drm/i915: Use graphics ver, rel info for media on old platforms

Quoted 1 line · Jani Nikula

On Tue, 11 Oct 2022, "Sripada, Radhakrishna"

Quoted 14 lines · <[email protected]> wrote:
Quoted 14 lines

Hi Jani,

Quoted 12 lines

-----Original Message-----
From: Jani Nikula <[email protected]>
Sent: Tuesday, October 11, 2022 12:28 AM
To: Sripada, Radhakrishna <[email protected]>; intel- [email protected]
Cc: [email protected]; Sripada, Radhakrishna <[email protected]>; De Marchi, Lucas <[email protected]>; Roper, Matthew D <[email protected]>
Subject: Re: [PATCH] drm/i915: Use graphics ver, rel info for media on old platforms

Quoted 1 line
Quoted 1 line
Quoted 1 line

On Mon, 10 Oct 2022, Radhakrishna Sripada

<[email protected]>

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 1 line · wrote:

Platforms prior to MTL do not have a separate media and graphics

version.

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

On platforms where GMD id is not supported, reuse the graphics ip

version,

Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines

release info for media.

The rest of the IP graphics, display versions would be copied during driver creation.

While at it warn if GMD is not used for platforms greater than gen12.

Fixes c2c7075225ef ("drm/i915: Read graphics/media/display arch

version

Quoted 34 lines
Quoted 34 lines
Quoted 34 lines

from hw")

Review

Quoted 9 lines
Cc Jani Nikula <[email protected]>
Cc Lucas De Marchi <[email protected]>
Cc Matt Roper <[email protected]>
---
 drivers/gpu/drm/i915/intel_device_info.c | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)
(quoted diff) +0 -0

b/drivers/gpu/drm/i915/intel_device_info.c

drivers/gpu/drm/i915/intel_device_info.c static void intel_ipver_early_init(struct

Quoted 4 lines

index 090097bb3c0a..ba178b61bceb 100644

drivers/gpu/drm/i915/intel_device_info.c +0 -0
@@ -329,8 +329,18 @@ static void intel_ipver_early_init(struct

drm_i915_private *i915)

Quoted 5 lines
drivers/gpu/drm/i915/intel_device_info.c +1 -1
 {
 	struct intel_runtime_info *runtime = RUNTIME_INFO(i915);
 
-	if (!HAS_GMD_ID(i915))
+	if (!HAS_GMD_ID(i915)) {

drivers/gpu/drm/i915/intel_device_info.c static void intel_ipver_early_init(struct drm_i915_private *i915) · line 341

Quoted 10 lines
drivers/gpu/drm/i915/intel_device_info.c +9 -0
+		drm_WARN_ON(&i915->drm, RUNTIME_INFO(i915)-
 graphics.ip.ver > 12);
+		/*
+		 * On older platforms, graphics and media share the same ip
+		 * version and release.
+		 */
+		RUNTIME_INFO(i915)->media.ip.ver =
+			RUNTIME_INFO(i915)->graphics.ip.ver;
+		RUNTIME_INFO(i915)->media.ip.rel =
+			RUNTIME_INFO(i915)->graphics.ip.rel;

You could assign the whole struct ip_version (*) at once, or is there a reason you're intentionally not assigning step?

Quoted 2 lines
Quoted 2 lines

Step info would anyways be determined later in the function intel_step_init. We already have macros in place to handle common gt and media steps

there.

Quoted 2 lines
Quoted 2 lines

Do you suggest we memcpy(&RUNTIME_INFO(i915)->media.ip,

&RUNTIME_INFO->graphics.ip, sizeof(struct ip_version)) here?

Quoted 2 lines

Simple assign should do it for such a small struct.

IMO for any struct. Only use memcpy() when copying arrays and such.

--
Ville Syrjälä
Intel