usb: gadget: f_hid: idle uses the highest byte for duration
PATCH 1/1 usb: gadget: f_hid: idle uses the highest byte for duration
SET_IDLE value must be shifted 8 bits to the right to get duration. This confirmed by USBCV test.
--- drivers/usb/gadget/function/f_hid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/usb/gadget/function/f_hid.c +1 -1
@@ -573,7 +573,7 @@ static int hidg_setup(struct usb_function *f, | HID_REQ_SET_IDLE):VDBG (cdev,"set_idle\n" ); length =0 ; - hidg->idle = value; + hidg->idle = value >>8 ; goto respond;break ;
Signature · 1 line
2.32.0
Greg KH
maintainerQuoted 24 lines · Maxim Devaev
SET_IDLEvalue must be shifted 8 bits to the right to get duration. This confirmed by USBCV test.Signed-off-by Maxim Devaev <[email protected]>--- drivers/usb/gadget/function/f_hid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/usb/gadget/function/f_hid.c +1
-1@@ -573,7 +573,7 @@ static int hidg_setup(struct usb_function *f, | HID_REQ_SET_IDLE):VDBG (cdev,"set_idle\n" ); length =0 ; - hidg->idle = value; + hidg->idle = value >>8 ; goto respond;break ;Signature · 1 line
2.32.0
You forgot to mention what commit this fixes up:
I've added it to the patch now, but try to remember it next time.
thanks,
greg k-h
Quoted 6 lines
Greg KH <[email protected]> wrote:
You forgot to mention what commit this fixes up:Fixes afcff6dc690e ("usb: gadget: f_hid: added GET_IDLE and SET_IDLE handlers")I've added it to the patch now, but try to remember it next time.
This is quite new for me, thank you for suggesting it and for your patience.
Hi,
Quoted 4 lines · Maxim Devaev
SET_IDLEvalue must be shifted 8 bits to the right to get duration. This confirmed by USBCV test.Signed-off-by Maxim Devaev <[email protected]>
with Greg's Fixes addition:
Signature · 1 line
balbi
Greg KH
maintainerQuoted 5 lines · Felipe Balbi
Hi,
Maxim Devaev <[email protected]> writes:
Quoted 8 lines
Quoted 4 lines
SET_IDLEvalue must be shifted 8 bits to the right to get duration. This confirmed by USBCV test.Signed-off-by Maxim Devaev <[email protected]>with Greg's Fixes addition:
Acked-by Felipe Balbi <[email protected]>
Argh, just missed me committing this. Thanks for the review, sorry it missed getting added to the final commit :(
greg k-h
Quoted 9 lines · Greg KH
Quoted 8 lines · Felipe Balbi
Hi,
Quoted 3 lines · Maxim Devaev
SET_IDLEvalue must be shifted 8 bits to the right to get duration. This confirmed by USBCV test.
Quoted 8 lines
Quoted 5 lines
Quoted 1 line
Signed-off-by Maxim Devaev <[email protected]>with Greg's Fixes addition:
Acked-by Felipe Balbi <[email protected]>Argh, just missed me committing this. Thanks for the review, sorry it missed getting added to the final commit :(
not a problem, thanks for taking care of all these patches ;-)
Signature · 1 line
balbi
Quoted 3 lines
Greg KH <[email protected]> wrote:
Argh, just missed me committing this. Thanks for the review, sorry it missed getting added to the final commit :(
No, it's my fault, I messed up the process and everything went wrong. I will improve my interaction when working on the next patch.
Sorry again. Although I read the manual on working with kernel mailings, I forgot about some things. Github PRs and all such things stupefy me :)