Skip to contentSkip to conversation

package/softether: remove 'v' prefix from github-fetched packages

PATCH New Matt Weber 3 participants 3 messages Oct 27, 2019

lore
Share & tools
lore

Matt Weber

author
#0 lore raw

PATCH 1/1 package/softether: remove 'v' prefix from github-fetched packages

Fixes version parsing for release-monitoring.org support.

---
Thanks Heiko for the script that found this one!

---
 package/softether/softether.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
package/softether/softether.mk +2 -2
index 1a31abd4bd..b7c6738b9a 100644
@@ -4,8 +4,8 @@
 #
 ################################################################################
 
-SOFTETHER_VERSION = v4.28-9669-beta
-SOFTETHER_SITE = $(call github,SoftEtherVPN,SoftEtherVPN_stable,$(SOFTETHER_VERSION))
+SOFTETHER_VERSION = 4.28-9669-beta
+SOFTETHER_SITE = $(call github,SoftEtherVPN,SoftEtherVPN_stable,v$(SOFTETHER_VERSION))
 SOFTETHER_LICENSE = GPL-2.0
 SOFTETHER_LICENSE_FILES = LICENSE
 SOFTETHER_DEPENDENCIES = host-pkgconf host-softether libopenssl readline
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/1 package/softether: remove 'v' prefix from github-fetched packages

utils/test-pkg -k -p softether fails

ERROR: No hash found for pru-software-support-5.1.0.tar.gz
make: *** [package/pkg-generic.mk:146: /home/hthiery/br-test-pkg/br-arm-full/build/host-pru-software-support-5.1.0/.stamp_downloaded] Fehler 1

I think the problem is when <pkg>_SOURCE is not explicitly specified it will be generated with the $(VERSION) without the 'v' that does not match the filename in the hash file.

--

Heiko

________________________________
From: Matt Weber <[email protected]>
Sent: Sunday, October 27, 2019 7:39:29 AM
To: buildroot at buildroot.org
Cc: Matt Weber; Heiko Thiery
Subject: [PATCH] package/softether: remove 'v' prefix from github-fetched packages

Fixes version parsing for release-monitoring.org support.

---
Thanks Heiko for the script that found this one!

---
 package/softether/softether.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
package/softether/softether.mk +2 -2
index 1a31abd4bd..b7c6738b9a 100644
@@ -4,8 +4,8 @@
 #
 ################################################################################
 
-SOFTETHER_VERSION = v4.28-9669-beta
-SOFTETHER_SITE = $(call github,SoftEtherVPN,SoftEtherVPN_stable,$(SOFTETHER_VERSION))
+SOFTETHER_VERSION = 4.28-9669-beta
+SOFTETHER_SITE = $(call github,SoftEtherVPN,SoftEtherVPN_stable,v$(SOFTETHER_VERSION))
 SOFTETHER_LICENSE = GPL-2.0
 SOFTETHER_LICENSE_FILES = LICENSE
 SOFTETHER_DEPENDENCIES = host-pkgconf host-softether libopenssl readline

--
2.17.1

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20191027/b3f3a9e6/attachment.html>

#2 lore raw

PATCH 1/1 package/softether: remove 'v' prefix from github-fetched packages

Quoted 11 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Heiko" == Heiko Thiery <[email protected]> writes:

utils/test-pkg -k -p softether fails
ERROR: No hash found for pru-software-support-5.1.0.tar.gz
make: *** [package/pkg-generic.mk:146:
/home/hthiery/br-test-pkg/br-arm-full/build/host-pru-software-support-5.1.0/.stamp_downloaded] Fehler 1

I think the problem is when <pkg>_SOURCE is not explicitly specified it will be generated with the $(VERSION) without the 'v' that does not match the filename in the hash file.

Indeed. Matt, will you fix up the .hash files of all of these and resend? In the mean time I will mark these as changes requested.

Signature · 1 line
Bye, Peter Korsgaard