Skip to contentSkip to conversation

file: explicitly disable libseccomp support for host

PATCH New Peter Korsgaard 2 participants 3 messages Oct 8, 2018 – Oct 21, 2018

lore
Share & tools
lore

Peter Korsgaard

author
#0 lore raw

PATCH 1/1 file: explicitly disable libseccomp support for host

Fixes:
http://autobuild.buildroot.net/results/8a2/8a2ea2e4426416447705492237f526fc84b595d7/
http://autobuild.buildroot.net/results/a1f/a1f2369d31c2387efdec908877e0bcaa728b5aeb/

file-5.33 added optional seccomp support, but the filters did not cover all needed syscalls, leading to errors when the freshly built host-file is executed as part of the build on distributions with seccomp support (E.G. Arch Linux):

checking for seccomp_init in -lseccomp... yes ..
../src/file -C -m magic
make[3]: *** [Makefile:764: magic.mgc] Bad system call

This has been fixed in file-5.34, but it anyway makes sense to explicitly disable libseccomp support for consistency as we do not need it for the host build.

Signed-off-by Peter Korsgaard <[email protected]>
---
 package/file/file.mk | 1 +
 1 file changed, 1 insertion(+)
package/file/file.mk +1 -0
index 42131c4888..b5b12978bc 100644
@@ -12,6 +12,7 @@ FILE_CONF_ENV = ac_cv_prog_cc_c99='-std=gnu99'
 FILE_INSTALL_STAGING = YES
 FILE_LICENSE = BSD-2-Clause, BSD-4-Clause (one file), BSD-3-Clause (one file)
 FILE_LICENSE_FILES = COPYING src/mygetopt.h src/vasprintf.c
+HOST_FILE_CONF_OPTS = --disable-libseccomp
 
 ifeq ($(BR2_PACKAGE_LIBSECCOMP),y)
 FILE_CONF_OPTS += --enable-libseccomp
Signature · 1 line
2.11.0
Applied
#1 lore raw

PATCH 1/1 file: explicitly disable libseccomp support for host

Hello,

Quoted 14 lines · Peter Korsgaard

Fixes:
http://autobuild.buildroot.net/results/8a2/8a2ea2e4426416447705492237f526fc84b595d7/
http://autobuild.buildroot.net/results/a1f/a1f2369d31c2387efdec908877e0bcaa728b5aeb/

file-5.33 added optional seccomp support, but the filters did not cover all needed syscalls, leading to errors when the freshly built host-file is executed as part of the build on distributions with seccomp support (E.G. Arch Linux):

checking for seccomp_init in -lseccomp... yes ..
../src/file -C -m magic
make[3]: *** [Makefile:764: magic.mgc] Bad system call

Quoted 8 lines

This has been fixed in file-5.34, but it anyway makes sense to explicitly disable libseccomp support for consistency as we do not need it for the host build.

Signed-off-by Peter Korsgaard <[email protected]>
---
 package/file/file.mk | 1 +
 1 file changed, 1 insertion(+)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
author
#2 lore raw

PATCH 1/1 file: explicitly disable libseccomp support for host

In reply to Peter Korsgaard
Quoted 16 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Peter" == Peter Korsgaard <[email protected]> writes:

Fixes:
http://autobuild.buildroot.net/results/8a2/8a2ea2e4426416447705492237f526fc84b595d7/
http://autobuild.buildroot.net/results/a1f/a1f2369d31c2387efdec908877e0bcaa728b5aeb/

file-5.33 added optional seccomp support, but the filters did not cover all needed syscalls, leading to errors when the freshly built host-file is executed as part of the build on distributions with seccomp support (E.G. Arch Linux):

checking for seccomp_init in -lseccomp... yes ..
../src/file -C -m magic
make[3]: *** [Makefile:764: magic.mgc] Bad system call

Quoted 5 lines

This has been fixed in file-5.34, but it anyway makes sense to explicitly disable libseccomp support for consistency as we do not need it for the host build.

Signed-off-by Peter Korsgaard <[email protected]>

Committed to 2018.02.x and 2018.08.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard