Skip to contentSkip to conversation

webkitgtk: Allow building with BR2_PACKAGE_WEBKITGTK_MULTIMEDIA disabled

PATCH Superseded Adrian Perez de Castro 3 participants 4 messages Jul 29, 2017 – Sep 4, 2017

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Adrian Perez de Castro

author
#0 lore raw

PATCH 1/1 webkitgtk: Allow building with BR2_PACKAGE_WEBKITGTK_MULTIMEDIA disabled

Explicitly pass "-DENABLE_MEDIA_STREAM=OFF" to CMake, to workaround a missing feature dependency in the WebKitGTK+ build files.

Related upstream bug: https://bugs.webkit.org/show_bug.cgi?id=174940

Signed-off-by Adrian Perez de Castro <[email protected]>
---
 package/webkitgtk/webkitgtk.mk | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
package/webkitgtk/webkitgtk.mk +5 -1
index b200d23262..e30d07fc1d 100644
@@ -40,9 +40,13 @@ WEBKITGTK_CONF_OPTS += \
 	-DENABLE_WEB_AUDIO=ON
 WEBKITGTK_DEPENDENCIES += gstreamer1 gst1-libav gst1-plugins-base gst1-plugins-good
 else
+# ENABLE_MEDIA_STREAM has to be explicitly disabled because there is a missing
+# feature dependency in the WebKitGTK+ CMake files. This can be removed once
+# https://bugs.webkit.org/show_bug.cgi?id=174940 makes it into a release.
 WEBKITGTK_CONF_OPTS += \
 	-DENABLE_VIDEO=OFF \
-	-DENABLE_WEB_AUDIO=OFF
+	-DENABLE_WEB_AUDIO=OFF \
+	-DENABLE_MEDIA_STREAM=OFF
 endif
 
 # Only one target platform can be built, assume X11 > Wayland
Signature · 1 line
2.13.3
Applied
#1 lore raw

PATCH 1/1 webkitgtk: Allow building with BR2_PACKAGE_WEBKITGTK_MULTIMEDIA disabled

Hello,

Quoted 9 lines · Adrian Perez de Castro

Explicitly pass "-DENABLE_MEDIA_STREAM=OFF" to CMake, to workaround a missing feature dependency in the WebKitGTK+ build files.

Related upstream bug: https://bugs.webkit.org/show_bug.cgi?id=174940

Signed-off-by Adrian Perez de Castro <[email protected]>
---
 package/webkitgtk/webkitgtk.mk | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
author
#2 lore raw

PATCH 1/1 webkitgtk: Allow building with BR2_PACKAGE_WEBKITGTK_MULTIMEDIA disabled

Quoted 6 lines · Thomas Petazzoni

Hello,

Quoted 3 lines · Adrian Perez de Castro

Explicitly pass "-DENABLE_MEDIA_STREAM=OFF" to CMake, to workaround a missing feature dependency in the WebKitGTK+ build files.

Quoted 8 lines
Quoted 6 lines

Related upstream bug: https://bugs.webkit.org/show_bug.cgi?id=174940

Signed-off-by Adrian Perez de Castro <[email protected]>
---
 package/webkitgtk/webkitgtk.mk | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

Applied to master, thanks.

Ouch, I've just sent a v2 with an added patch. I'll send the patch addition as a separate patch so please ignore the v2 then.

Cheers,

--
Adri?n ?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20170729/88ee5824/attachment.asc>

#3 lore raw

PATCH 1/1 webkitgtk: Allow building with BR2_PACKAGE_WEBKITGTK_MULTIMEDIA disabled

In reply to Adrian Perez de Castro
Quoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Adrian" == Adrian Perez de Castro <[email protected]> writes:

Explicitly pass "-DENABLE_MEDIA_STREAM=OFF" to CMake, to workaround a missing feature dependency in the WebKitGTK+ build files.

Related upstream bug: https://bugs.webkit.org/show_bug.cgi?id=174940

Signed-off-by Adrian Perez de Castro <[email protected]>

Committed to 2017.02.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard