i915: correctly handling failed allocation
Subsystems (2)
PATCH 1/1 i915: correctly handling failed allocation
--- drivers/gpu/drm/i915/intel_dsi_panel_vbt.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/gpu/drm/i915/intel_dsi_panel_vbt.c +2 -0
@@ -666,6 +666,8 @@ struct drm_panel *vbt_panel_init(struct intel_dsi *intel_dsi, u16 panel_id)/* This is cheating a bit with the cleanup. */ vbt_panel =devm_kzalloc (dev->dev,sizeof (*vbt_panel),GFP_KERNEL ); +if (!vbt_pannel) +return NULL ; vbt_panel->intel_dsi = intel_dsi;drm_panel_init (&vbt_panel->panel);
Signature · 1 line
1.9.1
kbuild test robot
build botreproduce:
Hi Insu,
[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on v4.4-rc7 next-20151223]
[if your patch is applied to the wrong git tree, please drop us a note to help improving the system]
url: https://github.com/0day-ci/linux/commits/Insu-Yun/i915-correctly-handling-failed-allocation/20151230-030043 base: git://anongit.freedesktop.org/drm-intel for-linux-next config: x86_64-randconfig-x008-12291635 (attached as .config) reproduce: # save the attached .config to linux build tree make ARCH=x86_64
All errors (new ones prefixed by >>):
drivers/gpu/drm/i915/intel_dsi_panel_vbt.c: In function 'vbt_panel_init':
>> drivers/gpu/drm/i915/intel_dsi_panel_vbt.c:669:7: error: 'vbt_pannel' undeclared (first use in this function)
if (!vbt_pannel)
^ drivers/gpu/drm/i915/intel_dsi_panel_vbt.c:669:7: note: each undeclared identifier is reported only once for each function it appears in
vim +/vbt_pannel +669 drivers/gpu/drm/i915/intel_dsi_panel_vbt.c
663 intel_dsi->panel_on_delay = pps->panel_on_delay / 10;
664 intel_dsi->panel_off_delay = pps->panel_off_delay / 10;
665 intel_dsi->panel_pwr_cycle_delay = pps->panel_power_cycle_delay / 10;
666
667 /* This is cheating a bit with the cleanup. */
668 vbt_panel = devm_kzalloc(dev->dev, sizeof(*vbt_panel), GFP_KERNEL);
> 669 if (!vbt_pannel)
670 return NULL;
671
672 vbt_panel->intel_dsi = intel_dsi;
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel
Jani Nikula
maintainerQuoted 10 lines · Insu Yun
Signed-off-by Insu Yun <[email protected]>--- drivers/gpu/drm/i915/intel_dsi_panel_vbt.c | 2 ++ 1 file changed, 2 insertions(+)drivers/gpu/drm/i915/intel_dsi_panel_vbt.c +0
-0
drivers/gpu/drm/i915/intel_dsi_panel_vbt.c struct drm_panel *vbt_panel_init(struct intel_dsi *intel_dsi, u16 panel_id) · line 670
Quoted 5 lines
drivers/gpu/drm/i915/intel_dsi_panel_vbt.c +2
-0@@ -666,6 +666,8 @@ struct drm_panel *vbt_panel_init(struct intel_dsi *intel_dsi, u16 panel_id)/* This is cheating a bit with the cleanup. */ vbt_panel =devm_kzalloc (dev->dev,sizeof (*vbt_panel),GFP_KERNEL ); +if (!vbt_pannel) +return NULL ;
We have build bots and CI, but the least you must do is build the code you change before submitting patches.
BR,
Jani.
Quoted 3 lines
drivers/gpu/drm/i915/intel_dsi_panel_vbt.c +0
-0vbt_panel->intel_dsi = intel_dsi;drm_panel_init (&vbt_panel->panel);
Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 6 lines · Jani Nikula
Quoted 5 lines · Insu Yun
Signed-off-by Insu Yun <[email protected]>--- drivers/gpu/drm/i915/intel_dsi_panel_vbt.c | 2 ++ 1 file changed, 2 insertions(+)
Quoted 13 lines
Review
Quoted 1 line
(quoted diff) +0
-0
b/drivers/gpu/drm/i915/intel_dsi_panel_vbt.cdrivers/gpu/drm/i915/intel_dsi_panel_vbt.c struct drm_panel *vbt_panel_init(struct intel_dsi
Quoted 4 lines
index a5e99ac..4e279dd 100644
drivers/gpu/drm/i915/intel_dsi_panel_vbt.c +0
-0@@ -666,6 +666,8 @@ struct drm_panel *vbt_panel_init(struct intel_dsi
*intel_dsi, u16panel_id)Quoted 5 lines
drivers/gpu/drm/i915/intel_dsi_panel_vbt.c +2
-0/* This is cheating a bit with the cleanup. */ vbt_panel =devm_kzalloc (dev->dev,sizeof (*vbt_panel),GFP_KERNEL ); +if (!vbt_pannel) +return NULL ;
Oh sorry. There was a type.
Quoted 4 lines
We have build bots and CI, but the least you must do is build the code you change before submitting patches.
Yes. Sorry.
Quoted 12 lines
BR,
Jani.drivers/gpu/drm/i915/intel_dsi_panel_vbt.c struct drm_panel *vbt_panel_init(struct intel_dsi *intel_dsi, u16 panel_id) · line 673
Quoted 3 lines
drivers/gpu/drm/i915/intel_dsi_panel_vbt.c +0
-0vbt_panel->intel_dsi = intel_dsi;drm_panel_init (&vbt_panel->panel);--
Jani Nikula, Intel Open Source Technology Center
Signature · 2 lines
Regards Insu Yun
_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel