Skip to contentSkip to conversation

python3: fix invalid ncursesw header path

PATCH New Thomas Petazzoni 3 participants 3 messages Feb 8, 2015 – Feb 12, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 python3: fix invalid ncursesw header path

This commit adds a patch to python3 that makes sure it does not use an invalid header path (pointing to host headers) when including ncursesw support.

Fixes:

http://autobuild.buildroot.org/results/9bd/9bdaa392e8dd00c6ebee156b758e3c0cac480237/

---
 .../018-ncursesw-remove-wrong-includedir.patch      | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
 create mode 100644 package/python3/018-ncursesw-remove-wrong-includedir.patch
package/python3/018-ncursesw-remove-wrong-includedir.patch new file +21 -0
new file mode 100644
index 0000000..ae87bbf
@@ -0,0 +1,21 @@
+Do not harcode invalid path to ncursesw headers
+
+Adding /usr/include/ncursesw is obviously invalid when
+cross-compiling. Since the ncursesw headers are no longer installed in
+usr/include/ncursesw/, but directly in usr/include, there is anyway no
+need for a special header path.
+
+Signed-off-by: Thomas Petazzoni <[email protected]>
+
+Index: b/setup.py
+===================================================================
+--- a/setup.py
++++ b/setup.py
+@@ -1287,7 +1287,6 @@
+         panel_library = 'panel'
+         if curses_library == 'ncursesw':
+             curses_defines.append(('HAVE_NCURSESW', '1'))
+-            curses_includes.append('/usr/include/ncursesw')
+             # Bug 1464056: If _curses.so links with ncursesw,
+             # _curses_panel.so must link with panelw.
+             panel_library = 'panelw'
Signature · 1 line
2.1.0
#1 lore raw

PATCH 1/1 python3: fix invalid ncursesw header path

Hi Thomas,

Le 08/02/2015 22:23, Thomas Petazzoni a ?crit :

Quoted 10 lines

This commit adds a patch to python3 that makes sure it does not use an invalid header path (pointing to host headers) when including ncursesw support.

Fixes:

http://autobuild.buildroot.org/results/9bd/9bdaa392e8dd00c6ebee156b758e3c0cac480237/

---

I reproduced the build issue which is indeed fixed by your patch. Just build tested though.

Best regards,
Romain

Quoted 32 lines
 .../018-ncursesw-remove-wrong-includedir.patch      | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
 create mode 100644 package/python3/018-ncursesw-remove-wrong-includedir.patch
package/python3/018-ncursesw-remove-wrong-includedir.patch new file +21 -0
new file mode 100644
index 0000000..ae87bbf
@@ -0,0 +1,21 @@
+Do not harcode invalid path to ncursesw headers
+
+Adding /usr/include/ncursesw is obviously invalid when
+cross-compiling. Since the ncursesw headers are no longer installed in
+usr/include/ncursesw/, but directly in usr/include, there is anyway no
+need for a special header path.
+
+Signed-off-by: Thomas Petazzoni <[email protected]>
+
+Index: b/setup.py
+===================================================================
+--- a/setup.py
++++ b/setup.py
+@@ -1287,7 +1287,6 @@
+         panel_library = 'panel'
+         if curses_library == 'ncursesw':
+             curses_defines.append(('HAVE_NCURSESW', '1'))
+-            curses_includes.append('/usr/include/ncursesw')
+             # Bug 1464056: If _curses.so links with ncursesw,
+             # _curses_panel.so must link with panelw.
+             panel_library = 'panelw'
#2 lore raw

PATCH 1/1 python3: fix invalid ncursesw header path

In reply to Thomas Petazzoni
Quoted 11 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

This commit adds a patch to python3 that makes sure it does not use an invalid header path (pointing to host headers) when including ncursesw support.

Fixes:

http://autobuild.buildroot.org/results/9bd/9bdaa392e8dd00c6ebee156b758e3c0cac480237/

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard