Skip to contentSkip to conversation

protobuf: limit to supported architectures

PATCH New Arnout Vandecappelle (Essensium/Mind) 2 participants 2 messages May 10, 2014 – May 11, 2014

lore
Share & tools
lore

Arnout Vandecappelle (Essensium/Mind)

author
#0 lore raw

PATCH 1/1 protobuf: limit to supported architectures

protobuf 2.5.0 adds an atomic operations implementation that is limited to a few architectures only. mips64el and armeb don't work either.

Fixes (among others)
http://autobuild.buildroot.net/results/ae9fa612d0b6c9d593504206d5cedd480ad2547e/

Signed-off-by Arnout Vandecappelle (Essensium/Mind) <[email protected]>
---
 package/ola/Config.in      | 2 ++
 package/protobuf/Config.in | 4 ++++
 2 files changed, 6 insertions(+)
package/ola/Config.in +2 -0
index eb24a3a..8d202a5 100644
@@ -1,5 +1,6 @@
 comment "ola needs a toolchain w/ C++, threads, largefile, wchar"
 	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_LARGEFILE || !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
+	depends on BR2_arm || BR2_i386 || BR2_mipsel || BR2_x86_64
 
 config BR2_PACKAGE_OLA
 	bool "ola (open lighting architecture)"

@@ -10,6 +11,7 @@ config BR2_PACKAGE_OLA
 	depends on BR2_LARGEFILE # util-linux
 	depends on BR2_USE_WCHAR # util-linux
 	depends on BR2_TOOLCHAIN_HAS_THREADS
+	depends on BR2_arm || BR2_i386 || BR2_mipsel || BR2_x86_64 # protobuf
 	help
 	  Open Lighting Architecture provides applications
 	  with a mechanism to send and receive DMX512 & RDM
package/protobuf/Config.in +4 -0
index a4f542e..293a9b9 100644
@@ -2,6 +2,9 @@ config BR2_PACKAGE_PROTOBUF
 	bool "protobuf"
 	depends on BR2_INSTALL_LIBSTDCPP
 	depends on BR2_TOOLCHAIN_HAS_THREADS
+	# See src/google/protobuf/stubs/platform_macros.h for supported archs.
+	# PowerPC doesn't actually work.
+	depends on BR2_arm || BR2_i386 || BR2_mipsel || BR2_x86_64
 	help
 	  Protocol buffers are Google's language-neutral, platform-neutral,
 	  extensible mechanism for serializing structured data.

@@ -10,3 +13,4 @@ config BR2_PACKAGE_PROTOBUF
 
 comment "protobuf needs a toolchain w/ C++, threads"
 	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS
+	depends on BR2_arm || BR2_i386 || BR2_mipsel || BR2_x86_64
Signature · 1 line
2.0.0.rc2
#1 lore raw

PATCH 1/1 protobuf: limit to supported architectures

Quoted 9 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Arnout" == Arnout Vandecappelle (Essensium/Mind) <[email protected]> writes:

protobuf 2.5.0 adds an atomic operations implementation that is limited to a few architectures only. mips64el and armeb don't work either.

Fixes (among others)
http://autobuild.buildroot.net/results/ae9fa612d0b6c9d593504206d5cedd480ad2547e/

Signed-off-by Arnout Vandecappelle (Essensium/Mind) <[email protected]>

I think this is safer than Baruch's version for 2014.05 - Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard