Add gpm (general purpose mouse) server package
PATCH v4 1/1 Add gpm (general purpose mouse) server package
From: Julien Boibessot <[email protected]>
---
Changes since v3:
- As recommended by Thomas:
* cleanup Config.in menu entries
Changes since v2:
- As recommended by Yann:
* spell check
* use BR autoconf/make/libtool but in SDL package way
* put optionnal GPM_REMOVE_TEST_TOOLS_FROM_TARGET into ifeq
Changes since v1:
- 80x # in gpm.mk banner
- As recommended by Romain:
* remove possible circular dependency with ncurses
* don't allow package selection when BR2_PREFER_STATIC_LIB=y
* fixes headers path when gpm wants to build its dependencies rules
package/Config.in | 1 + package/gpm/Config.in | 24 ++++++++++++++++++++++ package/gpm/gpm.mk | 52 +++++++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 77 insertions(+), 0 deletions(-) create mode 100644 package/gpm/Config.in create mode 100644 package/gpm/gpm.mk
package/Config.in +1 -0
@@ -290,6 +290,7 @@ source "package/fmtools/Config.in" source "package/freescale-imx/Config.in" source "package/fxload/Config.in" source "package/gadgetfs-test/Config.in" +source "package/gpm/Config.in" source "package/gpsd/Config.in" source "package/gptfdisk/Config.in" source "package/gvfs/Config.in"
package/gpm/Config.in new file +24 -0
@@ -0,0 +1,24 @@ +config BR2_PACKAGE_GPM + bool "gpm" + depends on !BR2_PREFER_STATIC_LIB + help + "gpm" means general purpose mouse (server) and provides mouse support + for Linux virtual consoles. + gpm-root (to draw menus in current virtual console; config file in + /etc/gpm-root.conf) and disable-paste (to disable paste buffer for + security reasons), will also be installed. + + http://www.nico.schottelius.org/software/gpm/ + +if BR2_PACKAGE_GPM + +config BR2_PACKAGE_GPM_INSTALL_TEST_TOOLS + bool "install test tools" + help + Install gpm test tools (get-versions, mev, hltest, mouse-test, + display-buttons & display-coords). + +endif + +comment "gpm mouse server needs a toolchain w/ dynamic library" + depends on BR2_PREFER_STATIC_LIB
package/gpm/gpm.mk new file +52 -0
52 lines not on this page · raw message
Signature · 1 line
1.7.5.4
PATCH v4 1/1 Add gpm (general purpose mouse) server package
Julien, All,
On 2014-01-29 19:20 +0100, julien.boibessot at free.fr spake thusly:
package/gpm/gpm.mk
Quoted 7 lines
From: Julien Boibessot <[email protected]>
package/gpm/gpm.mk new file +0
-0@@ -0,0 +1,52 @@
[--SNIP--]
package/gpm/gpm.mk line 33
Quoted 8 lines
package/gpm/gpm.mk new file +8
-0+# configure is missing but gpm seems not compatible with our autoreconf +# mechanism so we have to do it manually instead of using GPM_AUTORECONF = YES +define GPM_RUN_AUTOGEN + cd $(@D) && PATH=$(HOST_PATH) ./autogen.sh +endef + +GPM_POST_PATCH_HOOKS += GPM_RUN_AUTOGEN +GPM_DEPENDENCIES += host-automake host-autoconf host-libtool
Nitpick: I prefer we "coalesce" the *_HOOKS lines directly below the define, and add an empty line _fater_ the *_HOOKS (not before liek you did), like:
define GPM_RUN_AUTOGEN
cd $(@D) && PATH=$(HOST_PATH) ./autogen.sh
endef
GPM_POST_PATCH_HOOKS += GPM_RUN_AUTOGEN
GPM_DEPENDENCIES += host-automake host-autoconf host-libtoolIt looks more natural to me, otherwise one has to train his eyes to spot the _HOOKS line.
Besides, in your case, the _HOOKS line is directly tied to another assignment, which makes it look like they belong to the same 'semantic' block, so the brain (mine, at least!) automatically skips over it, desparately looking for the _HOOKS line later in the file... Yes, I'm a bizare guy, but yet... ;-)
package/gpm/gpm.mk line 42
Quoted 8 lines
package/gpm/gpm.mk new file +8
-0+ifeq ($(BR2_PACKAGE_GPM_INSTALL_TEST_TOOLS),) +define GPM_REMOVE_TEST_TOOLS_FROM_TARGET + for tools in mev hltest mouse-test display-buttons \ + get-versions display-coords; do \ + rm -f $(TARGET_DIR)/usr/bin/$$tools ; \ + done +endef +
Ditto, remove this empty line
package/gpm/gpm.mk line 49
Quoted 7 lines
package/gpm/gpm.mk new file +7
-0+GPM_POST_INSTALL_TARGET_HOOKS += GPM_REMOVE_TEST_TOOLS_FROM_TARGET +endif + +define GPM_INSTALL_GPM_ROOT_CONF_ON_TARGET + $(INSTALL) -m 0644 -D $(@D)/conf/gpm-root.conf $(TARGET_DIR)/etc/ +endef +
Ditto again.
package/gpm/gpm.mk line 52
Quoted 3 lines
package/gpm/gpm.mk new file +3
-0+GPM_POST_INSTALL_TARGET_HOOKS += GPM_INSTALL_GPM_ROOT_CONF_ON_TARGET + +$(eval $(autotools-package))
Anyway, if Peter likes it that way, I won't object much! ;-) So:
Reviewed-by: "Yann E. MORIN" <[email protected]>
Regards,
Yann E. MORIN.
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH v4 1/1 Add gpm (general purpose mouse) server package
In reply to julien.boibessot at free.frQuoted 9 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"julien" == julien boibessot <[email protected]> writes:
From: Julien Boibessot <[email protected]>
Signed-off-by Julien Boibessot <[email protected]>Signed-off-by Romain Naour <[email protected]>---
Changes since v3:
- As recommended by Thomas:
* cleanup Config.in menu entries
Committed with the minor whitespace fixes pointed out by Yann, thanks!
Signature · 1 line
Bye, Peter Korsgaard