Skip to contentSkip to conversation

log4cxx: needs threads

PATCH New spdawson at gmail.com 2 participants 2 messages Nov 11, 2013

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 log4cxx: needs threads

From: Simon Dawson <[email protected]>

Fixes build failures such as the following.

http://autobuild.buildroot.net/results/7b73901d9e8b5098cd96b54d292bb3ffffb3fe37/

---
v2: At the suggestion of Thomas De Schampheleire, update the comment to explain that dynamic library support is required

 package/log4cxx/Config.in | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
package/log4cxx/Config.in +4 -2
index 86d6a1d..8791b8c 100644
@@ -5,11 +5,13 @@ config BR2_PACKAGE_LOG4CXX
 	# apr really needs shared library support
 	depends on !BR2_PREFER_STATIC_LIB
 	depends on BR2_INSTALL_LIBSTDCPP
+	depends on BR2_TOOLCHAIN_HAS_THREADS
 	help
 	  Apache log4cxx is a logging framework for C++ patterned
 	  after Apache log4j.
 
 	  http://apache.linux-mirror.org/logging/log4cxx/0.10.0
 
-comment "log4cxx needs a toolchain w/ C++"
-	depends on !BR2_INSTALL_LIBSTDCPP
+comment "log4cxx needs a toolchain w/ C++, threads, dynamic library"
+	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS || \
+		BR2_PREFER_STATIC_LIB
Signature · 1 line
1.8.3.2
#1 lore raw

PATCH v2 1/1 log4cxx: needs threads

Quoted 11 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"spdawson" == spdawson <[email protected]> writes:

From: Simon Dawson <[email protected]>
Fixes build failures such as the following.

http://autobuild.buildroot.net/results/7b73901d9e8b5098cd96b54d292bb3ffffb3fe37/

---
v2: At the suggestion of Thomas De Schampheleire, update the comment to explain that dynamic library support is required

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard