arm: kirkwood: readynas duo v2: Add GMT G762 Fan Controller DT bindings
PATCH 1/1 arm: kirkwood: readynas duo v2: Add GMT G762 Fan Controller DT bindings
Now that GMT G762 PWM Fan Controller is available upstream, let's add missing bindings in Netgear ReadyNAS Duo v2 .dts file. Let's also take the opportunity to fix space issues at the end of the file.
---
Hi Jason and Andrew,
This one applies and has been tested against Stephen Rothwell tree. Can you make it flow to Linus tree during the merge window? Thanks in advance.
Cheers,
a+
.../boot/dts/kirkwood-netgear_readynas_duo_v2.dts | 54 +++++++++++++++------- 1 file changed, 37 insertions(+), 17 deletions(-)
arch/arm/boot/dts/kirkwood-netgear_readynas_duo_v2.dts +37 -17
@@ -52,6 +52,17 @@ }; }; + clocks { + #address-cells = <1>; + #size-cells = <0>; + + g762_clk: fixedclk { + compatible = "fixed-clock"; + #clock-cells = <0>; + clock-frequency = <8192>; + }; + }; + i2c at 11000 { status = "okay";
@@ -59,6 +70,15 @@ compatible = "ricoh,rs5c372a"; reg = <0x32>; }; + + g762: g762 at 3e { + compatible = "gmt,g762"; + reg = <0x3e>; + clocks = <&g762_clk>; /* input clock */ + fan_gear_mode = <0>; + fan_startv = <1>; + pwm_polarity = <0>; + }; }; serial at 12000 {
@@ -166,21 +186,21 @@ }; }; - regulators { - compatible = "simple-bus"; - #address-cells = <1>; - #size-cells = <0>; - - usb_power: regulator at 1 { - compatible = "regulator-fixed"; - reg = <1>; - regulator-name = "USB 3.0 Power"; - regulator-min-microvolt = <5000000>; - regulator-max-microvolt = <5000000>; - enable-active-high; - regulator-always-on; - regulator-boot-on; - gpio = <&gpio1 14 0>; - }; - }; + regulators { + compatible = "simple-bus"; + #address-cells = <1>; + #size-cells = <0>; + + usb_power: regulator at 1 { + compatible = "regulator-fixed"; + reg = <1>; + regulator-name = "USB 3.0 Power"; + regulator-min-microvolt = <5000000>; + regulator-max-microvolt = <5000000>; + enable-active-high; + regulator-always-on; + regulator-boot-on; + gpio = <&gpio1 14 0>; + }; + }; };
Signature · 1 line
1.8.3.1
PATCH 1/1 arm: kirkwood: readynas duo v2: Add GMT G762 Fan Controller DT bindings
Dear Arnaud Ebalard,
Quoted 25 lines · Arnaud Ebalard
arch/arm/boot/dts/kirkwood-netgear_readynas_duo_v2.dts +8
-17- regulators { - compatible = "simple-bus"; - #address-cells = <1>; - #size-cells = <0>; - - usb_power: regulator at 1 { - compatible = "regulator-fixed"; - reg = <1>; - regulator-name = "USB 3.0 Power"; - regulator-min-microvolt = <5000000>; - regulator-max-microvolt = <5000000>; - enable-active-high; - regulator-always-on; - regulator-boot-on; - gpio = <&gpio1 14 0>; - }; - }; + regulators { + compatible = "simple-bus"; + #address-cells = <1>; + #size-cells = <0>; + + usb_power: regulator at 1 { + compatible = "regulator-fixed"; + reg = <1>;
arch/arm/boot/dts/kirkwood-netgear_readynas_duo_v2.dts line 206
Quoted 10 lines
arch/arm/boot/dts/kirkwood-netgear_readynas_duo_v2.dts +9
-0+ regulator-name = "USB 3.0 Power"; + regulator-min-microvolt = <5000000>; + regulator-max-microvolt = <5000000>; + enable-active-high; + regulator-always-on; + regulator-boot-on; + gpio = <&gpio1 14 0>; + }; + }; };
Those white-space changes are not related to the addition of the G762 Device Tree informations.
Thanks,
Thomas
Signature · 4 lines
Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com
PATCH 1/1 arm: kirkwood: readynas duo v2: Add GMT G762 Fan Controller DT bindings
Hi Thomas,
Quoted 32 lines · Thomas Petazzoni
Quoted 30 lines · Arnaud Ebalard
arch/arm/boot/dts/kirkwood-netgear_readynas_duo_v2.dts +13
-17- regulators { - compatible = "simple-bus"; - #address-cells = <1>; - #size-cells = <0>; - - usb_power: regulator at 1 { - compatible = "regulator-fixed"; - reg = <1>; - regulator-name = "USB 3.0 Power"; - regulator-min-microvolt = <5000000>; - regulator-max-microvolt = <5000000>; - enable-active-high; - regulator-always-on; - regulator-boot-on; - gpio = <&gpio1 14 0>; - }; - }; + regulators { + compatible = "simple-bus"; + #address-cells = <1>; + #size-cells = <0>; + + usb_power: regulator at 1 { + compatible = "regulator-fixed"; + reg = <1>; + regulator-name = "USB 3.0 Power"; + regulator-min-microvolt = <5000000>; + regulator-max-microvolt = <5000000>; + enable-active-high; + regulator-always-on;
Quoted 8 lines
arch/arm/boot/dts/kirkwood-netgear_readynas_duo_v2.dts line 206
Quoted 5 lines
arch/arm/boot/dts/kirkwood-netgear_readynas_duo_v2.dts +4
-0+ regulator-boot-on; + gpio = <&gpio1 14 0>; + }; + }; };Those white-space changes are not related to the addition of the G762 Device Tree informations.
Should I make two unrelated patches (one for G762 and another cosmetic one) or simply let the spaces as they are in .dts?
Cheers,
a+
PATCH 1/1 arm: kirkwood: readynas duo v2: Add GMT G762 Fan Controller DT bindings
Quoted 45 lines · Arnaud Ebalard
Hi Thomas,
Quoted 32 lines · Thomas Petazzoni
Quoted 30 lines · Arnaud Ebalard
arch/arm/boot/dts/kirkwood-netgear_readynas_duo_v2.dts +13
-17- regulators { - compatible = "simple-bus"; - #address-cells = <1>; - #size-cells = <0>; - - usb_power: regulator at 1 { - compatible = "regulator-fixed"; - reg = <1>; - regulator-name = "USB 3.0 Power"; - regulator-min-microvolt = <5000000>; - regulator-max-microvolt = <5000000>; - enable-active-high; - regulator-always-on; - regulator-boot-on; - gpio = <&gpio1 14 0>; - }; - }; + regulators { + compatible = "simple-bus"; + #address-cells = <1>; + #size-cells = <0>; + + usb_power: regulator at 1 { + compatible = "regulator-fixed"; + reg = <1>; + regulator-name = "USB 3.0 Power"; + regulator-min-microvolt = <5000000>; + regulator-max-microvolt = <5000000>; + enable-active-high; + regulator-always-on;Quoted 8 lines
arch/arm/boot/dts/kirkwood-netgear_readynas_duo_v2.dts line 206
Quoted 5 lines
arch/arm/boot/dts/kirkwood-netgear_readynas_duo_v2.dts +4
-0+ regulator-boot-on; + gpio = <&gpio1 14 0>; + }; + }; };Those white-space changes are not related to the addition of the G762 Device Tree informations.
Quoted 2 lines
Should I make two unrelated patches (one for G762 and another cosmetic one) or simply let the spaces as they are in .dts?
Leave them as they are. I'm intending to do a cleanup series for all the whitespace issues in the dts files.
thx,
Jason.