wvstreams: fix build failures
PATCH 1/2 wvstreams: fix build failures
Add a patch to fix wvstreams build failures such as
http://autobuild.buildroot.org/results/8cb2904113a5e63d6170c085f77a8040d50a0138/build-end.log.
Signed-off-by Thomas Petazzoni <[email protected]>
--- package/wvstreams/wvstreams-0004-build-fixes.patch | 40 ++++++++++++++++++++ 1 file changed, 40 insertions(+) create mode 100644 package/wvstreams/wvstreams-0004-build-fixes.patch
package/wvstreams/wvstreams-0004-build-fixes.patch new file +40 -0
@@ -0,0 +1,40 @@ +Add missing includes for proper build on Linux/glibc + +The current wvstreams code doesn't build on Linux/glibc, with error +about chmod() not being available (for wvunixdgsocket.cc) or umask() +not being available (for wvatomicfile.cc). Those errors turn out to be +missing includes. Those includes were in fact already done, but +conditionally for MacOS. We make them unconditional (it probably +breaks other platforms, but since Buildroot is Linux only, we don't +care). + +Signed-off-by: Thomas Petazzoni <[email protected]> + +Index: b/ipstreams/wvunixdgsocket.cc +=================================================================== +--- a/ipstreams/wvunixdgsocket.cc ++++ b/ipstreams/wvunixdgsocket.cc +@@ -1,8 +1,6 @@ + #include "wvunixdgsocket.h" +-#ifdef MACOS + #include <sys/types.h> + #include <sys/stat.h> +-#endif + + WvUnixDGSocket::WvUnixDGSocket(WvStringParm filename, bool _server, int perms) + : socketfile(filename) +Index: b/streams/wvatomicfile.cc +=================================================================== +--- a/streams/wvatomicfile.cc ++++ b/streams/wvatomicfile.cc +@@ -10,10 +10,7 @@ + #include "wvatomicfile.h" + #include "wvfileutils.h" + #include "wvstrutils.h" +- +-#ifdef MACOS + #include <sys/stat.h> +-#endif + + WvAtomicFile::WvAtomicFile(WvStringParm filename, int flags, mode_t create_mode) + : tmp_file(WvString::null)
Signature · 1 line
1.7.9.5
PATCH 2/2 wvstreams: disable warnings
During the compilation of wvstreams, a number of strict aliasing related warnings are shown, making the build quite noisy. Turn warnings off using the --disable-warnings option.
Signed-off-by Thomas Petazzoni <[email protected]>
--- package/wvstreams/wvstreams.mk | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
package/wvstreams/wvstreams.mk +5 -1
@@ -18,7 +18,11 @@ WVSTREAMS_MAKE = $(MAKE1) # Needed to work around problem with wvassert.h WVSTREAMS_CONF_OPT += CPPFLAGS=-DNDEBUG -WVSTREAMS_CONF_OPT += --with-openssl --with-zlib --without-pam +WVSTREAMS_CONF_OPT += \ + --with-openssl \ + --with-zlib \ + --without-pam \ + --disable-warnings ifeq ($(BR2_PACKAGE_DBUS),y) WVSTREAMS_DEPENDENCIES += dbus
Signature · 1 line
1.7.9.5
PATCH 1/2 wvstreams: fix build failures
In reply to Thomas PetazzoniQuoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Thomas" == Thomas Petazzoni <[email protected]> writes:
Thomas> Add a patch to fix wvstreams build failures such as
Thomas> http://autobuild.buildroot.org/results/8cb2904113a5e63d6170c085f77a8040d50a0138/build-end.log.
Committed both, thanks.
Signature · 1 line
Bye, Peter Korsgaard