rtc: avoid checking cpuid in pxa-rtc
PATCH 1/2 rtc: avoid checking cpuid in pxa-rtc
pxa-rtc is widely used in pxa27x/pxa3xx/pxa93x/pxa95x. Checking cpuid in pxa-rtc driver is unnecessary since we assign on-chip device in soc files.
--- drivers/rtc/rtc-pxa.c | 5 +---- 1 files changed, 1 insertions(+), 4 deletions(-)
drivers/rtc/rtc-pxa.c +1 -4
@@ -477,10 +477,7 @@ static struct platform_driver pxa_rtc_driver = {static int __init pxa_rtc_init (void ) { -if (cpu_is_pxa27x () ||cpu_is_pxa3xx ()) -return platform_driver_probe (&pxa_rtc_driver, pxa_rtc_probe); - -return -ENODEV ; +return platform_driver_probe (&pxa_rtc_driver, pxa_rtc_probe); } static void __exit pxa_rtc_exit(void)
Signature · 1 line
1.5.6.5
PATCH 2/2 rtc: use __devinit instead on pxa-rtc
Avoid to use __init/__exit on probe()/remove(). Use __devinit/__devexit instead.
--- drivers/rtc/rtc-pxa.c | 9 +++++---- 1 files changed, 5 insertions(+), 4 deletions(-)
drivers/rtc/rtc-pxa.c +5 -4
@@ -352,7 +352,7 @@ static const struct rtc_class_ops pxa_rtc_ops = { .irq_set_freq = pxa_periodic_irq_set_freq, }; -static int __init pxa_rtc_probe (struct platform_device *pdev) +static int __devinit pxa_rtc_probe (struct platform_device *pdev) {struct device *dev = &pdev->dev;struct pxa_rtc *pxa_rtc;
@@ -425,7 +425,7 @@ err_map:return ret; } -static int __exit pxa_rtc_remove(struct platform_device *pdev) +static int __devexit pxa_rtc_remove(struct platform_device *pdev) {struct pxa_rtc *pxa_rtc =platform_get_drvdata (pdev);
@@ -466,7 +466,8 @@ static const struct dev_pm_ops pxa_rtc_pm_ops = {#endif static struct platform_driver pxa_rtc_driver = { - .remove =__exit_p (pxa_rtc_remove), + .probe = pxa_rtc_probe, + .remove =__devexit_p (pxa_rtc_remove), .driver = { .name ="pxa-rtc" , #ifdef CONFIG_PM
@@ -477,7 +478,7 @@ static struct platform_driver pxa_rtc_driver = {static int __init pxa_rtc_init (void ) { -return platform_driver_probe (&pxa_rtc_driver, pxa_rtc_probe); +return platform_driver_register (&pxa_rtc_driver); } static void __exit pxa_rtc_exit(void)
Signature · 1 line
1.5.6.5
PATCH 2/2 rtc: use __devinit instead on pxa-rtc
Quoted 7 lines · Haojian Zhuang
Avoid to use __init/__exit on probe()/remove(). Use __devinit/__devexit instead.
Signed-off-by Haojian Zhuang <[email protected]>Cc Eric Miao <[email protected]>Cc Robert Jarzmik <[email protected]>Cc Alessandro Zummo <[email protected]>
Cheers.
--
Robert
PATCH 1/2 rtc: avoid checking cpuid in pxa-rtc
In reply to Haojian ZhuangQuoted 2 lines · On Wed, 29 Sep 2010 18:02:14 +0800 Haojian Zhuang <[email protected]>…
pxa-rtc is widely used in pxa27x/pxa3xx/pxa93x/pxa95x. Checking cpuid in pxa-rtc driver is unnecessary since we assign on-chip device in soc files.
seems reasonable.
Signature · 6 lines
Best regards, Alessandro Zummo, Tower Technologies - Torino, Italy http://www.towertech.it
PATCH 1/2 rtc: avoid checking cpuid in pxa-rtc
In reply to Haojian ZhuangQuoted 7 lines · Haojian Zhuang
pxa-rtc is widely used in pxa27x/pxa3xx/pxa93x/pxa95x. Checking cpuid in pxa-rtc driver is unnecessary since we assign on-chip device in soc files.
Signed-off-by Haojian Zhuang <[email protected]>Cc Eric Miao <[email protected]>Cc Robert Jarzmik <[email protected]>Cc Alessandro Zummo <[email protected]>
--
Robert