Skip to contentSkip to conversation

dm9601: Fix multicast hash table handling

PATCH Applied Peter Korsgaard 2 participants 3 messages Mar 28, 2008 – Mar 29, 2008

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dm9601: Fix multicast hash table handling

The loop forgot to walk the net->mc_list list, so only the first multicast address was programmed into the hash table.
---
Jeff, I would like to get this patch in 2.6.25 if possible.

 drivers/net/usb/dm9601.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/usb/dm9601.c +1 -1
index 0343b00..01660f6 100644
@@ -354,7 +354,7 @@ static void dm9601_set_multicast(struct net_device *net)
 		struct dev_mc_list *mc_list = net->mc_list;
 		int i;
 
-		for (i = 0; i < net->mc_count; i++) {
+		for (i = 0; i < net->mc_count; i++, mc_list = mc_list->next) {
 			u32 crc = ether_crc(ETH_ALEN, mc_list->dmi_addr) >> 26;
 			hashes[crc >> 3] |= 1 << (crc & 0x7);
 		}
Signature · 5 lines
1.5.4.4


-- 
Bye, Peter Korsgaard
Applied
#1 lore raw
Quoted 4 lines · Peter Korsgaard

The loop forgot to walk the net->mc_list list, so only the first multicast address was programmed into the hash table.
---
Jeff, I would like to get this patch in 2.6.25 if possible.

applied, signed-off-by lines would help...

#2 lore raw
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Jeff" == Jeff Garzik <[email protected]> writes:

Quoted 4 lines · Jeff> Peter Korsgaard wrote:
Quoted 4 lines

The loop forgot to walk the net->mc_list list, so only the first multicast address was programmed into the hash table.
---
Jeff, I would like to get this patch in 2.6.25 if possible.

Jeff> applied, signed-off-by lines would help...

Thanks, and sorry about that, it seems that I forgot to add the -s option, that should teach me to not do any work before the morning coffee ..

Signature · 1 line
Bye, Peter Korsgaard