Skip to contentSkip to conversation

Fixes to tests

PATCH Applied Dan Smith 2 participants 2 messages Nov 7, 2005 – Nov 8, 2005

lore
Share & tools
lore

Dan Smith

author
#0 lore raw

PATCH 1/1 Fixes to tests

This patch fixes a few tests, in the following ways:

1. Unmark the 07 and 08 tests of block_attach as XFAIL
2. Change the MEM_PER_DOM amount in 11_create_concurrent to 24MB, so that the test will run on x86_64.
3. Increase the number of DomUs created in 12_create_concurrent to 5
4. Fix a logic error in 01_unpause
5. Add a test 06_help that checks all xm commands with 0-10 arguments to make sure none of them traceback with varying argument counts.

Signed-off-by Dan Smith <[email protected]>
tools/xm-test/tests/block-create/Makefile.am +0 -4
diff -r a05e55c919c1 tools/xm-test/tests/block-create/Makefile.am
@@ -11,10 +11,6 @@
 	09_block_attach_and_dettach_device_check_data_pos.test
 
 DISABLED = 
-
-XFAIL_TESTS = 07_block_attach_baddevice_neg.test \
-	08_block_attach_bad_filedevice_neg.test
-
 
 EXTRA_DIST = $(TESTS) $(XFAIL_TESTS)
tools/xm-test/tests/create/11_create_concurrent_pos.py +1 -1
diff -r a05e55c919c1 tools/xm-test/tests/create/11_create_concurrent_pos.py
@@ -10,7 +10,7 @@
 
 MIN_DOMS    = 10
 MAX_DOMS    = 50
-MEM_PER_DOM = 16
+MEM_PER_DOM = 24
 
 domains = []
 console = []
tools/xm-test/tests/create/12_create_concurrent_stress_pos.py +1 -1
diff -r a05e55c919c1 tools/xm-test/tests/create/12_create_concurrent_stress_pos.py
@@ -7,7 +7,7 @@
 
 import time
 
-DOMS=2
+DOMS=5
 MEM=32
 DUR=60
tools/xm-test/tests/help/Makefile.am +2 -1
diff -r a05e55c919c1 tools/xm-test/tests/help/Makefile.am
@@ -4,7 +4,8 @@
 	02_help_basic_neg.test \
 	03_help_badparm_neg.test \
 	04_help_long_pos.test \
-	05_help_nonroot_pos.test
+	05_help_nonroot_pos.test \
+	06_help_allcmds.test
 
 XFAIL_TESTS =
tools/xm-test/tests/list/06_list_nonroot.py +0 -1
diff -r a05e55c919c1 tools/xm-test/tests/list/06_list_nonroot.py
@@ -2,7 +2,6 @@
 
 # Copyright (C) International Business Machines Corp., 2005
 # Copyright (C) XenSource Ltd, 2005
-# Author: Woody Marvel <[email protected]>
 # Author: Ewan Mellor <[email protected]>
 
 from XmTestLib import *
tools/xm-test/tests/memset/Makefile.am +2 -2
diff -r a05e55c919c1 tools/xm-test/tests/memset/Makefile.am
@@ -2,8 +2,8 @@
 
 TESTS = 01_memset_basic_pos.test	\
         02_memset_badparm_neg.test 	\
-	04_memset_smallmem_pos.test     \
-	03_memset_random_pos.test
+	03_memset_random_pos.test	\
+	04_memset_smallmem_pos.test     	
 
 XFAIL_TESTS =
tools/xm-test/tests/unpause/01_unpause_basic_pos.py +3 -2
diff -r a05e55c919c1 tools/xm-test/tests/unpause/01_unpause_basic_pos.py
@@ -74,14 +74,15 @@
     FAIL(str(e))
 try:
     run = console.runCmd("ls")
-    #If we get here, console attached to paused domain (unexpected)
-    FAIL("console attached to supposedly paused domain")
 except ConsoleError, e:
     pass
 
 # Close the console
 console.closeConsole()
 
+if run["return"] != 0:
+    FAIL("console failed to attach to supposedly unpaused domain")
+
 # Stop the domain (nice shutdown)
 domain.stop()
tools/xm-test/tests/help/06_help_allcmds.py new file +44 -0

44 lines not on this page · raw message

Signature · 5 lines
-- 
Dan Smith
IBM Linux Technology Center
Open Hypervisor Team
email: [email protected]

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel

Applied
#1 lore raw
Quoted 11 lines · Dan Smith

This patch fixes a few tests, in the following ways:

1. Unmark the 07 and 08 tests of block_attach as XFAIL
2. Change the MEM_PER_DOM amount in 11_create_concurrent to 24MB, so that the test will run on x86_64.
3. Increase the number of DomUs created in 12_create_concurrent to 5
4. Fix a logic error in 01_unpause
5. Add a test 06_help that checks all xm commands with 0-10 arguments to make sure none of them traceback with varying argument counts.

Signed-off-by Dan Smith <[email protected]>

Applied, thanks.

Ewan.