Skip to contentSkip to conversation

irqchip/mbigen: add COMPILE_TEST support

PATCH Superseded Rosen Penev 2 participants 3 messages May 10 – May 13 irqchip drivers

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 irqchip/mbigen: add COMPILE_TEST support

Add description to bool to do so.

Remove ARM_GIC_V3 as the driver does not need it to compile.

Add GENERIC_MSI_IRQ since it's now needed as the ARM stuff went away.

Assisted-by Codex-GPT-5.5

---
v2: add GENERIC_MSI_IRQ

 drivers/irqchip/Kconfig | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/irqchip/Kconfig +3 -3
index eb8428d9fa61..e7d559472790 100644
@@ -208,9 +208,9 @@ config FARADAY_FTINTC010
 	select SPARSE_IRQ
 
 config HISILICON_IRQ_MBIGEN
-	bool
-	select ARM_GIC_V3
-	select ARM_GIC_V3_ITS
+	bool "HiSilicon MBIGEN interrupt controller"
+	depends on ARCH_HISI || COMPILE_TEST
+	select GENERIC_MSI_IRQ
 
 config IMGPDC_IRQ
 	bool
Signature · 1 line
2.54.0
maintainer
#1 lore raw
Quoted 3 lines · Rosen Penev

Add description to bool to do so.

Remove ARM_GIC_V3 as the driver does not need it to compile.

True, but you fail to explain that GIC_V3* is always selected for ARM64 builds.

Quoted 1 line

Add GENERIC_MSI_IRQ since it's now needed as the ARM stuff went away.

That's not a sensible explanation either. It's required for COMPILE_TEST builds because it's not longer selected by the removed ARM_GIC_V3_ITS.

Quoted 1 line
Assisted-by Codex-GPT-5.5

This thing clearly lacks any competence for writing comprehensible change logs.

What a waste of time and energy.

#2 lore raw
Quoted 8 lines · Thomas Gleixner
Quoted 3 lines · Rosen Penev

Add description to bool to do so.

Remove ARM_GIC_V3 as the driver does not need it to compile.

True, but you fail to explain that GIC_V3* is always selected for ARM64 builds.

OK.

Quoted 5 lines
Quoted 2 lines

Add GENERIC_MSI_IRQ since it's now needed as the ARM stuff went away.

That's not a sensible explanation either. It's required for COMPILE_TEST builds because it's not longer selected by the removed ARM_GIC_V3_ITS.

OK.

Quoted 5 lines
Quoted 2 lines
Assisted-by Codex-GPT-5.5

This thing clearly lacks any competence for writing comprehensible change logs.

User error. AGENTS.md needs tweaking locally. Speaking of which it would probably make sense to commit one here similar to .clang-format.

Quoted 2 lines

What a waste of time and energy.

Not my call. I've found it very useful to avoid having to resend multiple patches because of a boneheaded description.