drm/i915: fix application of sizeof to pointer
Subsystems (2)
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH 1/1 drm/i915: fix application of sizeof to pointer
The coccinelle check report:
./drivers/scsi/csiostor/csio_mb.c:1554:46-52: ERROR: application of sizeof to pointer
Signed-off-by Ran Sun <[email protected]>
--- drivers/gpu/drm/i915/i915_syncmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/i915_syncmap.c +1 -1
@@ -282,7 +282,7 @@ static noinline int __sync_set(struct i915_syncmap **root, u64 id, u32 seqno)unsigned int above;/* Insert a join above the current layer */ - next =kzalloc (sizeof (*next) +KSYNCMAP *sizeof (next), + next =kzalloc (sizeof (*next) +KSYNCMAP *sizeof (*next),GFP_KERNEL );if (unlikely (!next))return -ENOMEM ;
Jani Nikula
maintainerQuoted 3 lines · On Thu, 20 Jul 2023, [email protected] wrote:
The coccinelle check report:
./drivers/scsi/csiostor/csio_mb.c:1554:46-52: ERROR: application of sizeof to pointer
Please don't just assume coccinelle is right, and send "fixes" based on the cocci reports alone. You need to read and understand the code you're changing.
BR,
Jani.
Quoted 21 lines
Signed-off-by Ran Sun <[email protected]>--- drivers/gpu/drm/i915/i915_syncmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/i915/i915_syncmap.c +1
-1@@ -282,7 +282,7 @@ static noinline int __sync_set(struct i915_syncmap **root, u64 id, u32 seqno)unsigned int above;/* Insert a join above the current layer */ - next =kzalloc (sizeof (*next) +KSYNCMAP *sizeof (next), + next =kzalloc (sizeof (*next) +KSYNCMAP *sizeof (*next),GFP_KERNEL );if (unlikely (!next))return
-ENOMEM;
Signature · 1 line
Jani Nikula, Intel Open Source Graphics Center