Skip to contentSkip to conversation

ALSA: compress: add opus codec define

PATCH In review Robert Lee 3 participants 6 messages Jul 25, 2023 – Jul 26, 2023

Subsystems (2)
lore
Share & tools
lore

Robert Lee

author
#0 lore raw

PATCH 1/1 ALSA: compress: add opus codec define

Add to support decode Opus codec in Ogg container.

---
 include/uapi/sound/compress_params.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
include/uapi/sound/compress_params.h +2 -1
index ddc77322d571..bac5797bcb02 100644
@@ -43,7 +43,8 @@
 #define SND_AUDIOCODEC_BESPOKE               ((__u32) 0x0000000E)
 #define SND_AUDIOCODEC_ALAC                  ((__u32) 0x0000000F)
 #define SND_AUDIOCODEC_APE                   ((__u32) 0x00000010)
-#define SND_AUDIOCODEC_MAX                   SND_AUDIOCODEC_APE
+#define SND_AUDIOCODEC_OPUS                  ((__u32) 0x00000011)
+#define SND_AUDIOCODEC_MAX                   SND_AUDIOCODEC_OPUS
 
 /*
  * Profile and modes are listed with bit masks. This allows for a
Signature · 1 line
2.41.0.487.g6d72f3e995-goog
#1 lore raw
Quoted 4 lines · Robert Lee

Add to support decode Opus codec in Ogg container.

The change makes sense only when it's really used. So usually it's better to put into a series that actually implements its usage.

thanks,

Takashi

Quoted 21 lines
---
 include/uapi/sound/compress_params.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
include/uapi/sound/compress_params.h +2 -1
index ddc77322d571..bac5797bcb02 100644
@@ -43,7 +43,8 @@
 #define SND_AUDIOCODEC_BESPOKE               ((__u32) 0x0000000E)
 #define SND_AUDIOCODEC_ALAC                  ((__u32) 0x0000000F)
 #define SND_AUDIOCODEC_APE                   ((__u32) 0x00000010)
-#define SND_AUDIOCODEC_MAX                   SND_AUDIOCODEC_APE
+#define SND_AUDIOCODEC_OPUS                  ((__u32) 0x00000011)
+#define SND_AUDIOCODEC_MAX                   SND_AUDIOCODEC_OPUS
 
 /*
  * Profile and modes are listed with bit masks. This allows for a
Signature · 1 line
2.41.0.487.g6d72f3e995-goog
author
#2 lore raw

Thanks for reply so quickly.
And yes, there are other changes but it is inside our offload pcm driver to handle it.
Currently we only use it to decode, and we don't need additional option for it.

Thanks,
Robert.

Takashi Iwai <[email protected]> 於 2023年7月25日 週二 下午6:05寫道:

Quoted 37 lines
Quoted 4 lines · Robert Lee

Add to support decode Opus codec in Ogg container.

The change makes sense only when it's really used. So usually it's better to put into a series that actually implements its usage.

thanks,

Takashi

Quoted 21 lines
---
 include/uapi/sound/compress_params.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
include/uapi/sound/compress_params.h +2 -2
index ddc77322d571..bac5797bcb02 100644
@@ -43,7 +43,8 @@
 #define SND_AUDIOCODEC_BESPOKE               ((__u32) 0x0000000E)
 #define SND_AUDIOCODEC_ALAC                  ((__u32) 0x0000000F)
 #define SND_AUDIOCODEC_APE                   ((__u32) 0x00000010)
-#define SND_AUDIOCODEC_MAX                   SND_AUDIOCODEC_APE
+#define SND_AUDIOCODEC_OPUS                  ((__u32) 0x00000011)
+#define SND_AUDIOCODEC_MAX                   SND_AUDIOCODEC_OPUS
 
 /*
  * Profile and modes are listed with bit masks. This allows for a
--

2.41.0.487.g6d72f3e995-goog

#3 lore raw
Quoted 5 lines · Robert Lee

Thanks for reply so quickly.
And yes, there are other changes but it is inside our offload pcm driver to handle it.
Currently we only use it to decode, and we don't need additional option for it.

It means still a downstream-only change :)

It's nice to upstream changes in general, but from the upstream POV, only changing this gives no benefit. Let's tie with the actual use case *in the upstream*.

thanks,

Takashi

Quoted 43 lines

Thanks,
Robert.

Takashi Iwai <[email protected]> 於 2023年7月25日 週二 下午6:05寫道:

Quoted 37 lines
Quoted 4 lines · Robert Lee

Add to support decode Opus codec in Ogg container.

The change makes sense only when it's really used. So usually it's better to put into a series that actually implements its usage.

thanks,

Takashi

Quoted 21 lines
---
 include/uapi/sound/compress_params.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
include/uapi/sound/compress_params.h +2 -2
index ddc77322d571..bac5797bcb02 100644
@@ -43,7 +43,8 @@
 #define SND_AUDIOCODEC_BESPOKE               ((__u32) 0x0000000E)
 #define SND_AUDIOCODEC_ALAC                  ((__u32) 0x0000000F)
 #define SND_AUDIOCODEC_APE                   ((__u32) 0x00000010)
-#define SND_AUDIOCODEC_MAX                   SND_AUDIOCODEC_APE
+#define SND_AUDIOCODEC_OPUS                  ((__u32) 0x00000011)
+#define SND_AUDIOCODEC_MAX                   SND_AUDIOCODEC_OPUS
 
 /*
  * Profile and modes are listed with bit masks. This allows for a
--

2.41.0.487.g6d72f3e995-goog

author
#4 lore raw

Yes, but we still need this change to let the sound system can use the codec. or do you have any suggestions?

Thanks,
Robert.

Takashi Iwai <[email protected]> 於 2023年7月25日 週二 下午6:25寫道:

Quoted 63 lines
Quoted 5 lines · Robert Lee

Thanks for reply so quickly.
And yes, there are other changes but it is inside our offload pcm driver to handle it.
Currently we only use it to decode, and we don't need additional option for it.

It means still a downstream-only change :)

It's nice to upstream changes in general, but from the upstream POV, only changing this gives no benefit. Let's tie with the actual use case *in the upstream*.

thanks,

Takashi

Quoted 43 lines

Thanks,
Robert.

Takashi Iwai <[email protected]> 於 2023年7月25日 週二 下午6:05寫道:

Quoted 37 lines
Quoted 4 lines · Robert Lee

Add to support decode Opus codec in Ogg container.

The change makes sense only when it's really used. So usually it's better to put into a series that actually implements its usage.

thanks,

Takashi

Quoted 21 lines
---
 include/uapi/sound/compress_params.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
include/uapi/sound/compress_params.h +2 -2
index ddc77322d571..bac5797bcb02 100644
@@ -43,7 +43,8 @@
 #define SND_AUDIOCODEC_BESPOKE               ((__u32) 0x0000000E)
 #define SND_AUDIOCODEC_ALAC                  ((__u32) 0x0000000F)
 #define SND_AUDIOCODEC_APE                   ((__u32) 0x00000010)
-#define SND_AUDIOCODEC_MAX                   SND_AUDIOCODEC_APE
+#define SND_AUDIOCODEC_OPUS                  ((__u32) 0x00000011)
+#define SND_AUDIOCODEC_MAX                   SND_AUDIOCODEC_OPUS
 
 /*
  * Profile and modes are listed with bit masks. This allows for a
--

2.41.0.487.g6d72f3e995-goog

maintainer
#5 lore raw

On 26-07-23, 09:47, Robert Lee wrote:

Please stop top posting!

Quoted 2 lines

Yes, but we still need this change to let the sound system can use the codec. or do you have any suggestions?

Upstream your driver along with this change should be the way to go

Quoted 68 lines

Thanks,
Robert.

Takashi Iwai <[email protected]> 於 2023年7月25日 週二 下午6:25寫道:

Quoted 63 lines
Quoted 5 lines · Robert Lee

Thanks for reply so quickly.
And yes, there are other changes but it is inside our offload pcm driver to handle it.
Currently we only use it to decode, and we don't need additional option for it.

It means still a downstream-only change :)

It's nice to upstream changes in general, but from the upstream POV, only changing this gives no benefit. Let's tie with the actual use case *in the upstream*.

thanks,

Takashi

Quoted 43 lines

Thanks,
Robert.

Takashi Iwai <[email protected]> 於 2023年7月25日 週二 下午6:05寫道:

Quoted 37 lines
Quoted 4 lines · Robert Lee

Add to support decode Opus codec in Ogg container.

The change makes sense only when it's really used. So usually it's better to put into a series that actually implements its usage.

thanks,

Takashi

Quoted 21 lines
---
 include/uapi/sound/compress_params.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
include/uapi/sound/compress_params.h +2 -2
index ddc77322d571..bac5797bcb02 100644
@@ -43,7 +43,8 @@
 #define SND_AUDIOCODEC_BESPOKE               ((__u32) 0x0000000E)
 #define SND_AUDIOCODEC_ALAC                  ((__u32) 0x0000000F)
 #define SND_AUDIOCODEC_APE                   ((__u32) 0x00000010)
-#define SND_AUDIOCODEC_MAX                   SND_AUDIOCODEC_APE
+#define SND_AUDIOCODEC_OPUS                  ((__u32) 0x00000011)
+#define SND_AUDIOCODEC_MAX                   SND_AUDIOCODEC_OPUS
 
 /*
  * Profile and modes are listed with bit masks. This allows for a
--

2.41.0.487.g6d72f3e995-goog

Signature · 1 line
~Vinod