fbdev/hyperv_fb: Include <linux/screen_info.h>
PATCH 1/1 fbdev/hyperv_fb: Include <linux/screen_info.h>
Include <linux/screen_info.h> to get the global screen_info state. Fixes the following errors:
Quoted 1 line
Quoted 1 line
drivers/video/fbdev/hyperv_fb.c:1033:10: error: use of undeclared identifier 'screen_info'
1033 | base = screen_info.lfb_base;
| ^
drivers/video/fbdev/hyperv_fb.c:1034:10: error: use of undeclared identifier 'screen_info'
1034 | size = screen_info.lfb_size;
| ^Quoted 1 line
Quoted 1 line
drivers/video/fbdev/hyperv_fb.c:1080:3: error: must use 'struct' tag to refer to type 'screen_info'
1080 | screen_info.lfb_size = 0; | ^ | struct
Quoted 1 line
Quoted 1 line
drivers/video/fbdev/hyperv_fb.c:1080:14: error: expected identifier or '('
1080 | screen_info.lfb_size = 0;
| ^
drivers/video/fbdev/hyperv_fb.c:1081:3: error: must use 'struct' tag to refer to type 'screen_info'
1081 | screen_info.lfb_base = 0;
| ^
| struct
drivers/video/fbdev/hyperv_fb.c:1081:14: error: expected identifier or '('
1081 | screen_info.lfb_base = 0;
| ^ drivers/video/fbdev/hyperv_fb.c:1082:3: error: must use 'struct' tag to refer to type 'screen_info'
1082 | screen_info.orig_video_isVGA = 0;
| ^
| struct
drivers/video/fbdev/hyperv_fb.c:1082:14: error: expected identifier or '('
1082 | screen_info.orig_video_isVGA = 0;
| ^
8 errors generated.
--- drivers/video/fbdev/hyperv_fb.c | 1 + 1 file changed, 1 insertion(+)
drivers/video/fbdev/hyperv_fb.c +1 -0
@@ -48,6 +48,7 @@#include <linux/aperture.h> #include <linux/module.h> #include <linux/kernel.h> +#include <linux/screen_info.h> #include <linux/vmalloc.h> #include <linux/init.h> #include <linux/completion.h>
Signature · 1 line
2.41.0
Quoted 52 lines · Thomas Zimmermann
Include <
linux/screen_info.h> to get the globalscreen_infostate. Fixes the following errors:Quoted 1 line
Quoted 1 line
drivers/video/fbdev/hyperv_fb.c:1033:10: error: use of undeclared identifier 'screen_info'1033 | base = screen_info.lfb_base; | ^ drivers/video/fbdev/hyperv_fb.c:1034:10: error: use of undeclared identifier 'screen_info' 1034 | size = screen_info.lfb_size; | ^Quoted 1 line
Quoted 1 line
drivers/video/fbdev/hyperv_fb.c:1080:3: error: must use 'struct' tag to refer to type 'screen_info'1080 | screen_info.lfb_size = 0; | ^ | structQuoted 1 line
Quoted 1 line
drivers/video/fbdev/hyperv_fb.c:1080:14: error: expected identifier or '('1080 | screen_info.lfb_size = 0; | ^ drivers/video/fbdev/hyperv_fb.c:1081:3: error: must use 'struct' tag to refer to type 'screen_info' 1081 | screen_info.lfb_base = 0; | ^ | struct drivers/video/fbdev/hyperv_fb.c:1081:14: error: expected identifier or '(' 1081 | screen_info.lfb_base = 0; | ^
drivers/video/fbdev/hyperv_fb.c:1082:3: error: must use 'struct' tag to refer to type 'screen_info'
1082 | screen_info.orig_video_isVGA = 0;
| ^
| struct
drivers/video/fbdev/hyperv_fb.c:1082:14: error: expected identifier or '('
1082 | screen_info.orig_video_isVGA = 0;
| ^
8 errors generated.Reported-by kernel test robot <[email protected]>Fixes 8b0d13545b09 ("efi: Do not include <linux/screen_info.h> from EFI header")Signed-off-by Thomas Zimmermann <[email protected]>Cc "K. Y. Srinivasan" <[email protected]> (supporter:Hyper-V/Azure CORE AND DRIVERS)Cc Haiyang Zhang <[email protected]> (supporter:Hyper-V/Azure CORE AND DRIVERS)Cc Wei Liu <[email protected]> (supporter:Hyper-V/Azure CORE AND DRIVERS)Cc Dexuan Cui <[email protected]> (supporter:Hyper-V/Azure CORE AND DRIVERS)Cc Helge Deller <[email protected]> (maintainer:FRAMEBUFFER LAYER)Cc Javier Martinez Canillas <[email protected]>Cc Sui Jingfeng <[email protected]>Cc Ard Biesheuvel <[email protected]>Cc Russell King <[email protected]>Cc Catalin Marinas <[email protected]>Cc Will Deacon <[email protected]>Cc Arnd Bergmann <[email protected]>Cc [email protected] (open list:Hyper-V/Azure CORE AND DRIVERS)Cc [email protected] (open list:FRAMEBUFFER LAYER)Cc [email protected] (open list:FRAMEBUFFER LAYER)
Quoted 3 lines
--- drivers/video/fbdev/hyperv_fb.c | 1 + 1 file changed, 1 insertion(+)
Signature · 5 lines
Best regards, Javier Martinez Canillas Core Platforms Red Hat
Hi,
Quoted 32 lines · Thomas Zimmermann
Include <
linux/screen_info.h> to get the globalscreen_infostate. Fixes the following errors:Quoted 1 line
Quoted 1 line
drivers/video/fbdev/hyperv_fb.c:1033:10: error: use of undeclared identifier 'screen_info'1033 | base = screen_info.lfb_base; | ^ drivers/video/fbdev/hyperv_fb.c:1034:10: error: use of undeclared identifier 'screen_info' 1034 | size = screen_info.lfb_size; | ^Quoted 1 line
Quoted 1 line
drivers/video/fbdev/hyperv_fb.c:1080:3: error: must use 'struct' tag to refer to type 'screen_info'1080 | screen_info.lfb_size = 0; | ^ | structQuoted 1 line
Quoted 1 line
drivers/video/fbdev/hyperv_fb.c:1080:14: error: expected identifier or '('1080 | screen_info.lfb_size = 0;
| ^
drivers/video/fbdev/hyperv_fb.c:1081:3: error: must use 'struct' tag to refer to type 'screen_info'
1081 | screen_info.lfb_base = 0;
| ^
| struct
drivers/video/fbdev/hyperv_fb.c:1081:14: error: expected identifier or '('
1081 | screen_info.lfb_base = 0;
| ^
drivers/video/fbdev/hyperv_fb.c:1082:3: error: must use 'struct' tag to refer to type 'screen_info'
1082 | screen_info.orig_video_isVGA = 0;
| ^
| struct
drivers/video/fbdev/hyperv_fb.c:1082:14: error: expected identifier or '('
1082 | screen_info.orig_video_isVGA = 0;
| ^
8 errors generated.
Quoted 4 lines
Reported-by kernel test robot <[email protected]>Fixes 8b0d13545b09 ("efi: Do not include <linux/screen_info.h> from EFI header")Signed-off-by Thomas Zimmermann <[email protected]>
Quoted 25 lines
Cc "K. Y. Srinivasan" <[email protected]> (supporter:Hyper-V/Azure CORE AND DRIVERS)Cc Haiyang Zhang <[email protected]> (supporter:Hyper-V/Azure CORE AND DRIVERS)Cc Wei Liu <[email protected]> (supporter:Hyper-V/Azure CORE AND DRIVERS)Cc Dexuan Cui <[email protected]> (supporter:Hyper-V/Azure CORE AND DRIVERS)Cc Helge Deller <[email protected]> (maintainer:FRAMEBUFFER LAYER)Cc Javier Martinez Canillas <[email protected]>Cc Sui Jingfeng <[email protected]>Cc Ard Biesheuvel <[email protected]>Cc Russell King <[email protected]>Cc Catalin Marinas <[email protected]>Cc Will Deacon <[email protected]>Cc Arnd Bergmann <[email protected]>Cc [email protected] (open list:Hyper-V/Azure CORE AND DRIVERS)Cc [email protected] (open list:FRAMEBUFFER LAYER)Cc [email protected] (open list:FRAMEBUFFER LAYER)--- drivers/video/fbdev/hyperv_fb.c | 1 + 1 file changed, 1 insertion(+)drivers/video/fbdev/hyperv_fb.c +0
-0
drivers/video/fbdev/hyperv_fb.c line 54
Quoted 7 lines
drivers/video/fbdev/hyperv_fb.c +1
-0@@ -48,6 +48,7 @@#include <linux/aperture.h> #include <linux/module.h> #include <linux/kernel.h> +#include <linux/screen_info.h> #include <linux/vmalloc.h> #include <linux/init.h> #include <linux/completion.h>
Ah, I also overlook this one. :-)