Skip to contentSkip to conversation

package/wine: needs NPTL

PATCH In review Fabrice Fontaine 3 participants 3 messages Jun 15, 2022 – Aug 11, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/wine: needs NPTL

wine unconditionally uses pthread_attr_setstack resulting in the following build failure without NPTL:

/home/buildroot/autobuild/instance-3/output-1/host/lib/gcc/i586-buildroot-linux-uclibc/11.3.0/../../../../i586-buildroot-linux-uclibc/bin/ld: dlls/ntdll/unix/thread.o: in function `NtCreateThreadEx':
thread.c:(.text+0x61b): undefined reference to `pthread_attr_setstack'

Fixes:
- http://autobuild.buildroot.org/results/a866d65cda97845a8c829acad2c057bab00cde08

---
 package/wine/Config.in | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
package/wine/Config.in +4 -2
index 9de8cf0f6d..18fb0a64a2 100644
@@ -13,6 +13,8 @@ config BR2_PACKAGE_WINE
 	depends on BR2_PACKAGE_WINE_ARCH_SUPPORTS
 	# Wine unconditionally builds shared libraries
 	depends on !BR2_STATIC_LIBS
+	# pthread_attr_setstack
+	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL
 	help
 	  Wine is a compatibility layer capable of running Windows
 	  applications on Linux. Instead of simulating internal
@@ -23,6 +25,6 @@ config BR2_PACKAGE_WINE
 
 	  http://www.winehq.org
 
-comment "wine needs a toolchain w/ dynamic library"
+comment "wine needs a toolchain w/ dynamic library, NPTL"
 	depends on BR2_PACKAGE_WINE_ARCH_SUPPORTS
-	depends on BR2_STATIC_LIBS
+	depends on BR2_STATIC_LIBS || !BR2_TOOLCHAIN_HAS_THREADS_NPTL
Signature · 6 lines
2.35.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw
Quoted 6 lines · On Wed, 15 Jun 2022 22:16:22 +0200 Fabrice Fontaine…

wine unconditionally uses pthread_attr_setstack resulting in the following build failure without NPTL:

/home/buildroot/autobuild/instance-3/output-1/host/lib/gcc/i586-buildroot-linux-uclibc/11.3.0/../../../../i586-buildroot-linux-uclibc/bin/ld: dlls/ntdll/unix/thread.o: in function `NtCreateThreadEx':
thread.c:(.text+0x61b): undefined reference to `pthread_attr_setstack'

Quoted 7 lines

Fixes:
- http://autobuild.buildroot.org/results/a866d65cda97845a8c829acad2c057bab00cde08

---
 package/wine/Config.in | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

The pthread_attr_setstack() has been around for a while in Wine, so I was wondering why we're only seeing this issue now. Turns out that Wine depends on BR2_i386, and until the relatively recent move to fully random configurations, we never tested an i386 toolchain that has linuxthreads suport instead of NPTL.

Therefore: applied, thanks!

Thomas

Signature · 7 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#2 lore raw
Quoted 20 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni via buildroot <[email protected]> writes:

Quoted 7 lines · On Wed, 15 Jun 2022 22:16:22 +0200 Fabrice Fontaine…

wine unconditionally uses pthread_attr_setstack resulting in the following build failure without NPTL:

/home/buildroot/autobuild/instance-3/output-1/host/lib/gcc/i586-buildroot-linux-uclibc/11.3.0/../../../../i586-buildroot-linux-uclibc/bin/ld:
dlls/ntdll/unix/thread.o: in function `NtCreateThreadEx':
thread.c:(.text+0x61b): undefined reference to `pthread_attr_setstack'

Quoted 7 lines

Fixes:
- http://autobuild.buildroot.org/results/a866d65cda97845a8c829acad2c057bab00cde08

---
package/wine/Config.in | 6 ++++--

1 file changed, 4 insertions(+), 2 deletions(-)
Quoted 7 lines

The pthread_attr_setstack() has been around for a while in Wine, so I was wondering why we're only seeing this issue now. Turns out that Wine depends on BR2_i386, and until the relatively recent move to fully random configurations, we never tested an i386 toolchain that has linuxthreads suport instead of NPTL.

Therefore: applied, thanks!

Committed to 2022.05.x and 2022.02.x, thanks.

Signature · 5 lines
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot