Skip to contentSkip to conversation

Documentation/sysctl: document max_rcu_stall_to_panic

PATCH In review Joel Savitz 3 participants 5 messages Mar 24, 2022 – May 1, 2022 Documentation

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Documentation/sysctl: document max_rcu_stall_to_panic

commit dfe564045c65 ("rcu: Panic after fixed number of stalls") introduced a new systctl but no accompanying documentation.

Add a simple entry to the documentation.

---
 Documentation/admin-guide/sysctl/kernel.rst | 7 +++++++
 1 file changed, 7 insertions(+)
Documentation/admin-guide/sysctl/kernel.rst +7 -0
index 803c60bf21d3..4e48139b9a34 100644
@@ -781,6 +781,13 @@ is useful to define the root cause of RCU stalls using a vmcore.
 1 panic() after printing RCU stall messages.
 = ============================================================
 
+max_rcu_stall_to_panic
+======================
+
+When ``panic_on_rcu_stall`` is set to 1, this value determines the
+number of times that RCU can stall before panic() is called.
+
+When ``panic_on_rcu_stall`` is set to 0, this value is has no effect.
 
 perf_cpu_time_max_percent
 =========================
Signature · 1 line
2.27.0
maintainer
#2 lore raw
Quoted 1 line · Joel Savitz

Friendly ping.

This was waiting for an ack from an RCU person. Looking now, though, I see that you didn't copy any RCU people. Adding Paul and the author of the patch you reference (and appending patch below).

Thanks,

jon

Joel Savitz <[email protected]> (March 24) (kernel lwn)
Subject: [PATCH] Documentation/sysctl: document max_rcu_stall_to_panic
To: [email protected]
Cc: Joel Savitz <[email protected]>, Jonathan Corbet <[email protected]>, Andrew Morton <[email protected]>, Huang Ying <[email protected]>, Eric Biggers <[email protected]>, Dominik Brodowski <[email protected]>, Mauro Carvalho Chehab <[email protected]>, Rasmus Villemoes <[email protected]>, "Jason A. Donenfeld" <[email protected]>, Daniel Borkmann <[email protected]>, Rob Herring <[email protected]>, Wang Qing <[email protected]>, [email protected]
Date: Thu, 24 Mar 2022 18:11:56 -0400

commit dfe564045c65 ("rcu: Panic after fixed number of stalls") introduced a new systctl but no accompanying documentation.

Add a simple entry to the documentation.

---
 Documentation/admin-guide/sysctl/kernel.rst | 7 +++++++
 1 file changed, 7 insertions(+)
Documentation/admin-guide/sysctl/kernel.rst +7 -0
index 803c60bf21d3..4e48139b9a34 100644
@@ -781,6 +781,13 @@ is useful to define the root cause of RCU stalls using a vmcore.
 1 panic() after printing RCU stall messages.
 = ============================================================
 
+max_rcu_stall_to_panic
+======================
+
+When ``panic_on_rcu_stall`` is set to 1, this value determines the
+number of times that RCU can stall before panic() is called.
+
+When ``panic_on_rcu_stall`` is set to 0, this value is has no effect.
 
 perf_cpu_time_max_percent
 =========================
#3 lore raw
Quoted 7 lines · Jonathan Corbet
Quoted 1 line · Joel Savitz

Friendly ping.

This was waiting for an ack from an RCU person. Looking now, though, I see that you didn't copy any RCU people. Adding Paul and the author of the patch you reference (and appending patch below).

Thank you for calling this to my attention. ;-)

Quoted 10 lines

Thanks,

jon

Joel Savitz <[email protected]> (March 24) (kernel lwn)
Subject: [PATCH] Documentation/sysctl: document max_rcu_stall_to_panic
To: [email protected]
Cc: Joel Savitz <[email protected]>, Jonathan Corbet <[email protected]>, Andrew Morton <[email protected]>, Huang Ying <[email protected]>, Eric Biggers <[email protected]>, Dominik Brodowski <[email protected]>, Mauro Carvalho Chehab <[email protected]>, Rasmus Villemoes <[email protected]>, "Jason A. Donenfeld" <[email protected]>, Daniel Borkmann <[email protected]>, Rob Herring <[email protected]>, Wang Qing <[email protected]>, [email protected]
Date: Thu, 24 Mar 2022 18:11:56 -0400

Quoted 6 lines

commit dfe564045c65 ("rcu: Panic after fixed number of stalls") introduced a new systctl but no accompanying documentation.

Add a simple entry to the documentation.

Quoted 22 lines
---
 Documentation/admin-guide/sysctl/kernel.rst | 7 +++++++
 1 file changed, 7 insertions(+)
Documentation/admin-guide/sysctl/kernel.rst +7 -0
index 803c60bf21d3..4e48139b9a34 100644
@@ -781,6 +781,13 @@ is useful to define the root cause of RCU stalls using a vmcore.
 1 panic() after printing RCU stall messages.
 = ============================================================
 
+max_rcu_stall_to_panic
+======================
+
+When ``panic_on_rcu_stall`` is set to 1, this value determines the
+number of times that RCU can stall before panic() is called.
+
+When ``panic_on_rcu_stall`` is set to 0, this value is has no effect.
 
 perf_cpu_time_max_percent
 =========================