Skip to contentSkip to conversation

arm64: dts: armada-3720-turris-mox.dts: remove mrvl,i2c-fast-mode

PATCH Superseded Pali Rohár 4 participants 6 messages Jun 28, 2021 – Jul 23, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm64: dts: armada-3720-turris-mox.dts: remove mrvl,i2c-fast-mode

Some SFP modules are not detected when i2c-fast-mode is enabled even when clock-frequency is already set to 100000. The I2C bus violates the timing specifications when run in fast mode. So disable fast mode on Turris Mox.

Same change was already applied for uDPU (also Armada 3720 board with SFP) in commit fe3ec631a77d ("arm64: dts: uDPU: remove i2c-fast-mode").

Fixes 7109d817db2e ("arm64: dts: marvell: add DTS for Turris Mox")
---
 arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts | 1 +
 1 file changed, 1 insertion(+)
arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts +1 -0
index 6bcc319a0161..27ded36a1a13 100644
@@ -119,6 +119,7 @@
 	pinctrl-names = "default";
 	pinctrl-0 = <&i2c1_pins>;
 	clock-frequency = <100000>;
+	/delete-property/mrvl,i2c-fast-mode;
 	status = "okay";
 
 	rtc@6f {
Signature · 1 line
2.20.1
Reviewed-by on v1 1/1
#1 lore raw

arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts line 122

Quoted 1 line · On Mon, 28 Jun 2021 14:10:15 +0200 Pali Rohár <[email protected]> wrote:
arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts +1 -0
+	/delete-property/mrvl,i2c-fast-mode;

Can you add an additional space here?
/delete-property/ mrvl,i2c-fast-mode;

Other than that

BTW the i2c driver should me made to respect the clock-frequency DT property, not the fast-mode nonsense.

The mrvl,i2c-fast-mode should be IMO completely removed and whether it is enabled should be decided by the value of clock-frequency.

BTW there are clock generating registers in A3720 I2C controller that can generate 100 kHz even in fast-mode. The driver does not use them, though, it leaves them to their default values, which for normal mode generate ~96 kHz and for fast mode ~258 kHz. Maybe we should implement configuring these registers and make the driver choose normal-mode / fast-mode / high-speed mode depending on clock-frequency ?

Marek

#2 lore raw
In reply to Pali Rohár

Also please remove ".dts" from commit title, i.e.:
arm64: dts: armada-3720-turris-mox: remove mrvl,i2c-fast-mode

since "dts" is already present in the prefix.

Marek

#3 lore raw

PATCH v2 1/1 arm64: dts: armada-3720-turris-mox: remove mrvl,i2c-fast-mode

In reply to Pali Rohár

Some SFP modules are not detected when i2c-fast-mode is enabled even when clock-frequency is already set to 100000. The I2C bus violates the timing specifications when run in fast mode. So disable fast mode on Turris Mox.

Same change was already applied for uDPU (also Armada 3720 board with SFP) in commit fe3ec631a77d ("arm64: dts: uDPU: remove i2c-fast-mode").

Fixes 7109d817db2e ("arm64: dts: marvell: add DTS for Turris Mox")
---
 arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts | 1 +
 1 file changed, 1 insertion(+)
arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts +1 -0
index 6bcc319a0161..85f15f2a4740 100644
@@ -119,6 +119,7 @@
 	pinctrl-names = "default";
 	pinctrl-0 = <&i2c1_pins>;
 	clock-frequency = <100000>;
+	/delete-property/ mrvl,i2c-fast-mode;
 	status = "okay";
 
 	rtc@6f {
Signature · 7 lines
2.20.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Acked-by on v2 1/1
#4 lore raw

Re: [PATCH v2] arm64: dts: armada-3720-turris-mox: remove mrvl,i2c-fast-mode

Quoted 3 lines · Pali Rohár

Some SFP modules are not detected when i2c-fast-mode is enabled even when clock-frequency is already set to 100000. The I2C bus violates the timing specifications when run in fast mode. So disable fast mode on Turris Mox.

Yes. SFP module specification is 100kHz max on the I2C bus, which is often forgotten about until someone runs into a problem.

Signature · 2 lines
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
maintainer
#5 lore raw

Re: [PATCH v2] arm64: dts: armada-3720-turris-mox: remove mrvl,i2c-fast-mode

In reply to Pali Rohár

Hi Pali,

Quoted 10 lines

Some SFP modules are not detected when i2c-fast-mode is enabled even when clock-frequency is already set to 100000. The I2C bus violates the timing specifications when run in fast mode. So disable fast mode on Turris Mox.

Same change was already applied for uDPU (also Armada 3720 board with SFP) in commit fe3ec631a77d ("arm64: dts: uDPU: remove i2c-fast-mode").

Fixes 7109d817db2e ("arm64: dts: marvell: add DTS for Turris Mox")

Applied on mvebu/fixes

Thanks,

Gregory

Quoted 19 lines
---
 arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts | 1 +
 1 file changed, 1 insertion(+)
arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts +1 -0
index 6bcc319a0161..85f15f2a4740 100644
@@ -119,6 +119,7 @@
 	pinctrl-names = "default";
 	pinctrl-0 = <&i2c1_pins>;
 	clock-frequency = <100000>;
+	/delete-property/ mrvl,i2c-fast-mode;
 	status = "okay";
 
 	rtc@6f {
Signature · 1 line
2.20.1
Signature · 3 lines
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com