Skip to contentSkip to conversation

package/openntpd: needs host-bison

PATCH New Baruch Siach 3 participants 7 messages Nov 16, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/openntpd: needs host-bison

Build fails when no yacc alternative is installed.

Fixes:
http://autobuild.buildroot.net/results/1ba8e339cbb5646663d0bf4e158d89e54433b242/
http://autobuild.buildroot.net/results/a00a53d6635c64e72c50d4841658155de5380110/

---
 package/openntpd/openntpd.mk | 1 +
 1 file changed, 1 insertion(+)
package/openntpd/openntpd.mk +1 -0
index f2eaee7efd46..9076f3ddda4e 100644
@@ -8,6 +8,7 @@ OPENNTPD_VERSION = 6.2p3
 OPENNTPD_SITE = http://ftp.openbsd.org/pub/OpenBSD/OpenNTPD
 OPENNTPD_LICENSE = MIT-like, BSD-2-Clause, BSD-3-Clause
 OPENNTPD_LICENSE_FILES = COPYING
+OPENNTPD_DEPENDENCIES = host-bison
 # Need to autoreconf for our libtool patch to apply properly
 OPENNTPD_AUTORECONF = YES
 
Signature · 1 line
2.29.2
#1 lore raw

PATCH 1/1 package/openntpd: needs host-bison

Quoted 17 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Baruch" == Baruch Siach <[email protected]> writes:

Build fails when no yacc alternative is installed. Fixes:
http://autobuild.buildroot.net/results/1ba8e339cbb5646663d0bf4e158d89e54433b242/
http://autobuild.buildroot.net/results/a00a53d6635c64e72c50d4841658155de5380110/

---
 package/openntpd/openntpd.mk | 1 +
 1 file changed, 1 insertion(+)
package/openntpd/openntpd.mk +0 -0
index f2eaee7efd46..9076f3ddda4e 100644

package/openntpd/openntpd.mk OPENNTPD_VERSION = 6.2p3 · line 11

Quoted 4 lines
package/openntpd/openntpd.mk +1 -0
@@ -8,6 +8,7 @@ OPENNTPD_VERSION = 6.2p3
 OPENNTPD_SITE = http://ftp.openbsd.org/pub/OpenBSD/OpenNTPD
 OPENNTPD_LICENSE = MIT-like, BSD-2-Clause, BSD-3-Clause
 OPENNTPD_LICENSE_FILES = COPYING
+OPENNTPD_DEPENDENCIES = host-bison

Can we not use $(BR2_BISON_HOST_DEPENDENCY) instead?

Signature · 1 line
Bye, Peter Korsgaard
#2 lore raw

PATCH 1/1 package/openntpd: needs host-bison

Hi Peter,

+Yann.

Quoted 12 lines · Peter Korsgaard
Quoted 11 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Baruch" == Baruch Siach <[email protected]> writes:

Build fails when no yacc alternative is installed. Fixes:
http://autobuild.buildroot.net/results/1ba8e339cbb5646663d0bf4e158d89e54433b242/
http://autobuild.buildroot.net/results/a00a53d6635c64e72c50d4841658155de5380110/

---
 package/openntpd/openntpd.mk | 1 +
 1 file changed, 1 insertion(+)
Quoted 11 lines

package/openntpd/openntpd.mk OPENNTPD_VERSION = 6.2p3 · line 11

Quoted 9 lines
package/openntpd/openntpd.mk +1 -0
index f2eaee7efd46..9076f3ddda4e 100644
@@ -8,6 +8,7 @@ OPENNTPD_VERSION = 6.2p3
 OPENNTPD_SITE = http://ftp.openbsd.org/pub/OpenBSD/OpenNTPD
 OPENNTPD_LICENSE = MIT-like, BSD-2-Clause, BSD-3-Clause
 OPENNTPD_LICENSE_FILES = COPYING
+OPENNTPD_DEPENDENCIES = host-bison

Can we not use $(BR2_BISON_HOST_DEPENDENCY) instead?

We surly can. But for some reason no other package under package/ uses BR2_BISON_HOST_DEPENDENCY. Plain host-bison is used there instead. Only Barebox, U-Boot and the kernel use it. Why is that?

Commit b01100cc901a83 ("linux: kconfig may need host-{flex, bison} to build the configurators") mentions kconfig. Is that related?

I guess that BR2_BISON_HOST_DEPENDENCY is more susceptible to incompatibility due to different host installed bison versions (and same for flex).

baruch

Signature · 3 lines
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
#3 lore raw

PATCH 1/1 package/openntpd: needs host-bison

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Baruch" == Baruch Siach <[email protected]> writes:

Hi,

Quoted 7 lines
Quoted 3 lines
Quoted 1 line

+OPENNTPD_DEPENDENCIES = host-bison

Can we not use $(BR2_BISON_HOST_DEPENDENCY) instead?

We surly can. But for some reason no other package under package/ uses BR2_BISON_HOST_DEPENDENCY. Plain host-bison is used there instead. Only Barebox, U-Boot and the kernel use it. Why is that?

Your tree is not uptodate, we also have it in linux-backports ;)

But yes, it is a bit odd that we are not using it more often. Probably it is mostly just because it is fairly new (~2 years) and not really documented anywhere.

Yann, you added it, anything to add?

Quoted 6 lines

Commit b01100cc901a83 ("linux: kconfig may need host-{flex, bison} to build the configurators") mentions kconfig. Is that related?

I guess that BR2_BISON_HOST_DEPENDENCY is more susceptible to incompatibility due to different host installed bison versions (and same for flex).

Correct, similar to the other components where we can use what is available on the host if new enough. For bison/flex, I would imagine that the version incompatibilities are fairly small (even though we do have some patches for building with bison 3.7.1).

Signature · 1 line
Bye, Peter Korsgaard
#4 lore raw

PATCH 1/1 package/openntpd: needs host-bison

In reply to Baruch Siach

Baruch, Peter, All,

On 2020-11-16 19:09 +0200, Baruch Siach spake thusly:

Quoted 29 lines · Peter Korsgaard
Quoted 12 lines
Quoted 11 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Baruch" == Baruch Siach <[email protected]> writes:

Build fails when no yacc alternative is installed. Fixes:
http://autobuild.buildroot.net/results/1ba8e339cbb5646663d0bf4e158d89e54433b242/
http://autobuild.buildroot.net/results/a00a53d6635c64e72c50d4841658155de5380110/

---
 package/openntpd/openntpd.mk | 1 +
 1 file changed, 1 insertion(+)
Quoted 11 lines

package/openntpd/openntpd.mk OPENNTPD_VERSION = 6.2p3 · line 11

Quoted 9 lines
package/openntpd/openntpd.mk +1 -0
index f2eaee7efd46..9076f3ddda4e 100644
@@ -8,6 +8,7 @@ OPENNTPD_VERSION = 6.2p3
 OPENNTPD_SITE = http://ftp.openbsd.org/pub/OpenBSD/OpenNTPD
 OPENNTPD_LICENSE = MIT-like, BSD-2-Clause, BSD-3-Clause
 OPENNTPD_LICENSE_FILES = COPYING
+OPENNTPD_DEPENDENCIES = host-bison

Can we not use $(BR2_BISON_HOST_DEPENDENCY) instead?

We surly can. But for some reason no other package under package/ uses BR2_BISON_HOST_DEPENDENCY. Plain host-bison is used there instead. Only Barebox, U-Boot and the kernel use it. Why is that?

Quoted 6 lines

Commit b01100cc901a83 ("linux: kconfig may need host-{flex, bison} to build the configurators") mentions kconfig. Is that related?

I guess that BR2_BISON_HOST_DEPENDENCY is more susceptible to incompatibility due to different host installed bison versions (and same for flex).

The rule is that we can depend on $(BR2_BISON_HOST_DEPENDENCY) to build host tools, but we really want to depend on host-bison when we generate code that is built for the target.

Indeed, different versions of bison will generate different C code, and thus the resulting binary will change. This is not very reproducible. (Yes, I've already experienced that, and finding the root cause of the delta cost me about two weeks full-time...)

AFAICS, the openntd code will be running on the target, so we do want the host-bison dependency.

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#5 lore raw

PATCH 1/1 package/openntpd: needs host-bison

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Yann" == Yann E MORIN <[email protected]> writes:

Hi,

Quoted 22 lines
Quoted 6 lines
Quoted 1 line

Can we not use $(BR2_BISON_HOST_DEPENDENCY) instead?

We surly can. But for some reason no other package under package/ uses BR2_BISON_HOST_DEPENDENCY. Plain host-bison is used there instead. Only Barebox, U-Boot and the kernel use it. Why is that?

Quoted 6 lines

Commit b01100cc901a83 ("linux: kconfig may need host-{flex, bison} to build the configurators") mentions kconfig. Is that related?

I guess that BR2_BISON_HOST_DEPENDENCY is more susceptible to incompatibility due to different host installed bison versions (and same for flex).

The rule is that we can depend on $(BR2_BISON_HOST_DEPENDENCY) to build host tools, but we really want to depend on host-bison when we generate code that is built for the target.

Indeed, different versions of bison will generate different C code, and thus the resulting binary will change. This is not very reproducible. (Yes, I've already experienced that, and finding the root cause of the delta cost me about two weeks full-time...)

Quoted 4 lines

AFAICS, the openntd code will be running on the target, so we do want the host-bison dependency.

Ok, we should probably add a sensible note about that in check-host-bison-flex.mk to make that clear.

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#6 lore raw

PATCH 1/1 package/openntpd: needs host-bison

In reply to Baruch Siach
Quoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Baruch" == Baruch Siach <[email protected]> writes:

Build fails when no yacc alternative is installed. Fixes:
http://autobuild.buildroot.net/results/1ba8e339cbb5646663d0bf4e158d89e54433b242/
http://autobuild.buildroot.net/results/a00a53d6635c64e72c50d4841658155de5380110/

Committed to 2020.02.x and 2020.08.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard