Skip to contentSkip to conversation

drm: panel-orientation-quirks: 320 FHD and D330 HD

PATCH In review David Santamaría Rogado 3 participants 7 messages Jul 30, 2019 – Apr 27, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm: panel-orientation-quirks: 320 FHD and D330 HD

This adds the HD version of Lenovo Ideapad D330
and FHD version of Lenovo Ideapad Miix 320.

This should work despite the dmi data is the same because the resolution checks.

---
 drivers/gpu/drm/drm_panel_orientation_quirks.c | 18 ++++++++++++++++--
 1 file changed, 16 insertions(+), 2 deletions(-)
drivers/gpu/drm/drm_panel_orientation_quirks.c +16 -2
index ffd95bfeaa94..896c783ce135 100644
@@ -191,14 +191,28 @@ static const struct dmi_system_id orientation_data[] = {
 		  DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "MIIX 310-10ICR"),
 		},
 		.driver_data = (void *)&lcd800x1280_rightside_up,
-	}, {	/* Lenovo Ideapad Miix 320 */
+	}, {	/* Lenovo Ideapad Miix 320 (HD) */
 		.matches = {
 		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"),
 		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "80XF"),
 		  DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Lenovo MIIX 320-10ICR"),
 		},
 		.driver_data = (void *)&lcd800x1280_rightside_up,
-	}, {	/* Lenovo Ideapad D330 */
+	}, {	/* Lenovo Ideapad Miix 320 (FHD) */
+		.matches = {
+		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "80XF"),
+		  DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Lenovo MIIX 320-10ICR"),
+		},
+		.driver_data = (void *)&lcd1200x1920_rightside_up,
+	}, {	/* Lenovo Ideapad D330 (HD) */
+		.matches = {
+		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "81H3"),
+		  DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Lenovo ideapad D330-10IGM"),
+		},
+		.driver_data = (void *)&lcd800x1280_rightside_up,
+	}, {	/* Lenovo Ideapad D330 (FHD) */
 		.matches = {
 		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"),
 		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "81H3"),
Signature · 6 lines
2.21.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
#1 lore raw

This patch is similar to the previous one but have found that Miix 320 also have FHD version,
so include it while adding D330 HD.

Quoted 48 lines · David Santamaría Rogado

This adds the HD version of Lenovo Ideapad D330
and FHD version of Lenovo Ideapad Miix 320.

This should work despite the dmi data is the same because the resolution checks.

---
 drivers/gpu/drm/drm_panel_orientation_quirks.c | 18 ++++++++++++++++--
 1 file changed, 16 insertions(+), 2 deletions(-)
drivers/gpu/drm/drm_panel_orientation_quirks.c +16 -3
index ffd95bfeaa94..896c783ce135 100644
@@ -191,14 +191,28 @@ static const struct dmi_system_id orientation_data[] = {
                  DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "MIIX 310-10ICR"),
                },
                .driver_data = (void *)&lcd800x1280_rightside_up,
-       }, {    /* Lenovo Ideapad Miix 320 */
+       }, {    /* Lenovo Ideapad Miix 320 (HD) */
                .matches = {
                  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"),
                  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "80XF"),
                  DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Lenovo MIIX 320-10ICR"),
                },
                .driver_data = (void *)&lcd800x1280_rightside_up,
-       }, {    /* Lenovo Ideapad D330 */
+       }, {    /* Lenovo Ideapad Miix 320 (FHD) */
+               .matches = {
+                 DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+                 DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "80XF"),
+                 DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Lenovo MIIX 320-10ICR"),
+               },
+               .driver_data = (void *)&lcd1200x1920_rightside_up,
+       }, {    /* Lenovo Ideapad D330 (HD) */
+               .matches = {
+                 DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+                 DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "81H3"),
+                 DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Lenovo ideapad D330-10IGM"),
+               },
+               .driver_data = (void *)&lcd800x1280_rightside_up,
+       }, {    /* Lenovo Ideapad D330 (FHD) */
                .matches = {
                  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"),
                  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "81H3"),
--
Quoted 2 lines

2.21.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#2 lore raw
In reply to David Santamaría Rogado

This patch is still valid as no changes to panel orientation quirks have been done. Someone can review this to merge?

Quoted 48 lines · David Santamaría Rogado

This adds the HD version of Lenovo Ideapad D330
and FHD version of Lenovo Ideapad Miix 320.

This should work despite the dmi data is the same because the resolution checks.

---
 drivers/gpu/drm/drm_panel_orientation_quirks.c | 18 ++++++++++++++++--
 1 file changed, 16 insertions(+), 2 deletions(-)
drivers/gpu/drm/drm_panel_orientation_quirks.c +16 -3
index ffd95bfeaa94..896c783ce135 100644
@@ -191,14 +191,28 @@ static const struct dmi_system_id orientation_data[] = {
                  DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "MIIX 310-10ICR"),
                },
                .driver_data = (void *)&lcd800x1280_rightside_up,
-       }, {    /* Lenovo Ideapad Miix 320 */
+       }, {    /* Lenovo Ideapad Miix 320 (HD) */
                .matches = {
                  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"),
                  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "80XF"),
                  DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Lenovo MIIX 320-10ICR"),
                },
                .driver_data = (void *)&lcd800x1280_rightside_up,
-       }, {    /* Lenovo Ideapad D330 */
+       }, {    /* Lenovo Ideapad Miix 320 (FHD) */
+               .matches = {
+                 DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+                 DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "80XF"),
+                 DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Lenovo MIIX 320-10ICR"),
+               },
+               .driver_data = (void *)&lcd1200x1920_rightside_up,
+       }, {    /* Lenovo Ideapad D330 (HD) */
+               .matches = {
+                 DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+                 DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "81H3"),
+                 DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Lenovo ideapad D330-10IGM"),
+               },
+               .driver_data = (void *)&lcd800x1280_rightside_up,
+       }, {    /* Lenovo Ideapad D330 (FHD) */
                .matches = {
                  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"),
                  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "81H3"),
--
Quoted 2 lines

2.21.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#3 lore raw
Quoted 2 lines · David Santamaría Rogado

This patch is still valid as no changes to panel orientation quirks have been done. Someone can review this to merge?

Cc Hans.
Quoted 53 lines
Quoted 50 lines · David Santamaría Rogado

This adds the HD version of Lenovo Ideapad D330
and FHD version of Lenovo Ideapad Miix 320.

This should work despite the dmi data is the same because the resolution checks.

---
 drivers/gpu/drm/drm_panel_orientation_quirks.c | 18 ++++++++++++++++--
 1 file changed, 16 insertions(+), 2 deletions(-)
drivers/gpu/drm/drm_panel_orientation_quirks.c +16 -3
index ffd95bfeaa94..896c783ce135 100644
@@ -191,14 +191,28 @@ static const struct dmi_system_id orientation_data[] = {
                  DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "MIIX 310-10ICR"),
                },
                .driver_data = (void *)&lcd800x1280_rightside_up,
-       }, {    /* Lenovo Ideapad Miix 320 */
+       }, {    /* Lenovo Ideapad Miix 320 (HD) */
                .matches = {
                  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"),
                  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "80XF"),
                  DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Lenovo MIIX 320-10ICR"),
                },
                .driver_data = (void *)&lcd800x1280_rightside_up,
-       }, {    /* Lenovo Ideapad D330 */
+       }, {    /* Lenovo Ideapad Miix 320 (FHD) */
+               .matches = {
+                 DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+                 DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "80XF"),
+                 DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Lenovo MIIX 320-10ICR"),
+               },
+               .driver_data = (void *)&lcd1200x1920_rightside_up,
+       }, {    /* Lenovo Ideapad D330 (HD) */
+               .matches = {
+                 DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+                 DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "81H3"),
+                 DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Lenovo ideapad D330-10IGM"),
+               },
+               .driver_data = (void *)&lcd800x1280_rightside_up,
+       }, {    /* Lenovo Ideapad D330 (FHD) */
                .matches = {
                  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"),
                  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "81H3"),
--

2.21.0

Signature · 5 lines
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Reviewed-by
#4 lore raw

Hi,

Quoted 5 lines · Jani Nikula
Quoted 2 lines · David Santamaría Rogado

This patch is still valid as no changes to panel orientation quirks have been done. Someone can review this to merge?

Cc Hans.

Looks good to me:

Regards,

Hans

Quoted 44 lines
Quoted 44 lines
Quoted 42 lines · David Santamaría Rogado

This adds the HD version of Lenovo Ideapad D330
and FHD version of Lenovo Ideapad Miix 320.

This should work despite the dmi data is the same because the resolution checks.

---
  drivers/gpu/drm/drm_panel_orientation_quirks.c | 18 ++++++++++++++++--
  1 file changed, 16 insertions(+), 2 deletions(-)
drivers/gpu/drm/drm_panel_orientation_quirks.c +14 -2
index ffd95bfeaa94..896c783ce135 100644
@@ -191,14 +191,28 @@ static const struct dmi_system_id orientation_data[] = {
                   DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "MIIX 310-10ICR"),
                 },
                 .driver_data = (void *)&lcd800x1280_rightside_up,
-       }, {    /* Lenovo Ideapad Miix 320 */
+       }, {    /* Lenovo Ideapad Miix 320 (HD) */
                 .matches = {
                   DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"),
                   DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "80XF"),
                   DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Lenovo MIIX 320-10ICR"),
                 },
                 .driver_data = (void *)&lcd800x1280_rightside_up,
-       }, {    /* Lenovo Ideapad D330 */
+       }, {    /* Lenovo Ideapad Miix 320 (FHD) */
+               .matches = {
+                 DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+                 DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "80XF"),
+                 DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Lenovo MIIX 320-10ICR"),
+               },
+               .driver_data = (void *)&lcd1200x1920_rightside_up,
+       }, {    /* Lenovo Ideapad D330 (HD) */
+               .matches = {
+                 DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+                 DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "81H3"),
+                 DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Lenovo ideapad D330-10IGM"),
+               },
Quoted 9 lines
Quoted 8 lines
Quoted 8 lines
drivers/gpu/drm/drm_panel_orientation_quirks.c +2 -1
+               .driver_data = (void *)&lcd800x1280_rightside_up,
+       }, {    /* Lenovo Ideapad D330 (FHD) */
                 .matches = {
                   DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"),
                   DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "81H3"),
--

2.21.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#5 lore raw

Hi, Jani don't forget about me, I have in mind to afford the 8 GB RAM version and will need more orientation inclusions :)

I have even looking at this issue with UEFI Shell, could be possible that the Intel video driver can get the correct panel location based in another thing? The UEFI Shell can get both orientations by just changing the mode, there are modes for portrait and landscape, but if there is no other way these quirks are the only way to get these machine properly for now.

Quoted 10 lines · Hans de Goede

Hi,

Quoted 5 lines · Jani Nikula
Quoted 2 lines · David Santamaría Rogado

This patch is still valid as no changes to panel orientation quirks have been done. Someone can review this to merge?

Cc Hans.
Quoted 65 lines

Looks good to me:

Regards,

Hans

Quoted 53 lines
Quoted 52 lines
Quoted 50 lines · David Santamaría Rogado

This adds the HD version of Lenovo Ideapad D330
and FHD version of Lenovo Ideapad Miix 320.

This should work despite the dmi data is the same because the resolution checks.

---
  drivers/gpu/drm/drm_panel_orientation_quirks.c | 18 ++++++++++++++++--
  1 file changed, 16 insertions(+), 2 deletions(-)
drivers/gpu/drm/drm_panel_orientation_quirks.c +16 -3
index ffd95bfeaa94..896c783ce135 100644
@@ -191,14 +191,28 @@ static const struct dmi_system_id orientation_data[] = {
                   DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "MIIX 310-10ICR"),
                 },
                 .driver_data = (void *)&lcd800x1280_rightside_up,
-       }, {    /* Lenovo Ideapad Miix 320 */
+       }, {    /* Lenovo Ideapad Miix 320 (HD) */
                 .matches = {
                   DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"),
                   DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "80XF"),
                   DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Lenovo MIIX 320-10ICR"),
                 },
                 .driver_data = (void *)&lcd800x1280_rightside_up,
-       }, {    /* Lenovo Ideapad D330 */
+       }, {    /* Lenovo Ideapad Miix 320 (FHD) */
+               .matches = {
+                 DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+                 DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "80XF"),
+                 DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Lenovo MIIX 320-10ICR"),
+               },
+               .driver_data = (void *)&lcd1200x1920_rightside_up,
+       }, {    /* Lenovo Ideapad D330 (HD) */
+               .matches = {
+                 DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+                 DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "81H3"),
+                 DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Lenovo ideapad D330-10IGM"),
+               },
+               .driver_data = (void *)&lcd800x1280_rightside_up,
+       }, {    /* Lenovo Ideapad D330 (FHD) */
                 .matches = {
                   DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"),
                   DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "81H3"),
--

2.21.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#6 lore raw

Perhaps the Windows Intel video driver doesn't try the highest available mode reported by GOP in some circumstances? Seems that the right panel orientation appear as a less mode than the wrong one.

Quoted 11 lines · David Santamaría Rogado

Hi, Jani don't forget about me, I have in mind to afford the 8 GB RAM version and will need more orientation inclusions :)

I have even looking at this issue with UEFI Shell, could be possible that the Intel video driver can get the correct panel location based in another thing? The UEFI Shell can get both orientations by just changing the mode, there are modes for portrait and landscape, but if there is no other way these quirks are the only way to get these machine properly for now.

Quoted 77 lines
Quoted 75 lines · Hans de Goede

Hi,

Quoted 5 lines · Jani Nikula
Quoted 2 lines · David Santamaría Rogado

This patch is still valid as no changes to panel orientation quirks have been done. Someone can review this to merge?

Cc Hans.

Looks good to me:

Regards,

Hans

Quoted 53 lines
Quoted 52 lines
Quoted 50 lines · David Santamaría Rogado

This adds the HD version of Lenovo Ideapad D330
and FHD version of Lenovo Ideapad Miix 320.

This should work despite the dmi data is the same because the resolution checks.

---
  drivers/gpu/drm/drm_panel_orientation_quirks.c | 18 ++++++++++++++++--
  1 file changed, 16 insertions(+), 2 deletions(-)
drivers/gpu/drm/drm_panel_orientation_quirks.c +16 -3
index ffd95bfeaa94..896c783ce135 100644
@@ -191,14 +191,28 @@ static const struct dmi_system_id orientation_data[] = {
                   DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "MIIX 310-10ICR"),
                 },
                 .driver_data = (void *)&lcd800x1280_rightside_up,
-       }, {    /* Lenovo Ideapad Miix 320 */
+       }, {    /* Lenovo Ideapad Miix 320 (HD) */
                 .matches = {
                   DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"),
                   DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "80XF"),
                   DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Lenovo MIIX 320-10ICR"),
                 },
                 .driver_data = (void *)&lcd800x1280_rightside_up,
-       }, {    /* Lenovo Ideapad D330 */
+       }, {    /* Lenovo Ideapad Miix 320 (FHD) */
+               .matches = {
+                 DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+                 DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "80XF"),
+                 DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Lenovo MIIX 320-10ICR"),
+               },
+               .driver_data = (void *)&lcd1200x1920_rightside_up,
+       }, {    /* Lenovo Ideapad D330 (HD) */
+               .matches = {
+                 DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+                 DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "81H3"),
+                 DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Lenovo ideapad D330-10IGM"),
+               },
+               .driver_data = (void *)&lcd800x1280_rightside_up,
+       }, {    /* Lenovo Ideapad D330 (FHD) */
                 .matches = {
                   DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"),
                   DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "81H3"),
--

2.21.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel