Skip to contentSkip to conversation

boot/barebox-aux: exclude git downloads from hash check

PATCH New Yann E. MORIN 3 participants 3 messages Mar 19, 2020 – Mar 27, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 boot/barebox-aux: exclude git downloads from hash check

When barebox, and thus barebox-aux, are downloaded from a git tree, then barebox-aux download fails because a hash check is attempted on the downloaded archive:

Could not fetch special ref 'v2020.03.0'; assuming it is not special.
ERROR: No hash found for barebox-aux-v2020.03.0.tar.gz

This is because we only exclude from the check the archive of the bare barebox:

    BR_NO_CHECK_HASH_FOR += $(BAREBOX_SOURCE)

However, the default name of an archive is based on the package name, which for barebox-aux is not 'barebox'.

Since barebox-aux really uses the exact same source as the bare barebox, it should also share the archive name.

This has two direct consequences and advantages:

- the hash check is completely avoided for the barebox-aux archive;

- the barebox-aux archive is not downloaded as it is already downloaded for barebox.

---
Note: that last claim about the download being done only once requires that a previous patch be applied first (with typoes fixed):

    https://patchwork.ozlabs.org/patch/1258482/
---
 boot/barebox/barebox.mk | 4 ++++
 1 file changed, 4 insertions(+)
boot/barebox/barebox.mk +4 -0
index 3d7492598f..1efe5665de 100644
@@ -25,6 +25,10 @@ $(1)_SOURCE = $$(notdir $$($(1)_TARBALL))
 else ifeq ($$(BR2_TARGET_BAREBOX_CUSTOM_GIT),y)
 $(1)_SITE = $$(call qstrip,$$(BR2_TARGET_BAREBOX_CUSTOM_GIT_REPO_URL))
 $(1)_SITE_METHOD = git
+# Override the default value of _SOURCE to 'barebox-*' so that it is not
+# downloaded a second time for barebox-aux; also alows avoiding the hash
+# check:
+$(1)_SOURCE = barebox-$$($(1)_VERSION).tar.gz
 else
 # Handle stable official Barebox versions
 $(1)_SOURCE = barebox-$$($(1)_VERSION).tar.bz2
Signature · 1 line
2.20.1
#1 lore raw

PATCH 1/1 boot/barebox-aux: exclude git downloads from hash check

Quoted 21 lines · Yann E. MORIN

When barebox, and thus barebox-aux, are downloaded from a git tree, then barebox-aux download fails because a hash check is attempted on the downloaded archive:

Could not fetch special ref 'v2020.03.0'; assuming it is not special.
ERROR: No hash found for barebox-aux-v2020.03.0.tar.gz

This is because we only exclude from the check the archive of the bare barebox:

    BR_NO_CHECK_HASH_FOR += $(BAREBOX_SOURCE)

However, the default name of an archive is based on the package name, which for barebox-aux is not 'barebox'.

Since barebox-aux really uses the exact same source as the bare barebox, it should also share the archive name.

This has two direct consequences and advantages:

Quoted 7 lines

- the hash check is completely avoided for the barebox-aux archive;

- the barebox-aux archive is not downloaded as it is already downloaded for barebox.

Quoted 27 lines

---
Note: that last claim about the download being done only once requires that a previous patch be applied first (with typoes fixed):

    https://patchwork.ozlabs.org/patch/1258482/
---
 boot/barebox/barebox.mk | 4 ++++
 1 file changed, 4 insertions(+)
boot/barebox/barebox.mk +4 -1
index 3d7492598f..1efe5665de 100644
@@ -25,6 +25,10 @@ $(1)_SOURCE = $$(notdir $$($(1)_TARBALL))
 else ifeq ($$(BR2_TARGET_BAREBOX_CUSTOM_GIT),y)
 $(1)_SITE = $$(call qstrip,$$(BR2_TARGET_BAREBOX_CUSTOM_GIT_REPO_URL))
 $(1)_SITE_METHOD = git
+# Override the default value of _SOURCE to 'barebox-*' so that it is not
+# downloaded a second time for barebox-aux; also alows avoiding the hash
+# check:
+$(1)_SOURCE = barebox-$$($(1)_VERSION).tar.gz
 else
 # Handle stable official Barebox versions
 $(1)_SOURCE = barebox-$$($(1)_VERSION).tar.bz2
--

2.20.1

#2 lore raw

PATCH 1/1 boot/barebox-aux: exclude git downloads from hash check

In reply to Yann E. MORIN
Quoted 27 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Yann" == Yann E MORIN <[email protected]> writes:

When barebox, and thus barebox-aux, are downloaded from a git tree, then barebox-aux download fails because a hash check is attempted on the downloaded archive:

Could not fetch special ref 'v2020.03.0'; assuming it is not special.
ERROR: No hash found for barebox-aux-v2020.03.0.tar.gz

This is because we only exclude from the check the archive of the bare barebox:

    BR_NO_CHECK_HASH_FOR += $(BAREBOX_SOURCE)

However, the default name of an archive is based on the package name, which for barebox-aux is not 'barebox'.

Since barebox-aux really uses the exact same source as the bare barebox, it should also share the archive name.

This has two direct consequences and advantages:

- the hash check is completely avoided for the barebox-aux archive;

- the barebox-aux archive is not downloaded as it is already downloaded for barebox.

Quoted 7 lines

---
Note: that last claim about the download being done only once requires that a previous patch be applied first (with typoes fixed):

    https://patchwork.ozlabs.org/patch/1258482/

Committed to 2019.02.x, 2019.11.x and 2020.02.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard