Skip to contentSkip to conversation

package/x11r7/xlib_libfontenc: add missing dependency on host-pkgconf

PATCH New Thomas Petazzoni 2 participants 3 messages Nov 13, 2018 – Nov 26, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/x11r7/xlib_libfontenc: add missing dependency on host-pkgconf

The xlib_libfontenc configure.ac uses PKG_CHECK_MODULES(), but the Buildroot package does not have a dependency on host-pkgconf. This causes a build failure with per-package host/target folders, or if one builds just with "make xlib_libfontenc", which is why it was never detected by the autobuilders.

---
 package/x11r7/xlib_libfontenc/xlib_libfontenc.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
package/x11r7/xlib_libfontenc/xlib_libfontenc.mk +2 -2
index 526aea9fe5..cb84ae4ee1 100644
@@ -10,8 +10,8 @@ XLIB_LIBFONTENC_SITE = http://xorg.freedesktop.org/releases/individual/lib
 XLIB_LIBFONTENC_LICENSE = MIT
 XLIB_LIBFONTENC_LICENSE_FILES = COPYING
 XLIB_LIBFONTENC_INSTALL_STAGING = YES
-XLIB_LIBFONTENC_DEPENDENCIES = zlib xorgproto
-HOST_XLIB_LIBFONTENC_DEPENDENCIES = host-zlib host-xorgproto
+XLIB_LIBFONTENC_DEPENDENCIES = zlib xorgproto host-pkgconf
+HOST_XLIB_LIBFONTENC_DEPENDENCIES = host-zlib host-xorgproto host-pkgconf
 
 $(eval $(autotools-package))
 $(eval $(host-autotools-package))
Signature · 1 line
2.19.1
#1 lore raw

PATCH 1/1 package/x11r7/xlib_libfontenc: add missing dependency on host-pkgconf

Quoted 9 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

The xlib_libfontenc configure.ac uses PKG_CHECK_MODULES(), but the Buildroot package does not have a dependency on host-pkgconf. This causes a build failure with per-package host/target folders, or if one builds just with "make xlib_libfontenc", which is why it was never detected by the autobuilders.

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#2 lore raw

PATCH 1/1 package/x11r7/xlib_libfontenc: add missing dependency on host-pkgconf

In reply to Thomas Petazzoni
Quoted 9 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

The xlib_libfontenc configure.ac uses PKG_CHECK_MODULES(), but the Buildroot package does not have a dependency on host-pkgconf. This causes a build failure with per-package host/target folders, or if one builds just with "make xlib_libfontenc", which is why it was never detected by the autobuilders.

Committed to 2018.02.x and 2018.08.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard