Skip to contentSkip to conversation

package/kyua: fix unmet dependencies

PATCH New Yann E. MORIN 2 participants 4 messages May 5, 2017 – May 15, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/kyua: fix unmet dependencies

lutok is a lua module, so it depends on ! static libs. However, the dependency is implicit, being done because the lua modules are sourced globally under an if-block, and thus it is not easy to find that dependency.

Propagate that dependency to kyua, which was missing it (because it is not a lua module, so was missing the dependency).

Cc Sebastien Bourdelin <[email protected]>
---
 package/kyua/Config.in | 1 +
 1 file changed, 1 insertion(+)
package/kyua/Config.in +1 -0
index 4f887b0e0a..6444b8c9e0 100644
@@ -3,6 +3,7 @@ config BR2_PACKAGE_KYUA
 	depends on BR2_INSTALL_LIBSTDCPP
 	depends on BR2_PACKAGE_HAS_LUAINTERPRETER # lutok
 	depends on !BR2_PACKAGE_LUAJIT # lutok
+	depends on !BR2_STATIC_LIBS # lutok
 	depends on BR2_USE_MMU # atf
 	select BR2_PACKAGE_ATF
 	select BR2_PACKAGE_LUTOK
Signature · 1 line
2.11.0
#1 lore raw

PATCH 1/1 package/kyua: fix unmet dependencies

S?bastien, All,

On 2017-05-05 21:08 +0200, Yann E. MORIN spake thusly:

Quoted 10 lines

lutok is a lua module, so it depends on ! static libs. However, the dependency is implicit, being done because the lua modules are sourced globally under an if-block, and thus it is not easy to find that dependency.

Propagate that dependency to kyua, which was missing it (because it is not a lua module, so was missing the dependency).

Cc Sebastien Bourdelin <[email protected]>

You can try on current master (cfe6112780):

    $ make KCONFIG_SEED=0x6DC29DCB randconfig
    warning: (BR2_PACKAGE_KYUA) selects BR2_PACKAGE_LUTOK which has
    unmet direct dependencies (BR2_PACKAGE_HAS_LUAINTERPRETER &&
    !BR2_STATIC_LIBS && BR2_INSTALL_LIBSTDCPP && !BR2_PACKAGE_LUAJIT)

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#2 lore raw

PATCH 1/1 package/kyua: fix unmet dependencies

In reply to Yann E. MORIN
Quoted 21 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Yann" == Yann E MORIN <[email protected]> writes:

lutok is a lua module, so it depends on ! static libs. However, the dependency is implicit, being done because the lua modules are sourced globally under an if-block, and thus it is not easy to find that dependency.

Propagate that dependency to kyua, which was missing it (because it is not a lua module, so was missing the dependency).

Cc Sebastien Bourdelin <[email protected]>
---
 package/kyua/Config.in | 1 +
 1 file changed, 1 insertion(+)
package/kyua/Config.in +0 -0
index 4f887b0e0a..6444b8c9e0 100644

package/kyua/Config.in config BR2_PACKAGE_KYUA · line 9

Quoted 7 lines
package/kyua/Config.in +1 -0
@@ -3,6 +3,7 @@ config BR2_PACKAGE_KYUA
 	depends on BR2_INSTALL_LIBSTDCPP
 	depends on BR2_PACKAGE_HAS_LUAINTERPRETER # lutok
 	depends on !BR2_PACKAGE_LUAJIT # lutok
+	depends on !BR2_STATIC_LIBS # lutok
 	depends on BR2_USE_MMU # atf
 	select BR2_PACKAGE_ATF
 	select BR2_PACKAGE_LUTOK

Committed after propagating this dependency to the toolchain comment as well, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#3 lore raw

PATCH 1/1 package/kyua: fix unmet dependencies

In reply to Yann E. MORIN
Quoted 7 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Yann" == Yann E MORIN <[email protected]> writes:

lutok is a lua module, so it depends on ! static libs. However, the dependency is implicit, being done because the lua modules are sourced globally under an if-block, and thus it is not easy to find that dependency.

Quoted 5 lines

Propagate that dependency to kyua, which was missing it (because it is not a lua module, so was missing the dependency).

Cc Sebastien Bourdelin <[email protected]>

Committed to 2017.02.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard