Skip to contentSkip to conversation

spi: pxa2xx: Add terminating entry for pxa2xx_spi_pci_compound_match

PATCH In review Axel Lin 4 participants 4 messages Aug 4, 2015 – Aug 5, 2015 2 messages not in the archive

Subsystems (3)
SPI PXA2xx/PXA3xx support Intel LPSS (Low Power SubSystem) drivers
lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 spi: pxa2xx: Add terminating entry for pxa2xx_spi_pci_compound_match

Signed-off-by Axel Lin <[email protected]>
---
 drivers/spi/spi-pxa2xx.c | 1 +
 1 file changed, 1 insertion(+)
drivers/spi/spi-pxa2xx.c +1 -0
index e924710..246ffab 100644
@@ -1300,6 +1300,7 @@ static const struct pci_device_id pxa2xx_spi_pci_compound_match[] = {
 	/* SPT-H */
 	{ PCI_VDEVICE(INTEL, 0xa129), LPSS_SPT_SSP },
 	{ PCI_VDEVICE(INTEL, 0xa12a), LPSS_SPT_SSP },
+	{ },
 };
 
 static bool pxa2xx_spi_idma_filter(struct dma_chan *chan, void *param)
Signature · 8 lines
2.1.0



--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): [email protected]

Acked-by
#2 lore raw
Quoted 10 lines · Axel Lin
Signed-off-by Axel Lin <[email protected]>
---
  drivers/spi/spi-pxa2xx.c | 1 +
  1 file changed, 1 insertion(+)
drivers/spi/spi-pxa2xx.c +0 -0
index e924710..246ffab 100644

drivers/spi/spi-pxa2xx.c static const struct pci_device_id pxa2xx_spi_pci_compound_match[] = { · line 1305

Quoted 6 lines
drivers/spi/spi-pxa2xx.c +1 -0
@@ -1300,6 +1300,7 @@ static const struct pci_device_id pxa2xx_spi_pci_compound_match[] = {
  	/* SPT-H */
  	{ PCI_VDEVICE(INTEL, 0xa129), LPSS_SPT_SSP },
  	{ PCI_VDEVICE(INTEL, 0xa12a), LPSS_SPT_SSP },
+	{ },
  };

Oops, thanks for noticing!

Acked-by Jarkko Nikula <jarkko.nikula-VuQAYsv1563Yd54FQh9/[email protected]>

--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): 55C05490.500-VuQAYsv1563Yd54FQh9/[email protected]

Acked-by
#4 lore raw
Quoted 2 lines · Jarkko Nikula
Quoted 1 line · Axel Lin
Signed-off-by Axel Lin <[email protected]>

I would have appreciated something in the git commit message, ie :
- a "Fixes" tag maybe
- a comment to describe how it was discovered : code reading, testing, etc ...

Quoted 1 line
Acked-by Jarkko Nikula <jarkko.nikula-VuQAYsv1563Yd54FQh9/[email protected]>

With a better commit message, please have my :

Acked-by Robert Jarzmik <[email protected]>

Cheers.

Signature · 5 lines
Robert
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#5 lore raw

Applied "spi: pxa2xx: Add terminating entry for pxa2xx_spi_pci_compound_match" to the spi tree

In reply to a message not in the archive

The patch

spi: pxa2xx: Add terminating entry for pxa2xx_spi_pci_compound_match

has been applied to the spi tree at

git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From 94e5c23d3c52f58f4051810a15aeacc085127ad1 Mon Sep 17 00:00:00 2001

From: Axel Lin <[email protected]>
Date: Tue, 4 Aug 2015 13:52:22 +0800
Subject: [PATCH] spi: pxa2xx: Add terminating entry for
pxa2xx_spi_pci_compound_match

Signed-off-by Axel Lin <[email protected]>
Acked-by Jarkko Nikula <jarkko.nikula-VuQAYsv1563Yd54FQh9/[email protected]>
Signed-off-by Mark Brown <[email protected]>
---
 drivers/spi/spi-pxa2xx.c | 1 +
 1 file changed, 1 insertion(+)
drivers/spi/spi-pxa2xx.c +1 -0
index e924710..246ffab 100644
@@ -1300,6 +1300,7 @@ static const struct pci_device_id pxa2xx_spi_pci_compound_match[] = {
 	/* SPT-H */
 	{ PCI_VDEVICE(INTEL, 0xa129), LPSS_SPT_SSP },
 	{ PCI_VDEVICE(INTEL, 0xa12a), LPSS_SPT_SSP },
+	{ },
 };
 
 static bool pxa2xx_spi_idma_filter(struct dma_chan *chan, void *param)
Signature · 6 lines
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html