Skip to contentSkip to conversation

uemacs doesn't clear ixon termios flag?

Buildroot Grant Edwards 2 participants 4 messages Apr 25, 2012 – May 1, 2012

lore
Share & tools
lore
#0 lore raw

I've enabled the uemacs package. It builds fine, but it doesn't seem to work unless you manually clear the termios ixon flag before running it. If you don't do that, the Ctrl-S keystroke isn't seen by uemacs -- instead it's intercepted by the tty layer and stops terminal output until you hit Ctrl-Q.

Has anybody else noticed this?

Signature · 4 lines
Grant Edwards               grant.b.edwards        Yow! My BIOLOGICAL ALARM
                                  at               CLOCK just went off ... It
                              gmail.com            has noiseless DOZE FUNCTION
                                                   and full kitchen!!
#1 lore raw
Quoted 5 lines · Grant Edwards

I've enabled the uemacs package. It builds fine, but it doesn't seem to work unless you manually clear the termios ixon flag before running it. If you don't do that, the Ctrl-S keystroke isn't seen by uemacs -- instead it's intercepted by the tty layer and stops terminal output until you hit Ctrl-Q.

This appears to be bug in uemacs that's been known about for several years. The fix below is from the busybox mailing list 3 years ago
http://lists.busybox.net/pipermail/busybox/2009-February/068304.html:

Or you could install this one:
ftp://ftp.kernel.org/pub/software/editors/uemacs/em-4.0.15-lt.tar.bz2 but beware that this version also has a problem with ^S/^Q because it doesn't clear IXON. You'll need the following patch before ^S/^Q will work at all:

02/01 13:32:12 renamed from 02/01 13:31:09 1.1 +1 -0
@@ -51,6 +51,7 @@
        /* raw CR/NL etc input handling, but keep ISTRIP if we're on a 7-bit line */
        ntermios.c_iflag &= ~(IGNBRK | BRKINT | IGNPAR | PARMRK
                              | INPCK | INLCR | IGNCR | ICRNL);
+       ntermios.c_iflag &= ~IXON;
 
        /* raw CR/NR etc output handling */
        ntermios.c_oflag &= ~(OPOST | ONLCR | OLCUC | OCRNL | ONOCR | ONLRET);

If I submitted a patch and a modified uemacs.mk would it likely be accepted?

Signature · 3 lines
Grant Edwards               grant.b.edwards        Yow! HELLO, everybody,
                                  at               I'm a HUMAN!!
                              gmail.com            
#2 lore raw
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Grant" == Grant Edwards <[email protected]> writes:

Hi,

Grant> This appears to be bug in uemacs that's been known about for Grant> several years. The fix below is from the busybox mailing list 3 Grant> years ago
Grant> http://lists.busybox.net/pipermail/busybox/2009-February/068304.html:

 Grant>   Or you could install this one:
 Grant>   ftp://ftp.kernel.org/pub/software/editors/uemacs/em-4.0.15-lt.tar.bz2
 Grant>   but beware that this version also has a problem with ^S/^Q because
 Grant>   it doesn't clear IXON.  You'll need the following patch before ^S/^Q
 Grant>   will work at all:

That's afaik the uemacs upstream we're using.

Grant> --- posix.c 2009/02/01 13:31:09 1.1
Grant> +++ posix.c 2009/02/01 13:32:12
Grant> @@ -51,6 +51,7 @@
Grant> /* raw CR/NL etc input handling, but keep ISTRIP if we're on a 7-bit line */
Grant> ntermios.c_iflag &= ~(IGNBRK | BRKINT | IGNPAR | PARMRK
Grant> | INPCK | INLCR | IGNCR | ICRNL);
Grant> + ntermios.c_iflag &= ~IXON;

Grant> /* raw CR/NR etc output handling */
Grant> ntermios.c_oflag &= ~(OPOST | ONLCR | OLCUC | OCRNL | ONOCR | ONLRET);

Grant> If I submitted a patch and a modified uemacs.mk would it likely be Grant> accepted?

Sure! Notice that I recently converted the uemacs package to gentargets, but it should be functionally equivalent.

Signature · 1 line
Bye, Peter Korsgaard
#3 lore raw
Quoted 6 lines · Peter Korsgaard
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Grant" == Grant Edwards <[email protected]> writes:

Grant> This appears to be bug in uemacs that's been known about for Grant> several years. The fix below is from the busybox mailing list 3 Grant> years ago
Grant> http://lists.busybox.net/pipermail/busybox/2009-February/068304.html:

[...]

Quoted 1 line

That's afaik the uemacs upstream we're using.

That's what I thought. I haven't looked into why upstream has been ignoring the bug fix, but it seemed to be rather widely known.

Quoted 5 lines

Grant> If I submitted a patch and a modified uemacs.mk would it likely be Grant> accepted?

Sure! Notice that I recently converted the uemacs package to gentargets, but it should be functionally equivalent.

Cool. I submitted the patch a few days ago:

https://bugs.busybox.net/show_bug.cgi?id=5144

I think the patch should work both pre and post gentargets conversion. All it does is create a new patch file in the package directory. It doesn't touch any existing files. As long as the gentargets call applies all of the *.patch files in alphabetical order it should "just work".

I can stumble along with either vi or nano, but it requires too much concentration...

Signature · 3 lines
Grant Edwards               grant.b.edwards        Yow! I joined scientology
                                  at               at a garage sale!!
                              gmail.com