Skip to contentSkip to conversation

ARM: OMAP: Overo: remove illegal extra call to overo_ads7846_init()

PATCH New Daniel Mack 3 participants 5 messages Jun 17, 2011 – Jul 1, 2011

Subsystems (3)
Arm (32-bit) Arm sub-architectures OMAP2+ support
lore
Share & tools
lore

Daniel Mack

author
#0 lore raw

PATCH 1/1 ARM: OMAP: Overo: remove illegal extra call to overo_ads7846_init()

Signed-off-by Daniel Mack <[email protected]>
---
 arch/arm/mach-omap2/board-overo.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
arch/arm/mach-omap2/board-overo.c +0 -1
index 175e1ab..110475f 100644
@@ -568,7 +568,6 @@ static void __init overo_init(void)
 	usb_musb_init(NULL);
 	usbhs_init(&usbhs_bdata);
 	overo_spi_init();
-	overo_ads7846_init();
 	overo_init_smsc911x();
 	overo_display_init();
 	overo_init_led();
Signature · 1 line
1.7.5.1
#1 lore raw

PATCH 1/1 ARM: OMAP: Overo: remove illegal extra call to overo_ads7846_init()

Quoted 1 line · Daniel Mack
Signed-off-by Daniel Mack <[email protected]>

Thanks for fixing this, I noticed this recently too.

Please add a descriptive changelog. For example, why is it duplcate? where is it already done? what commit added the extra call, what problems does it cause, etc.

Also, your subject says 'illegal', but it's not really illegal. It's just
wrong. :) "remove duplcate call to..." is enough.

Thanks,

Kevin

Quoted 16 lines
---
 arch/arm/mach-omap2/board-overo.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
arch/arm/mach-omap2/board-overo.c +0 -1
index 175e1ab..110475f 100644
@@ -568,7 +568,6 @@ static void __init overo_init(void)
 	usb_musb_init(NULL);
 	usbhs_init(&usbhs_bdata);
 	overo_spi_init();
-	overo_ads7846_init();
 	overo_init_smsc911x();
 	overo_display_init();
 	overo_init_led();
author
#2 lore raw

PATCH 1/1 ARM: OMAP: Overo: remove duplicate call to overo_ads7846_init()

overo_ads7846_init() is already called from overo_spi_init(), and calling it twice is not only unnecessary but causes a warning as "reg-fixed-voltage.1" is already added to the device tree.

Signed-off-by Daniel Mack <[email protected]>
---
 arch/arm/mach-omap2/board-overo.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
arch/arm/mach-omap2/board-overo.c +0 -1
index 175e1ab..110475f 100644
@@ -568,7 +568,6 @@ static void __init overo_init(void)
 	usb_musb_init(NULL);
 	usbhs_init(&usbhs_bdata);
 	overo_spi_init();
-	overo_ads7846_init();
 	overo_init_smsc911x();
 	overo_display_init();
 	overo_init_led();
Signature · 1 line
1.7.5.1
#3 lore raw

PATCH 1/1 ARM: OMAP: Overo: remove duplicate call to overo_ads7846_init()

Quoted 3 lines · Daniel Mack

overo_ads7846_init() is already called from overo_spi_init(), and calling it twice is not only unnecessary but causes a warning as "reg-fixed-voltage.1" is already added to the device tree.

Excellent, thanks!

Quoted 1 line
Signed-off-by Daniel Mack <[email protected]>
Tested-by Kevin Hilman <[email protected]>
maintainer
#4 lore raw

PATCH 1/1 ARM: OMAP: Overo: remove duplicate call to overo_ads7846_init()

Quoted 6 lines · Kevin Hilman
Quoted 3 lines · Daniel Mack

overo_ads7846_init() is already called from overo_spi_init(), and calling it twice is not only unnecessary but causes a warning as "reg-fixed-voltage.1" is already added to the device tree.

Quoted 6 lines

Excellent, thanks!

Quoted 1 line
Signed-off-by Daniel Mack <[email protected]>
Tested-by Kevin Hilman <[email protected]>

Applying into devel-fixes.

Tony