Skip to contentSkip to conversation

GStreamer patches, and TI OMAP3 DSP stuff

PATCH RESEND New Felipe Contreras 4 participants 23 messages Jan 23, 2011 – Jan 25, 2011

lore
Share & tools
lore
#0 lore raw

cover GStreamer patches, and TI OMAP3 DSP stuff

Hi,

I haven't received any comments on the previous 2 tries (except the ack from Thomas Petazzoni), so I'm resending yet again.

These patches first improve GStreamer support (makes it build on newer versions of make), remove unnecessary dependencies, and then add support for gst-dsp and all the dependencies.

By applying these, it's possible to use TI OMAP3 hardware accelerated codecs right away, no patches needed on the kernel.

I tried these with linux 2.6.37 on an N900.

Felipe Contreras (6):
gstreamer: remove unnecessary feature
Fix gstreamer packages for make 3.82
Add tidsp-binaries package
Add gst-dsp package
Add dsp-tools package
Add gst-omapfb package

 package/Config.in                                  |    1 +
 package/dsp-tools/Config.in                        |    7 +++++++
 package/dsp-tools/dsp-tools.mk                     |   13 +++++++++++++
 package/multimedia/Config.in                       |    3 +++
 package/multimedia/gst-dsp/Config.in               |    8 ++++++++
 package/multimedia/gst-dsp/gst-dsp.mk              |   15 +++++++++++++++
 package/multimedia/gst-ffmpeg/gst-ffmpeg.mk        |    2 ++
 package/multimedia/gst-omapfb/Config.in            |    7 +++++++
 package/multimedia/gst-omapfb/gst-omapfb.mk        |   15 +++++++++++++++
 .../multimedia/gst-plugins-bad/gst-plugins-bad.mk  |    2 ++
 .../gst-plugins-base/gst-plugins-base.mk           |    2 ++
 .../gst-plugins-good/gst-plugins-good.mk           |    2 ++
 .../gst-plugins-ugly/gst-plugins-ugly.mk           |    2 ++
 package/multimedia/gstreamer/Config.in             |    6 ------
 package/multimedia/gstreamer/gstreamer.mk          |   15 ++++++++-------
 package/multimedia/tidsp-binaries/Config.in        |    6 ++++++
 .../multimedia/tidsp-binaries/tidsp-binaries.mk    |    9 +++++++++
 17 files changed, 102 insertions(+), 13 deletions(-)
 create mode 100644 package/dsp-tools/Config.in
 create mode 100644 package/dsp-tools/dsp-tools.mk
 create mode 100644 package/multimedia/gst-dsp/Config.in
 create mode 100644 package/multimedia/gst-dsp/gst-dsp.mk
 create mode 100644 package/multimedia/gst-omapfb/Config.in
 create mode 100644 package/multimedia/gst-omapfb/gst-omapfb.mk
 create mode 100644 package/multimedia/tidsp-binaries/Config.in
 create mode 100644 package/multimedia/tidsp-binaries/tidsp-binaries.mk
Signature · 1 line
1.7.4.rc2
#1 lore raw

PATCH RESEND 1/6 gstreamer: remove unnecessary feature

On 0.10.11 the binary-registry was added, on 0.10.12 the libxml2 dependency was dropped when binary-registry was used, on 0.10.18 the binary-registry was made default, and on 0.10.23 it was the only option.

So, libxml2 is not needed any more for the registry.

---
 package/multimedia/gstreamer/Config.in    |    6 ------
 package/multimedia/gstreamer/gstreamer.mk |   10 ++--------
 2 files changed, 2 insertions(+), 14 deletions(-)
package/multimedia/gstreamer/Config.in +0 -6
index a3ce859..7de904c 100644
@@ -9,9 +9,3 @@ config BR2_PACKAGE_GSTREAMER
 
 comment "gstreamer requires a toolchain with WCHAR support"
 	depends on !BR2_USE_WCHAR
-
-config BR2_PACKAGE_GSTREAMER_LIBXML2
-	bool "require libxml2 for registry and load/save"
-	default y
-	select BR2_PACKAGE_LIBXML2
-	depends on BR2_PACKAGE_GSTREAMER
package/multimedia/gstreamer/gstreamer.mk +2 -8
index 49ac0df..d689619 100644
@@ -19,15 +19,9 @@ endif
 GSTREAMER_CONF_OPT = \
 		--disable-examples \
 		--disable-tests \
-		--disable-failing-tests
+		--disable-failing-tests \
+		--disable-loadsave
 
 GSTREAMER_DEPENDENCIES = libglib2 host-pkg-config
 
-ifeq ($(BR2_PACKAGE_GSTREAMER_LIBXML2),y)
-GSTREAMER_DEPENDENCIES += libxml2
-else
-GSTREAMER_CONF_OPT += \
-	--disable-loadsave
-endif
-
 $(eval $(call AUTOTARGETS,package/multimedia,gstreamer))
Signature · 1 line
1.7.4.rc2
#2 lore raw

PATCH RESEND 1/6 gstreamer: remove unnecessary feature

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Felipe" == Felipe Contreras <[email protected]> writes:

Felipe> On 0.10.11 the binary-registry was added, on 0.10.12 the Felipe> libxml2 dependency was dropped when binary-registry was used, Felipe> on 0.10.18 the binary-registry was made default, and on 0.10.23 Felipe> it was the only option.

Felipe> So, libxml2 is not needed any more for the registry.

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#3 lore raw

PATCH RESEND 2/6 Fix gstreamer packages for make 3.82

In reply to Felipe Contreras

These packages would get fixed on the next releases, but each one gets released at different periods. For now this is needed to build on 3.82.

I only tested gstreamer, gst-plugins-base, and gst-plugins-good, but all the ones using the 'common' submodule should have this issue.

---
 package/multimedia/gst-ffmpeg/gst-ffmpeg.mk        |    2 ++
 .../multimedia/gst-plugins-bad/gst-plugins-bad.mk  |    2 ++
 .../gst-plugins-base/gst-plugins-base.mk           |    2 ++
 .../gst-plugins-good/gst-plugins-good.mk           |    2 ++
 .../gst-plugins-ugly/gst-plugins-ugly.mk           |    2 ++
 package/multimedia/gstreamer/gstreamer.mk          |    7 +++++++
 6 files changed, 17 insertions(+), 0 deletions(-)
package/multimedia/gst-ffmpeg/gst-ffmpeg.mk +2 -0
index 557c146..8b9ddb6 100644
@@ -15,4 +15,6 @@ ifeq ($(BR2_PACKAGE_BZIP2),y)
 GST_FFMPEG_DEPENDENCIES += bzip2
 endif
 
+GST_FFMPEG_POST_EXTRACT_HOOKS += GSTREAMER_FIX_MAKE
+
 $(eval $(call AUTOTARGETS,package/multimedia,gst-ffmpeg))
package/multimedia/gst-plugins-bad/gst-plugins-bad.mk +2 -0
index 7a059c1..db35440 100644
@@ -368,4 +368,6 @@ else
 GST_PLUGINS_BAD_CONF_OPT += --disable-vcd
 endif
 
+GST_PLUGINS_BAD_POST_EXTRACT_HOOKS += GSTREAMER_FIX_MAKE
+
 $(eval $(call AUTOTARGETS,package/multimedia,gst-plugins-bad))
package/multimedia/gst-plugins-base/gst-plugins-base.mk +2 -0
index e91d5fc..e8e9407 100644
@@ -158,4 +158,6 @@ else
 GST_PLUGINS_BASE_CONF_OPT += --disable-vorbis
 endif
 
+GST_PLUGINS_BASE_POST_EXTRACT_HOOKS += GSTREAMER_FIX_MAKE
+
 $(eval $(call AUTOTARGETS,package/multimedia,gst-plugins-base))
package/multimedia/gst-plugins-good/gst-plugins-good.mk +2 -0
index f7a2087..33284a9 100644
@@ -336,4 +336,6 @@ else
 GST_PLUGINS_GOOD_CONF_OPT += --disable-speex
 endif
 
+GST_PLUGINS_GOOD_POST_EXTRACT_HOOKS += GSTREAMER_FIX_MAKE
+
 $(eval $(call AUTOTARGETS,package/multimedia,gst-plugins-good))
package/multimedia/gst-plugins-ugly/gst-plugins-ugly.mk +2 -0
index fc2fcff..1540a55 100644
@@ -82,4 +82,6 @@ else
 GST_PLUGINS_UGLY_CONF_OPT += --disable-mpeg2dec
 endif
 
+GST_PLUGINS_UGLY_POST_EXTRACT_HOOKS += GSTREAMER_FIX_MAKE
+
 $(eval $(call AUTOTARGETS,package/multimedia,gst-plugins-ugly))
package/multimedia/gstreamer/gstreamer.mk +7 -0
index d689619..9801e16 100644
@@ -24,4 +24,11 @@ GSTREAMER_CONF_OPT = \
 
 GSTREAMER_DEPENDENCIES = libglib2 host-pkg-config
 
+define GSTREAMER_FIX_MAKE
+	$(SED) 's/^        \(-gtkdoc\)/	\1/' `find $(@D)/docs -name Makefile.in`
+endef
+
+# should be fixed on 0.10.31
+GSTREAMER_POST_EXTRACT_HOOKS += GSTREAMER_FIX_MAKE
+
 $(eval $(call AUTOTARGETS,package/multimedia,gstreamer))
Signature · 1 line
1.7.4.rc2
#4 lore raw

PATCH RESEND 2/6 Fix gstreamer packages for make 3.82

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Felipe" == Felipe Contreras <[email protected]> writes:

Felipe> These packages would get fixed on the next releases, but each one gets Felipe> released at different periods. For now this is needed to build on 3.82.

Felipe> I only tested gstreamer, gst-plugins-base, and Felipe> gst-plugins-good, but all the ones using the 'common' submodule Felipe> should have this issue.

There recently were a number of new gst-* releases. I took a quick look at gst-plugins-base-0.10.32, an no longer see that gtkdoc line. Wouldn't it make more sense to update now instead of adding this hack?

Signature · 1 line
Bye, Peter Korsgaard
#5 lore raw

PATCH RESEND 2/6 Fix gstreamer packages for make 3.82

Hi,

Quoted 5 lines · Peter Korsgaard
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Felipe" == Felipe Contreras <[email protected]> writes:

?Felipe> These packages would get fixed on the next releases, but each one gets ?Felipe> released at different periods. For now this is needed to build on 3.82.

Quoted 7 lines

?Felipe> I only tested gstreamer, gst-plugins-base, and ?Felipe> gst-plugins-good, but all the ones using the 'common' submodule ?Felipe> should have this issue.

There recently were a number of new gst-* releases. I took a quick look at gst-plugins-base-0.10.32, an no longer see that gtkdoc line. Wouldn't it make more sense to update now instead of adding this hack?

Well, _some_ packages have been released: gstreamer core, plugins base, good, bad and ugly, in short, I think everything except gst-ffmpeg. And yeah, this is the "next release" I was talking about, so it might make sense to jump to this release (if it compiles), but I'm not sure if the hack would still be needed for some packages.

Cheers.

Signature · 1 line
Felipe Contreras
#6 lore raw

PATCH RESEND 2/6 Fix gstreamer packages for make 3.82

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Felipe" == Felipe Contreras <[email protected]> writes:

Hi,

Quoted 3 lines
Quoted 3 lines

There recently were a number of new gst-* releases. I took a quick look at gst-plugins-base-0.10.32, an no longer see that gtkdoc line. Wouldn't it make more sense to update now instead of adding this hack?

Felipe> Well, _some_ packages have been released: gstreamer core, Felipe> plugins base, good, bad and ugly, in short, I think everything Felipe> except gst-ffmpeg. And yeah, this is the "next release" I was Felipe> talking about, so it might make sense to jump to this release Felipe> (if it compiles), but I'm not sure if the hack would still be Felipe> needed for some packages.

Could you give it a try? The dist I'm using is still at make-3.81.

Signature · 1 line
Bye, Peter Korsgaard
#7 lore raw

PATCH RESEND 3/6 Add tidsp-binaries package

In reply to Felipe Contreras
---
 package/multimedia/Config.in                       |    1 +
 package/multimedia/tidsp-binaries/Config.in        |    6 ++++++
 .../multimedia/tidsp-binaries/tidsp-binaries.mk    |    9 +++++++++
 3 files changed, 16 insertions(+), 0 deletions(-)
 create mode 100644 package/multimedia/tidsp-binaries/Config.in
 create mode 100644 package/multimedia/tidsp-binaries/tidsp-binaries.mk
package/multimedia/Config.in +1 -0
index da50dbb..8a251fb 100644
@@ -27,6 +27,7 @@ source "package/multimedia/mpg123/Config.in"
 source "package/multimedia/mplayer/Config.in"
 source "package/multimedia/speex/Config.in"
 source "package/multimedia/swfdec/Config.in"
+source "package/multimedia/tidsp-binaries/Config.in"
 source "package/multimedia/festival/Config.in"
 source "package/multimedia/taglib/Config.in"
 source "package/multimedia/tremor/Config.in"
package/multimedia/tidsp-binaries/Config.in new file +6 -0
new file mode 100644
index 0000000..2d50b62
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_TIDSP_BINARIES
+	bool "tidsp-binaries"
+	help
+	  TI OMAP3 DSP algorithms.
+
+	  https://gforge.ti.com/gf/project/openmax/
package/multimedia/tidsp-binaries/tidsp-binaries.mk new file +9 -0
new file mode 100644
index 0000000..5dc9205
@@ -0,0 +1,9 @@
+TIDSP_BINARIES_VERSION=23.i3.8
+TIDSP_BINARIES_SOURCE=tidsp-binaries-$(TIDSP_BINARIES_VERSION).tar.gz
+TIDSP_BINARIES_SITE:=http://gst-dsp.googlecode.com/files/
+
+define TIDSP_BINARIES_INSTALL_TARGET_CMDS
+	$(MAKE) -C $(@D) -e DESTDIR=$(TARGET_DIR) install
+endef
+
+$(eval $(call GENTARGETS,package/multimedia,tidsp-binaries))
Signature · 1 line
1.7.4.rc2
#8 lore raw

PATCH RESEND 3/6 Add tidsp-binaries package

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Felipe" == Felipe Contreras <[email protected]> writes:

Hi,

Felipe> +++ b/package/multimedia/tidsp-binaries/Config.in Felipe> @@ -0,0 +1,6 @@
Felipe> +config BR2_PACKAGE_TIDSP_BINARIES
Felipe> + bool "tidsp-binaries"
Felipe> + help
Felipe> + TI OMAP3 DSP algorithms.
Felipe> +
Felipe> + https://gforge.ti.com/gf/project/openmax/

This only ever makes sense on ARM, so it should probably have a depends on BR2_arm (and possible || BR2_armeb if that is possible with this)

Felipe> +++ b/package/multimedia/tidsp-binaries/tidsp-binaries.mk Felipe> @@ -0,0 +1,9 @@
Felipe> +TIDSP_BINARIES_VERSION=23.i3.8
Felipe> +TIDSP_BINARIES_SOURCE=tidsp-binaries-$(TIDSP_BINARIES_VERSION).tar.gz Felipe> +TIDSP_BINARIES_SITE:=http://gst-dsp.googlecode.com/files/ Felipe> +
Felipe> +define TIDSP_BINARIES_INSTALL_TARGET_CMDS
Felipe> + $(MAKE) -C $(@D) -e DESTDIR=$(TARGET_DIR) install
Felipe> +endef
Felipe> +

Please add an uninstall target as well.

Signature · 1 line
Bye, Peter Korsgaard
#9 lore raw

PATCH RESEND 4/6 Add gst-dsp package

In reply to Felipe Contreras
---
 package/multimedia/Config.in          |    1 +
 package/multimedia/gst-dsp/Config.in  |    8 ++++++++
 package/multimedia/gst-dsp/gst-dsp.mk |   15 +++++++++++++++
 3 files changed, 24 insertions(+), 0 deletions(-)
 create mode 100644 package/multimedia/gst-dsp/Config.in
 create mode 100644 package/multimedia/gst-dsp/gst-dsp.mk
package/multimedia/Config.in +1 -0
index 8a251fb..7590219 100644
@@ -6,6 +6,7 @@ source "package/multimedia/flac/Config.in"
 source "package/multimedia/ffmpeg/Config.in"
 source "package/multimedia/gstreamer/Config.in"
 source "package/multimedia/gst-ffmpeg/Config.in"
+source "package/multimedia/gst-dsp/Config.in"
 source "package/multimedia/gst-plugins-base/Config.in"
 source "package/multimedia/gst-plugins-good/Config.in"
 source "package/multimedia/gst-plugins-bad/Config.in"
package/multimedia/gst-dsp/Config.in new file +8 -0
new file mode 100644
index 0000000..c4d1033
@@ -0,0 +1,8 @@
+config BR2_PACKAGE_GST_DSP
+	bool "gst-dsp"
+	depends on BR2_PACKAGE_GSTREAMER
+	select BR2_PACKAGE_TIDSP_BINARIES
+	help
+	  GStreamer plug-in to access TI OMAP3 DSP algorithms.
+
+	  http://code.google.com/p/gst-dsp/
package/multimedia/gst-dsp/gst-dsp.mk new file +15 -0
new file mode 100644
index 0000000..12ca5d8
@@ -0,0 +1,15 @@
+GST_DSP_VERSION=0.8.0
+GST_DSP_SOURCE=gst-dsp-$(GST_DSP_VERSION).tar.gz
+GST_DSP_SITE=http://gst-dsp.googlecode.com/files/
+
+define GST_DSP_BUILD_CMDS
+	$(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) -e
+endef
+
+define GST_DSP_INSTALL_TARGET_CMDS
+	$(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) -e DESTDIR=$(TARGET_DIR) install
+endef
+
+GST_DSP_DEPENDENCIES = gstreamer
+
+$(eval $(call GENTARGETS,package/multimedia,gst-dsp))
Signature · 1 line
1.7.4.rc2
#10 lore raw

PATCH RESEND 4/6 Add gst-dsp package

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Felipe" == Felipe Contreras <[email protected]> writes:

Felipe> Signed-off-by: Felipe Contreras <[email protected]> Felipe> Acked-by: Thomas Petazzoni <[email protected]>

Same comments as for tidsp-bridge.

Signature · 1 line
Bye, Peter Korsgaard
#11 lore raw

PATCH RESEND 5/6 Add dsp-tools package

In reply to Felipe Contreras
---
 package/Config.in              |    1 +
 package/dsp-tools/Config.in    |    7 +++++++
 package/dsp-tools/dsp-tools.mk |   13 +++++++++++++
 3 files changed, 21 insertions(+), 0 deletions(-)
 create mode 100644 package/dsp-tools/Config.in
 create mode 100644 package/dsp-tools/dsp-tools.mk
package/Config.in +1 -0
index da5b62b..f9e1568 100644
@@ -478,6 +478,7 @@ source "package/sysklogd/Config.in"
 source "package/sysvinit/Config.in"
 source "package/util-linux/Config.in"
 endif
+source "package/dsp-tools/Config.in"
 endmenu
 
 menu "Text editors and viewers"
package/dsp-tools/Config.in new file +7 -0
new file mode 100644
index 0000000..c37d76c
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_DSP_TOOLS
+	bool "dsp-tools"
+	select BR2_PACKAGE_TIDSP_BINARIES
+	help
+	  Utilities for TI OMAP3 DSP.
+
+	  http://github.com/felipec/dsp-tools
package/dsp-tools/dsp-tools.mk new file +13 -0
new file mode 100644
index 0000000..39d11d6
@@ -0,0 +1,13 @@
+DSP_TOOLS_VERSION=2.0
+DSP_TOOLS_SOURCE=dsp-tools-$(DSP_TOOLS_VERSION).tar.gz
+DSP_TOOLS_SITE=http://gst-dsp.googlecode.com/files/
+
+define DSP_TOOLS_BUILD_CMDS
+	$(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) -e
+endef
+
+define DSP_TOOLS_INSTALL_TARGET_CMDS
+	$(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) -e DESTDIR=$(TARGET_DIR) install
+endef
+
+$(eval $(call GENTARGETS,package,dsp-tools))
Signature · 1 line
1.7.4.rc2
#13 lore raw

PATCH RESEND 6/6 Add gst-omapfb package

In reply to Felipe Contreras
---
 package/multimedia/Config.in                |    1 +
 package/multimedia/gst-omapfb/Config.in     |    7 +++++++
 package/multimedia/gst-omapfb/gst-omapfb.mk |   15 +++++++++++++++
 3 files changed, 23 insertions(+), 0 deletions(-)
 create mode 100644 package/multimedia/gst-omapfb/Config.in
 create mode 100644 package/multimedia/gst-omapfb/gst-omapfb.mk
package/multimedia/Config.in +1 -0
index 7590219..8c50c5c 100644
@@ -7,6 +7,7 @@ source "package/multimedia/ffmpeg/Config.in"
 source "package/multimedia/gstreamer/Config.in"
 source "package/multimedia/gst-ffmpeg/Config.in"
 source "package/multimedia/gst-dsp/Config.in"
+source "package/multimedia/gst-omapfb/Config.in"
 source "package/multimedia/gst-plugins-base/Config.in"
 source "package/multimedia/gst-plugins-good/Config.in"
 source "package/multimedia/gst-plugins-bad/Config.in"
package/multimedia/gst-omapfb/Config.in new file +7 -0
new file mode 100644
index 0000000..e4a62c0
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_GST_OMAPFB
+	bool "gst-omapfb"
+	depends on BR2_PACKAGE_GSTREAMER
+	help
+	  GStreamer plug-in to use OMAP framebuffer.
+
+	  http://github.com/felipec/gst-omapfb
package/multimedia/gst-omapfb/gst-omapfb.mk new file +15 -0
new file mode 100644
index 0000000..e370c4e
@@ -0,0 +1,15 @@
+GST_OMAPFB_VERSION=1.0
+GST_OMAPFB_SOURCE=gst-omapfb-$(GST_OMAPFB_VERSION).tar.gz
+GST_OMAPFB_SITE=http://gst-dsp.googlecode.com/files/
+
+define GST_OMAPFB_BUILD_CMDS
+	$(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) -e
+endef
+
+define GST_OMAPFB_INSTALL_TARGET_CMDS
+	$(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) -e DESTDIR=$(TARGET_DIR) install
+endef
+
+GST_OMAPFB_DEPENDENCIES = gstreamer
+
+$(eval $(call GENTARGETS,package/multimedia,gst-omapfb))
Signature · 1 line
1.7.4.rc2
#14 lore raw

PATCH RESEND 6/6 Add gst-omapfb package

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Felipe" == Felipe Contreras <[email protected]> writes:

Felipe> Signed-off-by: Felipe Contreras <[email protected]> Felipe> Acked-by: Thomas Petazzoni <[email protected]>

And here.

Thinking a bit more about it - For the omap3 stuff, they are all with A8 cores, so we could even do 'depends on BR2_cortex_a8', right?

Felipe> diff --git a/package/multimedia/gst-omapfb/Config.in b/package/multimedia/gst-omapfb/Config.in Felipe> new file mode 100644
Felipe> index 0000000..e4a62c0
Felipe> --- /dev/null
Felipe> +++ b/package/multimedia/gst-omapfb/Config.in
Felipe> @@ -0,0 +1,7 @@
Felipe> +config BR2_PACKAGE_GST_OMAPFB
Felipe> + bool "gst-omapfb"
Felipe> + depends on BR2_PACKAGE_GSTREAMER
Felipe> + help
Felipe> + GStreamer plug-in to use OMAP framebuffer.

Is this omap3 specific like the rest, or would it also work on E.G. the pandaboard?

Signature · 1 line
Bye, Peter Korsgaard
#15 lore raw

[Buildroot] ARM cores

Hello,

Quoted 2 lines · On Mon, 24 Jan 2011 09:58:21 +0100 Peter Korsgaard <[email protected]> wrote:

Thinking a bit more about it - For the omap3 stuff, they are all with A8 cores, so we could even do 'depends on BR2_cortex_a8', right?

Besides those OMAP-specific packages, there are also other packages that could depend on CPU-specific features.

For example, some video decoders have specific code to use NEON instructions, but those instructions are not available on Cortex-A8 cores for example.

Should we go all the way down to specifying the particular CPU the user is going to use (OMAP3, OMAP4, etc.) and then select the appropriate mtune/march according to this, show/hide packages according to this, and tune specifically some packages according to this ?

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#16 lore raw

[Buildroot] ARM cores

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Hi,

Quoted 2 lines
Quoted 2 lines

Thinking a bit more about it - For the omap3 stuff, they are all with A8 cores, so we could even do 'depends on BR2_cortex_a8', right?

Thomas> Besides those OMAP-specific packages, there are also other packages Thomas> that could depend on CPU-specific features.

Thomas> For example, some video decoders have specific code to use NEON Thomas> instructions, but those instructions are not available on Cortex-A8 Thomas> cores for example.

Not available? Doesn't almost all A8 implementations have NEON? Do we have any packages that cannot work on !NEON arms? (E.G. where it isn't just an optimization)

Thomas> Should we go all the way down to specifying the particular CPU Thomas> the user is going to use (OMAP3, OMAP4, etc.) and then select Thomas> the appropriate mtune/march according to this, show/hide Thomas> packages according to this, and tune specifically some packages Thomas> according to this ?

That would imho be a lot of work to keep uptodate with the maze of ARM SoCs available.

I think a few defconfigs for commonly used boards would be good enough.

Signature · 1 line
Bye, Peter Korsgaard
#17 lore raw

[Buildroot] ARM cores

Quoted 1 line · On Mon, 24 Jan 2011 17:03:00 +0100 Peter Korsgaard <[email protected]> wrote:

Not available? Doesn't almost all A8 implementations have NEON?

According to http://wiki.debian.org/ArmHardFloatPort, CPUs such as Marvell Dove and Nvidia Tegra 2 are ARMv7 CPUs, but they don't have NEON support. NEON is an extension, so it isn't necessarly part of ARM cores.

Quoted 2 lines

Do we have any packages that cannot work on !NEON arms? (E.G. where it isn't just an optimization)

In mplayer, we have:

ifeq ($(call qstrip,$(BR2_GCC_TARGET_ARCH)),armv7-a) MPLAYER_CONF_OPTS += --enable-neon
endif

(This is code that I added, it's an approximation, since as said above, not all ARMv7 CPUs have NEON support).

Once mplayer is compiled with --enable-neon, it will presumably not work on !NEON arms.

Instead of having the list of gazillions ARM SoC, we could also extend a bit our architecture-specific options:

* Has NEON support ?
shown only if > ARMv7 is selected

* Floating point type (with a choice of soft-float, VFPv2, VFPv3)

* Floating point ABI (soft, softfp, hard)

But it means that the user needs more knowledge on the details of the ARM SoC he is using. But it's probably the only realistic solution.

Regards,

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#18 lore raw

[Buildroot] ARM cores

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Hi,

Thomas> Instead of having the list of gazillions ARM SoC, we could also Thomas> extend a bit our architecture-specific options:

Thomas> * Has NEON support ?
Thomas> shown only if > ARMv7 is selected

Thomas> * Floating point type (with a choice of soft-float, VFPv2, VFPv3)

Thomas> * Floating point ABI (soft, softfp, hard)

Thomas> But it means that the user needs more knowledge on the details of the Thomas> ARM SoC he is using. But it's probably the only realistic solution.

Yes, agreed.

Signature · 1 line
Bye, Peter Korsgaard
#20 lore raw

[Buildroot] ARM cores

Quoted 4 lines · On Mon, 24 Jan 2011 17:08:49 +0100 Eric BENARD <[email protected]> wrote:

NEON (and VFP) is a feature of cortex A8 :
http://www.arm.com/products/processors/cortex-a/cortex-a8.php

It's optional on A5 & A9 but not on A8.

Yes, sorry. I've given the example of Marvell Dove and Nvidia Tegra 2, which presumably are Cortex-A9. But it doesn't change my initial
comment: if the user says "I'm using Cortex A9", it's not enough to decide whether you can use NEON or not.

Regards,

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#21 lore raw

PATCH RESEND 6/6 Add gst-omapfb package

In reply to Peter Korsgaard
Quoted 6 lines · Peter Korsgaard
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Felipe" == Felipe Contreras <[email protected]> writes:

?Felipe> Signed-off-by: Felipe Contreras <[email protected]> ?Felipe> Acked-by: Thomas Petazzoni <[email protected]>

And here.

Well, there's no 'uninstall' in upstream. Should I add a patch to the Makefile, or shall I manually remove the files (in gst-dsp and gst-omapfb it's just one file, and in the other packages there are very few).

Quoted 2 lines

Thinking a bit more about it - For the omap3 stuff, they are all with A8 cores, so we could even do 'depends on BR2_cortex_a8', right?

I guess so.

Quoted 12 lines

?Felipe> diff --git a/package/multimedia/gst-omapfb/Config.in b/package/multimedia/gst-omapfb/Config.in ?Felipe> new file mode 100644
?Felipe> index 0000000..e4a62c0
?Felipe> --- /dev/null
?Felipe> +++ b/package/multimedia/gst-omapfb/Config.in
?Felipe> @@ -0,0 +1,7 @@
?Felipe> +config BR2_PACKAGE_GST_OMAPFB
?Felipe> + ? ? ?bool "gst-omapfb"
?Felipe> + ? ? ?depends on BR2_PACKAGE_GSTREAMER
?Felipe> + ? ? ?help
?Felipe> + ? ? ? ?GStreamer plug-in to use OMAP framebuffer.

Quoted 2 lines

Is this omap3 specific like the rest, or would it also work on E.G. the pandaboard?

That's a good question. I don't think the OMAP4 display sub-system works right now, so it's hard to tell, but in theory it should work.

Cheers.

Signature · 1 line
Felipe Contreras
#22 lore raw

PATCH RESEND 6/6 Add gst-omapfb package

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Felipe" == Felipe Contreras <[email protected]> writes:

Quoted 6 lines · Peter Korsgaard
Quoted 6 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Felipe" == Felipe Contreras <[email protected]> writes:

?Felipe> Signed-off-by: Felipe Contreras <[email protected]> ?Felipe> Acked-by: Thomas Petazzoni <[email protected]>

And here.

Felipe> Well, there's no 'uninstall' in upstream. Should I add a patch to the Felipe> Makefile, or shall I manually remove the files (in gst-dsp and Felipe> gst-omapfb it's just one file, and in the other packages there are Felipe> very few).

Just remove the files.

Quoted 2 lines
Quoted 2 lines

Thinking a bit more about it - For the omap3 stuff, they are all with A8 cores, so we could even do 'depends on BR2_cortex_a8', right?

Felipe> I guess so.

Ok, good.

Quoted 2 lines
Quoted 2 lines

Is this omap3 specific like the rest, or would it also work on E.G. the pandaboard?

Felipe> That's a good question. I don't think the OMAP4 display sub-system Felipe> works right now, so it's hard to tell, but in theory it should work.

Ok, thanks.

Signature · 1 line
Bye, Peter Korsgaard