cpu-hotplug: Releasing `workqueue_mutex' properly on CPU hot-remove
PATCH 2/2 cpu-hotplug: Releasing `workqueue_mutex' properly on CPU hot-remove
Releasing `workqueue_mutex' properly on CPU hot-remove.
_cpu_down() acquires `workqueue_mutex' on its process, but doen't release it if __cpu_disable() fails.
Signed-off-by Satoru Takeuchi <[email protected]>
kernel/cpu.c +6 -6
@@ -150,18 +150,18 @@ p =__stop_machine_run (take_cpu_down,NULL , cpu);mutex_unlock (&cpu_bitmask_lock); -if (IS_ERR (p)) { +if (IS_ERR (p) ||cpu_online (cpu)) {/* CPU didn't die: tell everyone. Can't complain. */ if (raw_notifier_call_chain (&cpu_chain,CPU_DOWN_FAILED , (void *)(long )cpu) ==NOTIFY_BAD )BUG (); - err =PTR_ERR (p); - goto out_allowed; - } - -if (cpu_online (cpu)) +if (IS_ERR (p)) { + err =PTR_ERR (p); + goto out_allowed; + } goto out_thread; + }/* Wait for it to sleep (leaving idle task). */ while (!idle_cpu (cpu))