ALSA: hda/realtek: mute led fix for HP Pavilion 14 ec1xxx series
PATCH 1/1 ALSA: hda/realtek: mute led fix for HP Pavilion 14 ec1xxx series
The HP Pavilion 14 ec1xxx series uses the HP mainboard 8A0F with the ALC287 codec. It needs the ALC287_FIXUP_HP_GPIO_LED quirk to enable the mute led.
--- sound/pci/hda/patch_realtek.c | 1 + 1 file changed, 1 insertion(+)
sound/pci/hda/patch_realtek.c +1 -0
@@ -9881,6 +9881,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {SND_PCI_QUIRK (0x103c ,0x89c6 ,"Zbook Fury 17 G9" ,ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED ),SND_PCI_QUIRK (0x103c ,0x89ca ,"HP" ,ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF ),SND_PCI_QUIRK (0x103c ,0x89d3 ,"HP EliteBook 645 G9 (MB 89D2)" ,ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF ), +SND_PCI_QUIRK (0x103c ,0x8a0f ,"HP Pavilion 14-ec1xxx" ,ALC287_FIXUP_HP_GPIO_LED ),SND_PCI_QUIRK (0x103c ,0x8a20 ,"HP Laptop 15s-fq5xxx" ,ALC236_FIXUP_HP_MUTE_LED_COEFBIT2 ),SND_PCI_QUIRK (0x103c ,0x8a25 ,"HP Victus 16-d1xxx (MB 8A25)" ,ALC245_FIXUP_HP_MUTE_LED_COEFBIT ), SND_PCI_QUIRK(0x103c, 0x8a78, "HP Dev One", ALC285_FIXUP_HP_LIMIT_INT_MIC_BOOST),
Signature · 1 line
2.43.0
Quoted 15 lines · opticXC
The HP Pavilion 14 ec1xxx series uses the HP mainboard 8A0F with the ALC287 codec. It needs the
ALC287_FIXUP_HP_GPIO_LEDquirk to enable the mute led.Signed-off-by opticXC <[email protected]>--- sound/pci/hda/patch_realtek.c | 1 + 1 file changed, 1 insertion(+)sound/pci/hda/patch_realtek.c +0
-0
sound/pci/hda/patch_realtek.c static const struct snd_pci_quirk alc269_fixup_tbl[] = { · line 9884
Quoted 4 lines
sound/pci/hda/patch_realtek.c +1
-0@@ -9881,6 +9881,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {SND_PCI_QUIRK (0x103c ,0x89c6 ,"Zbook Fury 17 G9" ,ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED ),SND_PCI_QUIRK (0x103c ,0x89ca ,"HP" ,ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF ),SND_PCI_QUIRK (0x103c ,0x89d3 ,"HP EliteBook 645 G9 (MB 89D2)" ,ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF ), + SND_PCI_QUIRK(0x103c, 0x8a0f, "HP Pavilion 14-ec1xxx", ALC287_FIXUP_HP_GPIO_LED),
The entry has a coding style problem; it uses 4 spaces instead of a hard tab stop.
Please use a hard tab stop and resubmit.
thanks,
Takashi
Quoted 25 lines · Takashi Iwai
Quoted 15 lines · opticXC
The HP Pavilion 14 ec1xxx series uses the HP mainboard 8A0F with the ALC287 codec. It needs the
ALC287_FIXUP_HP_GPIO_LEDquirk to enable the mute led.Signed-off-by opticXC <[email protected]>--- sound/pci/hda/patch_realtek.c | 1 + 1 file changed, 1 insertion(+)sound/pci/hda/patch_realtek.c +0
-0sound/pci/hda/patch_realtek.c static const struct snd_pci_quirk alc269_fixup_tbl[] = { · line 9884
Quoted 4 lines
sound/pci/hda/patch_realtek.c +1
-0@@ -9881,6 +9881,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {SND_PCI_QUIRK (0x103c ,0x89c6 ,"Zbook Fury 17 G9" ,ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED ),SND_PCI_QUIRK (0x103c ,0x89ca ,"HP" ,ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF ),SND_PCI_QUIRK (0x103c ,0x89d3 ,"HP EliteBook 645 G9 (MB 89D2)" ,ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF ), + SND_PCI_QUIRK(0x103c, 0x8a0f, "HP Pavilion 14-ec1xxx", ALC287_FIXUP_HP_GPIO_LED),The entry has a coding style problem; it uses 4 spaces instead of a hard tab stop.
Quoted 1 line
Please use a hard tab stop and resubmit.
Hi Takashi, I also think his Signed-off-by line is a no-go unless he can prove opticXC is a legal name.
Thanks,
Geraldo Nascimento
Quoted 6 lines
thanks,
Takashi
Quoted 27 lines · Geraldo Nascimento
Quoted 25 lines · Takashi Iwai
Quoted 15 lines · opticXC
The HP Pavilion 14 ec1xxx series uses the HP mainboard 8A0F with the ALC287 codec. It needs the
ALC287_FIXUP_HP_GPIO_LEDquirk to enable the mute led.Signed-off-by opticXC <[email protected]>--- sound/pci/hda/patch_realtek.c | 1 + 1 file changed, 1 insertion(+)sound/pci/hda/patch_realtek.c +0
-0sound/pci/hda/patch_realtek.c static const struct snd_pci_quirk alc269_fixup_tbl[] = { · line 9884
Quoted 4 lines
sound/pci/hda/patch_realtek.c +1
-0@@ -9881,6 +9881,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {SND_PCI_QUIRK (0x103c ,0x89c6 ,"Zbook Fury 17 G9" ,ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED ),SND_PCI_QUIRK (0x103c ,0x89ca ,"HP" ,ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF ),SND_PCI_QUIRK (0x103c ,0x89d3 ,"HP EliteBook 645 G9 (MB 89D2)" ,ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF ), + SND_PCI_QUIRK(0x103c, 0x8a0f, "HP Pavilion 14-ec1xxx", ALC287_FIXUP_HP_GPIO_LED),The entry has a coding style problem; it uses 4 spaces instead of a hard tab stop.
Quoted 4 lines
Quoted 1 line
Please use a hard tab stop and resubmit.
Hi Takashi, I also think his Signed-off-by line is a no-go unless he can prove opticXC is a legal name.
Right.
Takashi