drm: Drop select FRAMEBUFFER_CONSOLE for DRM_FBDEV_EMULATION
Subsystems (2)
PATCH 1/1 drm: Drop select FRAMEBUFFER_CONSOLE for DRM_FBDEV_EMULATION
The commit c242f48433e7 ("drm: Make FB_CORE to be selected if DRM fbdev emulation is enabled") changed DRM_FBDEV_EMULATION from 'depends on FB' to an effective 'select FB_CORE', so any config that previously had DRM=y and FB=n now has FB_CORE=y and FRAMEBUFFER_CONSOLE=y.
This leads to unmet direct dependencies detected for FRAMEBUFFER_CONSOLE as reported by Arthur Grillo, e.g:
WARNING: unmet direct dependencies detected for FRAMEBUFFER_CONSOLE
Depends on [n]: VT [=n] && FB_CORE [=y] && !UML [=y] Selected by [y]:
- DRM_FBDEV_EMULATION [=y] && HAS_IOMEM [=y] && DRM [=y] && !EXPERT [=n]
Arnd Bergmann suggests to drop the select FRAMEBUFFER_CONSOLE for the DRM_FBDEV_EMULATION Kconfig symbol, since a possible use case could be to enable DRM fbdev emulation but without a framebuffer console.
---
drivers/gpu/drm/Kconfig | 1 - 1 file changed, 1 deletion(-)
drivers/gpu/drm/Kconfig +0 -1
@@ -135,7 +135,6 @@ config DRM_DEBUG_MODESET_LOCK config DRM_FBDEV_EMULATION bool "Enable legacy fbdev support for your modesetting driver" depends on DRM - select FRAMEBUFFER_CONSOLE if !EXPERT select FRAMEBUFFER_CONSOLE_DETECT_PRIMARY if FRAMEBUFFER_CONSOLE default y help
Signature · 1 line
2.41.0
Quoted 18 lines · Javier Martinez Canillas
The commit
c242f48433e7("drm: MakeFB_COREto be selected if DRM fbdev emulation is enabled") changedDRM_FBDEV_EMULATIONfrom 'depends on FB' to an effective 'selectFB_CORE', so any config that previously had DRM=y and FB=n now has FB_CORE=y and FRAMEBUFFER_CONSOLE=y.This leads to unmet direct dependencies detected for
FRAMEBUFFER_CONSOLEas reported by Arthur Grillo, e.g:WARNING: unmet direct dependencies detected for
FRAMEBUFFER_CONSOLE
Depends on [n]: VT [=n] &&FB_CORE[=y] && !UML [=y] Selected by [y]:
-DRM_FBDEV_EMULATION[=y] &&HAS_IOMEM[=y] && DRM [=y] && !EXPERT [=n]Arnd Bergmann suggests to drop the select
FRAMEBUFFER_CONSOLEfor theDRM_FBDEV_EMULATIONKconfigsymbol, since a possible use case could be to enable DRM fbdev emulation but without a framebuffer console.
Quoted 5 lines
Fixes c242f48433e7 ("drm: Make FB_CORE to be selected if DRM fbdev emulation is enabled")Reported-by Arthur Grillo <[email protected]>Suggested-by Arnd Bergmann <[email protected]>Signed-off-by Javier Martinez Canillas <[email protected]>
Yeah originally this was just to help people not misconfigure their kernels and end up with a black screen. But select is really not a nice way to do that, imo we could drop the FB_CORE select too :-)
Cheers, Sima
Quoted 20 lines
---
drivers/gpu/drm/Kconfig | 1 - 1 file changed, 1 deletion(-)drivers/gpu/drm/Kconfig +0
-2@@ -135,7 +135,6 @@ config DRM_DEBUG_MODESET_LOCK config DRM_FBDEV_EMULATION bool "Enable legacy fbdev support for your modesetting driver" depends on DRM - select FRAMEBUFFER_CONSOLE if !EXPERT select FRAMEBUFFER_CONSOLE_DETECT_PRIMARY if FRAMEBUFFER_CONSOLE default y help --2.41.0
Signature · 3 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
Quoted 26 lines · Daniel Vetter
Quoted 18 lines · Javier Martinez Canillas
The commit
c242f48433e7("drm: MakeFB_COREto be selected if DRM fbdev emulation is enabled") changedDRM_FBDEV_EMULATIONfrom 'depends on FB' to an effective 'selectFB_CORE', so any config that previously had DRM=y and FB=n now has FB_CORE=y and FRAMEBUFFER_CONSOLE=y.This leads to unmet direct dependencies detected for
FRAMEBUFFER_CONSOLEas reported by Arthur Grillo, e.g:WARNING: unmet direct dependencies detected for
FRAMEBUFFER_CONSOLE
Depends on [n]: VT [=n] &&FB_CORE[=y] && !UML [=y] Selected by [y]:
-DRM_FBDEV_EMULATION[=y] &&HAS_IOMEM[=y] && DRM [=y] && !EXPERT [=n]Arnd Bergmann suggests to drop the select
FRAMEBUFFER_CONSOLEfor theDRM_FBDEV_EMULATIONKconfigsymbol, since a possible use case could be to enable DRM fbdev emulation but without a framebuffer console.Quoted 5 lines
Fixes c242f48433e7 ("drm: Make FB_CORE to be selected if DRM fbdev emulation is enabled")Reported-by Arthur Grillo <[email protected]>Suggested-by Arnd Bergmann <[email protected]>Signed-off-by Javier Martinez Canillas <[email protected]>
Quoted 3 lines
Yeah originally this was just to help people not misconfigure their kernels and end up with a black screen. But select is really not a nice way to do that, imo we could drop the
FB_COREselect too :-)
Droping the 'FB_CORE' select only works if we make FB_CORE user visible and add a 'depends on' for it instead. Not sure this is any better since this would only ever be used when either CONFIG_FB or CONFIG_DRM_FBDEV_EMULATION is enabled.
Arnd
Quoted 27 lines · Arnd Bergmann
Quoted 26 lines · Daniel Vetter
Quoted 23 lines · Javier Martinez Canillas
The commit
c242f48433e7("drm: MakeFB_COREto be selected if DRM fbdev emulation is enabled") changedDRM_FBDEV_EMULATIONfrom 'depends on FB' to an effective 'selectFB_CORE', so any config that previously had DRM=y and FB=n now has FB_CORE=y and FRAMEBUFFER_CONSOLE=y.This leads to unmet direct dependencies detected for
FRAMEBUFFER_CONSOLEas reported by Arthur Grillo, e.g:WARNING: unmet direct dependencies detected for
FRAMEBUFFER_CONSOLE
Depends on [n]: VT [=n] &&FB_CORE[=y] && !UML [=y] Selected by [y]:
-DRM_FBDEV_EMULATION[=y] &&HAS_IOMEM[=y] && DRM [=y] && !EXPERT [=n]Arnd Bergmann suggests to drop the select
FRAMEBUFFER_CONSOLEfor theDRM_FBDEV_EMULATIONKconfigsymbol, since a possible use case could be to enable DRM fbdev emulation but without a framebuffer console.Fixes c242f48433e7 ("drm: Make FB_CORE to be selected if DRM fbdev emulation is enabled")Reported-by Arthur Grillo <[email protected]>Suggested-by Arnd Bergmann <[email protected]>Signed-off-by Javier Martinez Canillas <[email protected]>
Quoted 9 lines
Quoted 3 lines
Yeah originally this was just to help people not misconfigure their kernels and end up with a black screen. But select is really not a nice way to do that, imo we could drop the
FB_COREselect too :-)Droping the '
FB_CORE' select only works if we makeFB_COREuser visible and add a 'depends on' for it instead. Not sure this is any better since this would only ever be used when eitherCONFIG_FBorCONFIG_DRM_FBDEV_EMULATIONis enabled.
Agreed.
Signature · 5 lines
Best regards, Javier Martinez Canillas Core Platforms Red Hat
Quoted 17 lines · Javier Martinez Canillas
The commit
c242f48433e7("drm: MakeFB_COREto be selected if DRM fbdev emulation is enabled") changedDRM_FBDEV_EMULATIONfrom 'depends on FB' to an effective 'selectFB_CORE', so any config that previously had DRM=y and FB=n now has FB_CORE=y and FRAMEBUFFER_CONSOLE=y.This leads to unmet direct dependencies detected for
FRAMEBUFFER_CONSOLEas reported by Arthur Grillo, e.g:WARNING: unmet direct dependencies detected for
FRAMEBUFFER_CONSOLE
Depends on [n]: VT [=n] &&FB_CORE[=y] && !UML [=y] Selected by [y]:
-DRM_FBDEV_EMULATION[=y] &&HAS_IOMEM[=y] && DRM [=y] && !EXPERT [=n]Arnd Bergmann suggests to drop the select
FRAMEBUFFER_CONSOLEfor theDRM_FBDEV_EMULATIONKconfigsymbol, since a possible use case could be to enable DRM fbdev emulation but without a framebuffer console.
Quoted 6 lines
Fixes c242f48433e7 ("drm: Make FB_CORE to be selected if DRM fbdev emulation is enabled")Reported-by Arthur Grillo <[email protected]>Suggested-by Arnd Bergmann <[email protected]>Signed-off-by Javier Martinez Canillas <[email protected]>---
Greate patch! I was about to send the same one XD.
Best Regards,
~Arthur Grillo
Quoted 16 lines
drivers/gpu/drm/Kconfig | 1 - 1 file changed, 1 deletion(-)drivers/gpu/drm/Kconfig +0
-1@@ -135,7 +135,6 @@ config DRM_DEBUG_MODESET_LOCK config DRM_FBDEV_EMULATION bool "Enable legacy fbdev support for your modesetting driver" depends on DRM - select FRAMEBUFFER_CONSOLE if !EXPERT select FRAMEBUFFER_CONSOLE_DETECT_PRIMARY if FRAMEBUFFER_CONSOLE default y help
Javier Martinez Canillas
AppliedQuoted 25 lines · Arthur Grillo
Quoted 17 lines · Javier Martinez Canillas
The commit
c242f48433e7("drm: MakeFB_COREto be selected if DRM fbdev emulation is enabled") changedDRM_FBDEV_EMULATIONfrom 'depends on FB' to an effective 'selectFB_CORE', so any config that previously had DRM=y and FB=n now has FB_CORE=y and FRAMEBUFFER_CONSOLE=y.This leads to unmet direct dependencies detected for
FRAMEBUFFER_CONSOLEas reported by Arthur Grillo, e.g:WARNING: unmet direct dependencies detected for
FRAMEBUFFER_CONSOLE
Depends on [n]: VT [=n] &&FB_CORE[=y] && !UML [=y] Selected by [y]:
-DRM_FBDEV_EMULATION[=y] &&HAS_IOMEM[=y] && DRM [=y] && !EXPERT [=n]Arnd Bergmann suggests to drop the select
FRAMEBUFFER_CONSOLEfor theDRM_FBDEV_EMULATIONKconfigsymbol, since a possible use case could be to enable DRM fbdev emulation but without a framebuffer console.Quoted 6 lines
Fixes c242f48433e7 ("drm: Make FB_CORE to be selected if DRM fbdev emulation is enabled")Reported-by Arthur Grillo <[email protected]>Suggested-by Arnd Bergmann <[email protected]>Signed-off-by Javier Martinez Canillas <[email protected]>---
Quoted 4 lines
Greate patch! I was about to send the same one XD.
Reviewed-by Arthur Grillo <[email protected]>
Pushed to drm-misc (drm-misc-next). Thanks!
Signature · 5 lines
Best regards, Javier Martinez Canillas Core Platforms Red Hat
Quoted 17 lines · Javier Martinez Canillas
The commit
c242f48433e7("drm: MakeFB_COREto be selected if DRM fbdev emulation is enabled") changedDRM_FBDEV_EMULATIONfrom 'depends on FB' to an effective 'selectFB_CORE', so any config that previously had DRM=y and FB=n now has FB_CORE=y and FRAMEBUFFER_CONSOLE=y.This leads to unmet direct dependencies detected for
FRAMEBUFFER_CONSOLEas reported by Arthur Grillo, e.g:WARNING: unmet direct dependencies detected for
FRAMEBUFFER_CONSOLE
Depends on [n]: VT [=n] &&FB_CORE[=y] && !UML [=y] Selected by [y]:
-DRM_FBDEV_EMULATION[=y] &&HAS_IOMEM[=y] && DRM [=y] && !EXPERT [=n]Arnd Bergmann suggests to drop the select
FRAMEBUFFER_CONSOLEfor theDRM_FBDEV_EMULATIONKconfigsymbol, since a possible use case could be to enable DRM fbdev emulation but without a framebuffer console.
Quoted 5 lines
Fixes c242f48433e7 ("drm: Make FB_CORE to be selected if DRM fbdev emulation is enabled")Reported-by Arthur Grillo <[email protected]>Suggested-by Arnd Bergmann <[email protected]>Signed-off-by Javier Martinez Canillas <[email protected]>
Thanks.
Quoted 17 lines
---
drivers/gpu/drm/Kconfig | 1 - 1 file changed, 1 deletion(-)drivers/gpu/drm/Kconfig +0
-1@@ -135,7 +135,6 @@ config DRM_DEBUG_MODESET_LOCK config DRM_FBDEV_EMULATION bool "Enable legacy fbdev support for your modesetting driver" depends on DRM - select FRAMEBUFFER_CONSOLE if !EXPERT select FRAMEBUFFER_CONSOLE_DETECT_PRIMARY if FRAMEBUFFER_CONSOLE default y help
Signature · 1 line
~Randy
Randy Dunlap <[email protected]> writes:
Hello Randy,
Quoted 18 lines · Javier Martinez Canillas
Quoted 17 lines
The commit
c242f48433e7("drm: MakeFB_COREto be selected if DRM fbdev emulation is enabled") changedDRM_FBDEV_EMULATIONfrom 'depends on FB' to an effective 'selectFB_CORE', so any config that previously had DRM=y and FB=n now has FB_CORE=y and FRAMEBUFFER_CONSOLE=y.This leads to unmet direct dependencies detected for
FRAMEBUFFER_CONSOLEas reported by Arthur Grillo, e.g:WARNING: unmet direct dependencies detected for
FRAMEBUFFER_CONSOLE
Depends on [n]: VT [=n] &&FB_CORE[=y] && !UML [=y] Selected by [y]:
-DRM_FBDEV_EMULATION[=y] &&HAS_IOMEM[=y] && DRM [=y] && !EXPERT [=n]Arnd Bergmann suggests to drop the select
FRAMEBUFFER_CONSOLEfor theDRM_FBDEV_EMULATIONKconfigsymbol, since a possible use case could be to enable DRM fbdev emulation but without a framebuffer console.
Quoted 9 lines
Quoted 5 lines
Fixes c242f48433e7 ("drm: Make FB_CORE to be selected if DRM fbdev emulation is enabled")Reported-by Arthur Grillo <[email protected]>Suggested-by Arnd Bergmann <[email protected]>Signed-off-by Javier Martinez Canillas <[email protected]>
I have already pushed this patch so I won't be able to add these tags but thanks a lot for testing and confirming that the patch fixes your issue!
Quoted 3 lines
Thanks.
Signature · 5 lines
Best regards, Javier Martinez Canillas Core Platforms Red Hat