Skip to contentSkip to conversation

drm: Drop select FRAMEBUFFER_CONSOLE for DRM_FBDEV_EMULATION

PATCH In review Javier Martinez Canillas 5 participants 8 messages Aug 4, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm: Drop select FRAMEBUFFER_CONSOLE for DRM_FBDEV_EMULATION

The commit c242f48433e7 ("drm: Make FB_CORE to be selected if DRM fbdev emulation is enabled") changed DRM_FBDEV_EMULATION from 'depends on FB' to an effective 'select FB_CORE', so any config that previously had DRM=y and FB=n now has FB_CORE=y and FRAMEBUFFER_CONSOLE=y.

This leads to unmet direct dependencies detected for FRAMEBUFFER_CONSOLE as reported by Arthur Grillo, e.g:

WARNING: unmet direct dependencies detected for FRAMEBUFFER_CONSOLE
Depends on [n]: VT [=n] && FB_CORE [=y] && !UML [=y] Selected by [y]:
- DRM_FBDEV_EMULATION [=y] && HAS_IOMEM [=y] && DRM [=y] && !EXPERT [=n]

Arnd Bergmann suggests to drop the select FRAMEBUFFER_CONSOLE for the DRM_FBDEV_EMULATION Kconfig symbol, since a possible use case could be to enable DRM fbdev emulation but without a framebuffer console.

Fixes c242f48433e7 ("drm: Make FB_CORE to be selected if DRM fbdev emulation is enabled")

---

 drivers/gpu/drm/Kconfig | 1 -
 1 file changed, 1 deletion(-)
drivers/gpu/drm/Kconfig +0 -1
index b51c6a141dfa..2a44b9419d4d 100644
@@ -135,7 +135,6 @@ config DRM_DEBUG_MODESET_LOCK
 config DRM_FBDEV_EMULATION
 	bool "Enable legacy fbdev support for your modesetting driver"
 	depends on DRM
-	select FRAMEBUFFER_CONSOLE if !EXPERT
 	select FRAMEBUFFER_CONSOLE_DETECT_PRIMARY if FRAMEBUFFER_CONSOLE
 	default y
 	help
Signature · 1 line
2.41.0
Acked-by on v1 1/1
#1 lore raw
Quoted 18 lines · Javier Martinez Canillas

The commit c242f48433e7 ("drm: Make FB_CORE to be selected if DRM fbdev emulation is enabled") changed DRM_FBDEV_EMULATION from 'depends on FB' to an effective 'select FB_CORE', so any config that previously had DRM=y and FB=n now has FB_CORE=y and FRAMEBUFFER_CONSOLE=y.

This leads to unmet direct dependencies detected for FRAMEBUFFER_CONSOLE as reported by Arthur Grillo, e.g:

WARNING: unmet direct dependencies detected for FRAMEBUFFER_CONSOLE
Depends on [n]: VT [=n] && FB_CORE [=y] && !UML [=y] Selected by [y]:
- DRM_FBDEV_EMULATION [=y] && HAS_IOMEM [=y] && DRM [=y] && !EXPERT [=n]

Arnd Bergmann suggests to drop the select FRAMEBUFFER_CONSOLE for the DRM_FBDEV_EMULATION Kconfig symbol, since a possible use case could be to enable DRM fbdev emulation but without a framebuffer console.

Quoted 5 lines
Fixes c242f48433e7 ("drm: Make FB_CORE to be selected if DRM fbdev emulation is enabled")

Yeah originally this was just to help people not misconfigure their kernels and end up with a black screen. But select is really not a nice way to do that, imo we could drop the FB_CORE select too :-)

Cheers, Sima

Quoted 20 lines

---

 drivers/gpu/drm/Kconfig | 1 -
 1 file changed, 1 deletion(-)
drivers/gpu/drm/Kconfig +0 -2
index b51c6a141dfa..2a44b9419d4d 100644
@@ -135,7 +135,6 @@ config DRM_DEBUG_MODESET_LOCK
 config DRM_FBDEV_EMULATION
        bool "Enable legacy fbdev support for your modesetting driver"
        depends on DRM
-       select FRAMEBUFFER_CONSOLE if !EXPERT
        select FRAMEBUFFER_CONSOLE_DETECT_PRIMARY if FRAMEBUFFER_CONSOLE
        default y
        help
--

2.41.0

Signature · 3 lines
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
#2 lore raw
Quoted 26 lines · Daniel Vetter
Quoted 18 lines · Javier Martinez Canillas

The commit c242f48433e7 ("drm: Make FB_CORE to be selected if DRM fbdev emulation is enabled") changed DRM_FBDEV_EMULATION from 'depends on FB' to an effective 'select FB_CORE', so any config that previously had DRM=y and FB=n now has FB_CORE=y and FRAMEBUFFER_CONSOLE=y.

This leads to unmet direct dependencies detected for FRAMEBUFFER_CONSOLE as reported by Arthur Grillo, e.g:

WARNING: unmet direct dependencies detected for FRAMEBUFFER_CONSOLE
Depends on [n]: VT [=n] && FB_CORE [=y] && !UML [=y] Selected by [y]:
- DRM_FBDEV_EMULATION [=y] && HAS_IOMEM [=y] && DRM [=y] && !EXPERT [=n]

Arnd Bergmann suggests to drop the select FRAMEBUFFER_CONSOLE for the DRM_FBDEV_EMULATION Kconfig symbol, since a possible use case could be to enable DRM fbdev emulation but without a framebuffer console.

Quoted 5 lines
Fixes c242f48433e7 ("drm: Make FB_CORE to be selected if DRM fbdev emulation is enabled")
Quoted 3 lines

Yeah originally this was just to help people not misconfigure their kernels and end up with a black screen. But select is really not a nice way to do that, imo we could drop the FB_CORE select too :-)

Droping the 'FB_CORE' select only works if we make FB_CORE user visible and add a 'depends on' for it instead. Not sure this is any better since this would only ever be used when either CONFIG_FB or CONFIG_DRM_FBDEV_EMULATION is enabled.

Arnd

#3 lore raw
Quoted 27 lines · Arnd Bergmann
Quoted 26 lines · Daniel Vetter
Quoted 23 lines · Javier Martinez Canillas

The commit c242f48433e7 ("drm: Make FB_CORE to be selected if DRM fbdev emulation is enabled") changed DRM_FBDEV_EMULATION from 'depends on FB' to an effective 'select FB_CORE', so any config that previously had DRM=y and FB=n now has FB_CORE=y and FRAMEBUFFER_CONSOLE=y.

This leads to unmet direct dependencies detected for FRAMEBUFFER_CONSOLE as reported by Arthur Grillo, e.g:

WARNING: unmet direct dependencies detected for FRAMEBUFFER_CONSOLE
Depends on [n]: VT [=n] && FB_CORE [=y] && !UML [=y] Selected by [y]:
- DRM_FBDEV_EMULATION [=y] && HAS_IOMEM [=y] && DRM [=y] && !EXPERT [=n]

Arnd Bergmann suggests to drop the select FRAMEBUFFER_CONSOLE for the DRM_FBDEV_EMULATION Kconfig symbol, since a possible use case could be to enable DRM fbdev emulation but without a framebuffer console.

Fixes c242f48433e7 ("drm: Make FB_CORE to be selected if DRM fbdev emulation is enabled")
Quoted 9 lines
Quoted 3 lines

Yeah originally this was just to help people not misconfigure their kernels and end up with a black screen. But select is really not a nice way to do that, imo we could drop the FB_CORE select too :-)

Droping the 'FB_CORE' select only works if we make FB_CORE user visible and add a 'depends on' for it instead. Not sure this is any better since this would only ever be used when either CONFIG_FB or CONFIG_DRM_FBDEV_EMULATION is enabled.

Agreed.

Signature · 5 lines
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat
Reviewed-by on v1 1/1
#4 lore raw
In reply to Javier Martinez Canillas
Quoted 17 lines · Javier Martinez Canillas

The commit c242f48433e7 ("drm: Make FB_CORE to be selected if DRM fbdev emulation is enabled") changed DRM_FBDEV_EMULATION from 'depends on FB' to an effective 'select FB_CORE', so any config that previously had DRM=y and FB=n now has FB_CORE=y and FRAMEBUFFER_CONSOLE=y.

This leads to unmet direct dependencies detected for FRAMEBUFFER_CONSOLE as reported by Arthur Grillo, e.g:

WARNING: unmet direct dependencies detected for FRAMEBUFFER_CONSOLE
Depends on [n]: VT [=n] && FB_CORE [=y] && !UML [=y] Selected by [y]:
- DRM_FBDEV_EMULATION [=y] && HAS_IOMEM [=y] && DRM [=y] && !EXPERT [=n]

Arnd Bergmann suggests to drop the select FRAMEBUFFER_CONSOLE for the DRM_FBDEV_EMULATION Kconfig symbol, since a possible use case could be to enable DRM fbdev emulation but without a framebuffer console.

Quoted 6 lines
Fixes c242f48433e7 ("drm: Make FB_CORE to be selected if DRM fbdev emulation is enabled")

---

Greate patch! I was about to send the same one XD.

Best Regards,
~Arthur Grillo

Quoted 16 lines
 drivers/gpu/drm/Kconfig | 1 -
 1 file changed, 1 deletion(-)
drivers/gpu/drm/Kconfig +0 -1
index b51c6a141dfa..2a44b9419d4d 100644
@@ -135,7 +135,6 @@ config DRM_DEBUG_MODESET_LOCK
 config DRM_FBDEV_EMULATION
 	bool "Enable legacy fbdev support for your modesetting driver"
 	depends on DRM
-	select FRAMEBUFFER_CONSOLE if !EXPERT
 	select FRAMEBUFFER_CONSOLE_DETECT_PRIMARY if FRAMEBUFFER_CONSOLE
 	default y
 	help
#5 lore raw
Quoted 25 lines · Arthur Grillo
Quoted 17 lines · Javier Martinez Canillas

The commit c242f48433e7 ("drm: Make FB_CORE to be selected if DRM fbdev emulation is enabled") changed DRM_FBDEV_EMULATION from 'depends on FB' to an effective 'select FB_CORE', so any config that previously had DRM=y and FB=n now has FB_CORE=y and FRAMEBUFFER_CONSOLE=y.

This leads to unmet direct dependencies detected for FRAMEBUFFER_CONSOLE as reported by Arthur Grillo, e.g:

WARNING: unmet direct dependencies detected for FRAMEBUFFER_CONSOLE
Depends on [n]: VT [=n] && FB_CORE [=y] && !UML [=y] Selected by [y]:
- DRM_FBDEV_EMULATION [=y] && HAS_IOMEM [=y] && DRM [=y] && !EXPERT [=n]

Arnd Bergmann suggests to drop the select FRAMEBUFFER_CONSOLE for the DRM_FBDEV_EMULATION Kconfig symbol, since a possible use case could be to enable DRM fbdev emulation but without a framebuffer console.

Quoted 6 lines
Fixes c242f48433e7 ("drm: Make FB_CORE to be selected if DRM fbdev emulation is enabled")

---

Quoted 4 lines

Greate patch! I was about to send the same one XD.

Pushed to drm-misc (drm-misc-next). Thanks!

Signature · 5 lines
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat
Acked-by Tested-by on v1 1/1
#6 lore raw
In reply to Javier Martinez Canillas
Quoted 17 lines · Javier Martinez Canillas

The commit c242f48433e7 ("drm: Make FB_CORE to be selected if DRM fbdev emulation is enabled") changed DRM_FBDEV_EMULATION from 'depends on FB' to an effective 'select FB_CORE', so any config that previously had DRM=y and FB=n now has FB_CORE=y and FRAMEBUFFER_CONSOLE=y.

This leads to unmet direct dependencies detected for FRAMEBUFFER_CONSOLE as reported by Arthur Grillo, e.g:

WARNING: unmet direct dependencies detected for FRAMEBUFFER_CONSOLE
Depends on [n]: VT [=n] && FB_CORE [=y] && !UML [=y] Selected by [y]:
- DRM_FBDEV_EMULATION [=y] && HAS_IOMEM [=y] && DRM [=y] && !EXPERT [=n]

Arnd Bergmann suggests to drop the select FRAMEBUFFER_CONSOLE for the DRM_FBDEV_EMULATION Kconfig symbol, since a possible use case could be to enable DRM fbdev emulation but without a framebuffer console.

Quoted 5 lines
Fixes c242f48433e7 ("drm: Make FB_CORE to be selected if DRM fbdev emulation is enabled")

Thanks.

Quoted 17 lines

---

 drivers/gpu/drm/Kconfig | 1 -
 1 file changed, 1 deletion(-)
drivers/gpu/drm/Kconfig +0 -1
index b51c6a141dfa..2a44b9419d4d 100644
@@ -135,7 +135,6 @@ config DRM_DEBUG_MODESET_LOCK
 config DRM_FBDEV_EMULATION
 	bool "Enable legacy fbdev support for your modesetting driver"
 	depends on DRM
-	select FRAMEBUFFER_CONSOLE if !EXPERT
 	select FRAMEBUFFER_CONSOLE_DETECT_PRIMARY if FRAMEBUFFER_CONSOLE
 	default y
 	help
Signature · 1 line
~Randy
#7 lore raw

Randy Dunlap <[email protected]> writes:

Hello Randy,

Quoted 18 lines · Javier Martinez Canillas
Quoted 17 lines

The commit c242f48433e7 ("drm: Make FB_CORE to be selected if DRM fbdev emulation is enabled") changed DRM_FBDEV_EMULATION from 'depends on FB' to an effective 'select FB_CORE', so any config that previously had DRM=y and FB=n now has FB_CORE=y and FRAMEBUFFER_CONSOLE=y.

This leads to unmet direct dependencies detected for FRAMEBUFFER_CONSOLE as reported by Arthur Grillo, e.g:

WARNING: unmet direct dependencies detected for FRAMEBUFFER_CONSOLE
Depends on [n]: VT [=n] && FB_CORE [=y] && !UML [=y] Selected by [y]:
- DRM_FBDEV_EMULATION [=y] && HAS_IOMEM [=y] && DRM [=y] && !EXPERT [=n]

Arnd Bergmann suggests to drop the select FRAMEBUFFER_CONSOLE for the DRM_FBDEV_EMULATION Kconfig symbol, since a possible use case could be to enable DRM fbdev emulation but without a framebuffer console.

Quoted 9 lines
Quoted 5 lines
Fixes c242f48433e7 ("drm: Make FB_CORE to be selected if DRM fbdev emulation is enabled")

I have already pushed this patch so I won't be able to add these tags but thanks a lot for testing and confirming that the patch fixes your issue!

Quoted 3 lines

Thanks.

Signature · 5 lines
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat