libsepol/cil: silence GCC 12 array-bounds false positive
PATCH 1/1 libsepol/cil: silence GCC 12 array-bounds false positive
GCC 12 produces an array-bounds warning:
In file included from ../include/sepol/policydb/context.h:23,
from ../include/sepol/policydb/policydb.h:62,
from ../cil/src/cil_binary.c:41:
In function ‘mls_level_init’,
inlined from ‘mls_level_destroy’ at ../include/sepol/policydb/mls_types.h:99:2,
inlined from ‘mls_level_destroy’ at ../include/sepol/policydb/mls_types.h:92:20,
inlined from ‘mls_range_destroy’ at ../include/sepol/policydb/mls_types.h:149:2,
inlined from ‘cil_rangetransition_to_policydb’ at ../cil/src/cil_binary.c:3231:6:
../include/sepol/policydb/mls_types.h:89:9: error: ‘memset’ offset [0, 23] is out of the bounds [0, 0] [-Werror=array-bounds]
89 | memset(level, 0, sizeof(mls_level_t));
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/sepol/policydb/mls_types.h:89:9: error: ‘memset’ offset [0, 23] is out of the bounds [0, 0] [-Werror=array-bounds]
cc1: all warnings being treated as errors
This is a false positive, by inspecting the code and compiling with -O3 and -flto.
--- libsepol/cil/src/cil_binary.c | 9 +++++++++ 1 file changed, 9 insertions(+)
libsepol/cil/src/cil_binary.c +9 -0
@@ -3222,7 +3222,16 @@ int cil_rangetransition_to_policydb(policydb_t *pdb, const struct cil_db *db, st }else {cil_log (CIL_ERR ,"Out of memory\n" ); } +// TODO: add upper version bound once fixed in upstream GCC +#if defined(__GNUC__) && (__GNUC__ >=12 ) +# pragma GCC diagnostic push +# pragma GCC diagnostic ignored "-Warray-bounds" +# pragma GCC diagnostic ignored "-Wstringop-overflow" +#endif mls_range_destroy (newdatum); +#if defined(__GNUC__) && (__GNUC__ >=12 ) +# pragma GCC diagnostic pop +#endif free (newdatum);free (newkey);if (rc !=SEPOL_OK ) {
Signature · 1 line
2.35.1
Quoted 17 lines · Christian Göttsche
GCC 12 produces an array-bounds warning:
In file included from
../include/sepol/policydb/context.h:23,
from../include/sepol/policydb/policydb.h:62,
from../cil/src/cil_binary.c:41:
In function ‘mls_level_init’,
inlined from ‘mls_level_destroy’ at../include/sepol/policydb/mls_types.h:99:2,
inlined from ‘mls_level_destroy’ at../include/sepol/policydb/mls_types.h:92:20,
inlined from ‘mls_range_destroy’ at../include/sepol/policydb/mls_types.h:149:2,
inlined from ‘cil_rangetransition_to_policydb’ at../cil/src/cil_binary.c:3231:6:
../include/sepol/policydb/mls_types.h:89:9: error: ‘memset’ offset [0, 23] is out of the bounds [0, 0] [-Werror=array-bounds]
89 |memset(level, 0, sizeof(mls_level_t));
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/sepol/policydb/mls_types.h:89:9: error: ‘memset’ offset [0, 23] is out of the bounds [0, 0] [-Werror=array-bounds]
cc1: all warnings being treated as errors
Quoted 6 lines
This is a false positive, by inspecting the code and compiling with -O3 and -flto.
Signed-off-by Christian Göttsche <[email protected]>
Quoted 28 lines
--- libsepol/cil/src/cil_binary.c | 9 +++++++++ 1 file changed, 9 insertions(+)libsepol/cil/src/cil_binary.c +9
-1@@ -3222,7 +3222,16 @@ int cil_rangetransition_to_policydb(policydb_t *pdb, const struct cil_db *db, st }else {cil_log (CIL_ERR ,"Out of memory\n" ); } +// TODO: add upper version bound once fixed in upstream GCC +#if defined(__GNUC__) && (__GNUC__ >=12 ) +# pragma GCC diagnostic push +# pragma GCC diagnostic ignored "-Warray-bounds" +# pragma GCC diagnostic ignored "-Wstringop-overflow" +#endif mls_range_destroy (newdatum); +#if defined(__GNUC__) && (__GNUC__ >=12 ) +# pragma GCC diagnostic pop +#endif free (newdatum);free (newkey);if (rc !=SEPOL_OK ) { --2.35.1
Quoted 19 lines · James Carter
Quoted 17 lines · Christian Göttsche
GCC 12 produces an array-bounds warning:
In file included from
../include/sepol/policydb/context.h:23,
from../include/sepol/policydb/policydb.h:62,
from../cil/src/cil_binary.c:41:
In function ‘mls_level_init’,
inlined from ‘mls_level_destroy’ at../include/sepol/policydb/mls_types.h:99:2,
inlined from ‘mls_level_destroy’ at../include/sepol/policydb/mls_types.h:92:20,
inlined from ‘mls_range_destroy’ at../include/sepol/policydb/mls_types.h:149:2,
inlined from ‘cil_rangetransition_to_policydb’ at../cil/src/cil_binary.c:3231:6:
../include/sepol/policydb/mls_types.h:89:9: error: ‘memset’ offset [0, 23] is out of the bounds [0, 0] [-Werror=array-bounds]
89 |memset(level, 0, sizeof(mls_level_t));
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/sepol/policydb/mls_types.h:89:9: error: ‘memset’ offset [0, 23] is out of the bounds [0, 0] [-Werror=array-bounds]
cc1: all warnings being treated as errors
Quoted 8 lines
Quoted 6 lines
This is a false positive, by inspecting the code and compiling with -O3 and -flto.
Signed-off-by Christian Göttsche <[email protected]>Acked-by James Carter <[email protected]>
Merged.
Quoted 28 lines
Quoted 28 lines
--- libsepol/cil/src/cil_binary.c | 9 +++++++++ 1 file changed, 9 insertions(+)libsepol/cil/src/cil_binary.c +9
-1@@ -3222,7 +3222,16 @@ int cil_rangetransition_to_policydb(policydb_t *pdb, const struct cil_db *db, st }else {cil_log (CIL_ERR ,"Out of memory\n" ); } +// TODO: add upper version bound once fixed in upstream GCC +#if defined(__GNUC__) && (__GNUC__ >=12 ) +# pragma GCC diagnostic push +# pragma GCC diagnostic ignored "-Warray-bounds" +# pragma GCC diagnostic ignored "-Wstringop-overflow" +#endif mls_range_destroy (newdatum); +#if defined(__GNUC__) && (__GNUC__ >=12 ) +# pragma GCC diagnostic pop +#endif free (newdatum);free (newkey);if (rc !=SEPOL_OK ) { --2.35.1