Skip to contentSkip to conversation

package/libssh2: fix autoreconf comment

PATCH New Danomi Manchego 3 participants 3 messages May 16, 2020 – May 26, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/libssh2: fix autoreconf comment

The comment explaining the autoreconf says that we are building from a git clone - but we are not, currently. However, the reconf is still needed due to patches modifying ac files.

This commit corrects the comment.

---
 package/libssh2/libssh2.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/libssh2/libssh2.mk +1 -1
index 3819c1a..2d2599f 100644
@@ -14,7 +14,7 @@ LIBSSH2_CONF_OPTS = --disable-examples-build
 # 0003-packet-c-improve-message-parsing.patch
 LIBSSH2_IGNORE_CVES += CVE-2019-17498
 
-# building from a git clone
+# patch touching configure.ac
 LIBSSH2_AUTORECONF = YES
 
 ifeq ($(BR2_PACKAGE_LIBSSH2_MBEDTLS),y)
Signature · 1 line
2.7.4
#1 lore raw

PATCH 1/1 package/libssh2: fix autoreconf comment

Danomi, All,

On 2020-05-16 12:11 -0400, Danomi Manchego spake thusly:

Quoted 16 lines

The comment explaining the autoreconf says that we are building from a git clone - but we are not, currently. However, the reconf is still needed due to patches modifying ac files.

This commit corrects the comment.

---
 package/libssh2/libssh2.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/libssh2/libssh2.mk +0 -0
index 3819c1a..2d2599f 100644

package/libssh2/libssh2.mk LIBSSH2_CONF_OPTS = --disable-examples-build · line 17

Quoted 5 lines
package/libssh2/libssh2.mk +1 -1
@@ -14,7 +14,7 @@ LIBSSH2_CONF_OPTS = --disable-examples-build
 # 0003-packet-c-improve-message-parsing.patch
 LIBSSH2_IGNORE_CVES += CVE-2019-17498
 
-# building from a git clone
+# patch touching configure.ac

... and acincludes.m4.

Applied to master with that fixed. thanks!

Regards,
Yann E. MORIN.

Quoted 10 lines
package/libssh2/libssh2.mk +0 -0
 LIBSSH2_AUTORECONF = YES
 
 ifeq ($(BR2_PACKAGE_LIBSSH2_MBEDTLS),y)
Signature · 6 lines
2.7.4

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#2 lore raw

PATCH 1/1 package/libssh2: fix autoreconf comment

In reply to Danomi Manchego
Quoted 9 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Danomi" == Danomi Manchego <[email protected]> writes:

The comment explaining the autoreconf says that we are building from a git clone - but we are not, currently. However, the reconf is still needed due to patches modifying ac files.

This commit corrects the comment.

Committed to 2020.02.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard