Skip to contentSkip to conversation

package/libva: fix mesa3d glx support

PATCH New Bernd Kuhls 4 participants 5 messages Oct 1, 2019 – Oct 28, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/libva: fix mesa3d glx support

https://git.buildroot.net/buildroot/commit/package/mesa3d?id=5cb821d5635626b7327d5d704555c412e5ed5a1f

added a new option to enable GLX support.

This patch adjusts libva to use the new logic.

Fixes:
http://autobuild.buildroot.net/results/797/79776104e681402c24160be15789fe67bb69f833/

---
 package/libva/libva.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/libva/libva.mk +1 -1
index 7bf1839f4c..6c8243da90 100644
@@ -20,7 +20,7 @@ LIBVA_CONF_OPTS = \
 ifeq ($(BR2_PACKAGE_XORG7),y)
 LIBVA_DEPENDENCIES += xlib_libX11 xlib_libXext xlib_libXfixes
 LIBVA_CONF_OPTS += --enable-x11
-ifeq ($(BR2_PACKAGE_MESA3D_DRI_DRIVER),y)
+ifeq ($(BR2_PACKAGE_MESA3D_OPENGL_GLX),y)
 LIBVA_DEPENDENCIES += mesa3d
 LIBVA_CONF_OPTS += --enable-glx
 endif
Signature · 1 line
2.20.1
#1 lore raw

PATCH 1/1 package/libva: fix mesa3d glx support

Hi Bernd,

Quoted 10 lines · Bernd Kuhls

https://git.buildroot.net/buildroot/commit/package/mesa3d?id=5cb821d5635626b7327d5d704555c412e5ed5a1f

added a new option to enable GLX support.

This patch adjusts libva to use the new logic.

Fixes:
http://autobuild.buildroot.net/results/797/79776104e681402c24160be15789fe67bb69f833/

Quoted 18 lines
---
  package/libva/libva.mk | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
package/libva/libva.mk +1 -1
index 7bf1839f4c..6c8243da90 100644
@@ -20,7 +20,7 @@ LIBVA_CONF_OPTS = \
  ifeq ($(BR2_PACKAGE_XORG7),y)
  LIBVA_DEPENDENCIES += xlib_libX11 xlib_libXext xlib_libXfixes
  LIBVA_CONF_OPTS += --enable-x11
-ifeq ($(BR2_PACKAGE_MESA3D_DRI_DRIVER),y)
+ifeq ($(BR2_PACKAGE_MESA3D_OPENGL_GLX),y)
  LIBVA_DEPENDENCIES += mesa3d
  LIBVA_CONF_OPTS += --enable-glx
  endif
Signature · 2 lines
Giulio Benetti
Benetti Engineering sas
#2 lore raw

PATCH 1/1 package/libva: fix mesa3d glx support

In reply to Bernd Kuhls
Quoted 10 lines · On Tue, 1 Oct 2019 08:05:20 +0200 Bernd Kuhls <[email protected]> wrote:

https://git.buildroot.net/buildroot/commit/package/mesa3d?id=5cb821d5635626b7327d5d704555c412e5ed5a1f

added a new option to enable GLX support.

This patch adjusts libva to use the new logic.

Fixes:
http://autobuild.buildroot.net/results/797/79776104e681402c24160be15789fe67bb69f833/

Applied, thanks. However, I have a comment below.

Quoted 9 lines
---
 package/libva/libva.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/libva/libva.mk +0 -0
index 7bf1839f4c..6c8243da90 100644

package/libva/libva.mk LIBVA_CONF_OPTS = \ · line 24

Quoted 6 lines
package/libva/libva.mk +1 -1
@@ -20,7 +20,7 @@ LIBVA_CONF_OPTS = \
 ifeq ($(BR2_PACKAGE_XORG7),y)
 LIBVA_DEPENDENCIES += xlib_libX11 xlib_libXext xlib_libXfixes
 LIBVA_CONF_OPTS += --enable-x11
-ifeq ($(BR2_PACKAGE_MESA3D_DRI_DRIVER),y)
+ifeq ($(BR2_PACKAGE_MESA3D_OPENGL_GLX),y)
 LIBVA_DEPENDENCIES += mesa3d

I think that depending on mesa3d and a mesa3d-specific option is probably not correct. Indeed, a different OpenGL implementation than Mesa3D can provide OpenGL GLX. For example, the nvidia-driver and amd-catalyst drivers I believe also provide OpenGL GLX.

That's clearly not an issue with your patch, as it was already not correct. But it might be nice to fix this at some point.

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#3 lore raw

PATCH 1/1 package/libva: fix mesa3d glx support

Am Tue, 08 Oct 2019 23:32:58 +0200 schrieb Thomas Petazzoni:

Quoted 8 lines

package/libva/libva.mk LIBVA_CONF_OPTS = \ · line 24

Quoted 3 lines
package/libva/libva.mk +1 -1
-ifeq ($(BR2_PACKAGE_MESA3D_DRI_DRIVER),y)
+ifeq ($(BR2_PACKAGE_MESA3D_OPENGL_GLX),y)
 LIBVA_DEPENDENCIES += mesa3d

I think that depending on mesa3d and a mesa3d-specific option is probably not correct. Indeed, a different OpenGL implementation than Mesa3D can provide OpenGL GLX. For example, the nvidia-driver and amd-catalyst drivers I believe also provide OpenGL GLX.

Hi Thomas,

you are right, sent patch: http://patchwork.ozlabs.org/patch/1175726/

Regards, Bernd

#4 lore raw

PATCH 1/1 package/libva: fix mesa3d glx support

In reply to Bernd Kuhls
Quoted 11 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Bernd" == Bernd Kuhls <[email protected]> writes:

https://git.buildroot.net/buildroot/commit/package/mesa3d?id=5cb821d5635626b7327d5d704555c412e5ed5a1f
added a new option to enable GLX support.

This patch adjusts libva to use the new logic.

Fixes:
http://autobuild.buildroot.net/results/797/79776104e681402c24160be15789fe67bb69f833/

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard