Skip to contentSkip to conversation

iwlwifi: Fix unmet dependency error for IWLWIFI_LEDS

PATCH In review Sinan Kaya 3 participants 5 messages Jan 21, 2019 – Jan 22, 2019

Subsystems (4)
lore
Share & tools
lore

Sinan Kaya

author
#0 lore raw

PATCH 1/1 iwlwifi: Fix unmet dependency error for IWLWIFI_LEDS

There is an unresolved dependency as follows:

IWLWIFI_LEDS selects MAC80211_LEDS.
MAC80211_LEDS depends on MAC80211.

It is possible to choose MAC80211_LEDS (y) but not choose MAC80211 (n)

WARNING: unmet direct dependencies detected for MAC80211_LEDS
Depends on [n]: NET [=y] && WIRELESS [=y] && MAC80211 [=n] && LEDS_CLASS [=y]
Selected by [y]:
- IWLWIFI_LEDS [=y] && NETDEVICES [=y] && WLAN [=y] && WLAN_VENDOR_INTEL [=y] && IWLWIFI [=y] && (LEDS_CLASS [=y]=y || LEDS_CLASS [=y]=IWLWIFI [=y])

Move the MAC80211 dependency into IWLWIFI_LEDS so that we avoid this configuration.

---
 drivers/net/wireless/intel/iwlwifi/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/intel/iwlwifi/Kconfig +1 -1
index 491ca3c8b43c..74f0d0bbed34 100644
@@ -46,7 +46,7 @@ if IWLWIFI
 
 config IWLWIFI_LEDS
 	bool
-	depends on LEDS_CLASS=y || LEDS_CLASS=IWLWIFI
+	depends on MAC80211 && (LEDS_CLASS=y || LEDS_CLASS=IWLWIFI)
 	select LEDS_TRIGGERS
 	select MAC80211_LEDS
 	default y
Signature · 1 line
2.19.0
#1 lore raw
Quoted 16 lines · Sinan Kaya

There is an unresolved dependency as follows:

IWLWIFI_LEDS selects MAC80211_LEDS.
MAC80211_LEDS depends on MAC80211.

It is possible to choose MAC80211_LEDS (y) but not choose MAC80211
(n)

WARNING: unmet direct dependencies detected for MAC80211_LEDS
Depends on [n]: NET [=y] && WIRELESS [=y] && MAC80211 [=n] &&
LEDS_CLASS [=y]
Selected by [y]:
- IWLWIFI_LEDS [=y] && NETDEVICES [=y] && WLAN [=y] &&
WLAN_VENDOR_INTEL [=y] && IWLWIFI [=y] && (LEDS_CLASS [=y]=y || LEDS_CLASS [=y]=IWLWIFI [=y])

Quoted 5 lines

Move the MAC80211 dependency into IWLWIFI_LEDS so that we avoid this configuration.

---

Thanks for your patch! But we already have another patch to fix this issued queued for 5.0-rc4 (it's currently in wireless-drivers.git):

https://patchwork.kernel.org/patch/10762079/

author
#2 lore raw
Quoted 20 lines · Luciano Coelho
Quoted 19 lines · Sinan Kaya

There is an unresolved dependency as follows:

IWLWIFI_LEDS selects MAC80211_LEDS.
MAC80211_LEDS depends on MAC80211.

It is possible to choose MAC80211_LEDS (y) but not choose MAC80211
(n)

WARNING: unmet direct dependencies detected for MAC80211_LEDS
Depends on [n]: NET [=y] && WIRELESS [=y] && MAC80211 [=n] &&
LEDS_CLASS [=y]
Selected by [y]:
- IWLWIFI_LEDS [=y] && NETDEVICES [=y] && WLAN [=y] &&
WLAN_VENDOR_INTEL [=y] && IWLWIFI [=y] && (LEDS_CLASS [=y]=y || LEDS_CLASS [=y]=IWLWIFI [=y])

Move the MAC80211 dependency into IWLWIFI_LEDS so that we avoid this configuration.

Quoted 7 lines
Quoted 2 lines

---

Thanks for your patch! But we already have another patch to fix this issued queued for 5.0-rc4 (it's currently in wireless-drivers.git):

https://patchwork.kernel.org/patch/10762079/

Is it possible to queue this up soon? There is an effort to clean up linux-next against randconfig failures and this issue showed up there.

Quoted 6 lines

--
Cheers,
Luca.

#3 lore raw
Quoted 24 lines · Sinan Kaya
Quoted 23 lines · Luciano Coelho
Quoted 21 lines · Sinan Kaya

There is an unresolved dependency as follows:

IWLWIFI_LEDS selects MAC80211_LEDS.
MAC80211_LEDS depends on MAC80211.

It is possible to choose MAC80211_LEDS (y) but not choose MAC80211
(n)

WARNING: unmet direct dependencies detected for MAC80211_LEDS
Depends on [n]: NET [=y] && WIRELESS [=y] && MAC80211 [=n] &&
LEDS_CLASS [=y]
Selected by [y]:
- IWLWIFI_LEDS [=y] && NETDEVICES [=y] && WLAN [=y] &&
WLAN_VENDOR_INTEL [=y] && IWLWIFI [=y] && (LEDS_CLASS [=y]=y || LEDS_CLASS [=y]=IWLWIFI [=y])

Move the MAC80211 dependency into IWLWIFI_LEDS so that we avoid this configuration.

---

Quoted 7 lines
Quoted 4 lines

Thanks for your patch! But we already have another patch to fix this issued queued for 5.0-rc4 (it's currently in wireless-drivers.git):

https://patchwork.kernel.org/patch/10762079/

Is it possible to queue this up soon? There is an effort to clean up linux-next against randconfig failures and this issue showed up there.

It already should be in linux-next:

https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers.git/commit/?id=ec5aecc0b227f5509d25853537f989ca303e2be1

But it's not in Linus' tree, yet.

Signature · 1 line
Kalle Valo
author
#4 lore raw
Quoted 31 lines · Kalle Valo
Quoted 29 lines · Sinan Kaya
Quoted 27 lines · Luciano Coelho
Quoted 16 lines · Sinan Kaya

There is an unresolved dependency as follows:

IWLWIFI_LEDS selects MAC80211_LEDS.
MAC80211_LEDS depends on MAC80211.

It is possible to choose MAC80211_LEDS (y) but not choose MAC80211
(n)

WARNING: unmet direct dependencies detected for MAC80211_LEDS

    Depends on [n]: NET [=y] && WIRELESS [=y] && MAC80211 [=n] &&

LEDS_CLASS [=y]
Selected by [y]:
- IWLWIFI_LEDS [=y] && NETDEVICES [=y] && WLAN [=y] &&
WLAN_VENDOR_INTEL [=y] && IWLWIFI [=y] && (LEDS_CLASS [=y]=y || LEDS_CLASS [=y]=IWLWIFI [=y])

Quoted 5 lines

Move the MAC80211 dependency into IWLWIFI_LEDS so that we avoid this configuration.

---

Thanks for your patch! But we already have another patch to fix this issued queued for 5.0-rc4 (it's currently in wireless-drivers.git):

https://patchwork.kernel.org/patch/10762079/

Quoted 9 lines
Quoted 2 lines

Is it possible to queue this up soon? There is an effort to clean up linux-next against randconfig failures and this issue showed up there.

It already should be in linux-next:

https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers.git/commit/?id=ec5aecc0b227f5509d25853537f989ca303e2be1

But it's not in Linus' tree, yet.

Thanks, let me grab a recent linux-next tag.