system: update Config.in comment about systemd dependencies
PATCH 1/1 system: update Config.in comment about systemd dependencies
In commit 879fa7f82a86ffdc6d1cf7c9bfbb5cf830583d69, the BR2_INIT_SYSTEMD option was changed to allow selecting with a uClibc toolchain. Unfortunately, the corresponding Config.in comment, which was already bogus, was not updated to take into account the numerous dependencies of BR2_INIT_SYSTEMD.
Due to this, even if you have uClibc enabled, the BR2_INIT_SYSTEMD option may not be visible, and the Config.in comment may also not be visible, leaving the user in the dark.
This commit fixes the dependencies of the Config.in comment so that they match the one of the BR2_INIT_SYSTEMD option.
--- system/Config.in | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-)
system/Config.in +9 -3
@@ -137,9 +137,15 @@ config BR2_INIT_SYSTEMD select BR2_ROOTFS_MERGED_USR select BR2_PACKAGE_SYSTEMD -comment "systemd needs a glibc or uClibc toolchain, headers >= 3.10" - depends on !(BR2_TOOLCHAIN_USES_GLIBC || BR2_TOOLCHAIN_USES_UCLIBC \ - && BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_10) +comment "systemd needs a glibc or uClibc toolchain w/ wchar, threads, SSP, dynamic library, headers >= 3.10" + depends on BR2_PACKAGE_SYSTEMD_ARCH_SUPPORTS + depends on BR2_USE_MMU + depends on !(BR2_TOOLCHAIN_USES_GLIBC || BR2_TOOLCHAIN_USES_UCLIBC) || \ + !BR2_USE_WCHAR || \ + !BR2_TOOLCHAIN_HAS_THREADS || \ + !BR2_TOOLCHAIN_HAS_SSP || \ + BR2_STATIC_LIBS || \ + !BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_10 config BR2_INIT_NONE bool "None"
Signature · 1 line
2.14.4
PATCH 1/1 system: update Config.in comment about systemd dependencies
Quoted 12 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Thomas" == Thomas Petazzoni <[email protected]> writes:
In commit
879fa7f82a86ffdc6d1cf7c9bfbb5cf830583d69, theBR2_INIT_SYSTEMDoption was changed to allow selecting with a uClibc toolchain. Unfortunately, the corresponding Config.in comment, which was already bogus, was not updated to take into account the numerous dependencies ofBR2_INIT_SYSTEMD.Due to this, even if you have uClibc enabled, the
BR2_INIT_SYSTEMDoption may not be visible, and the Config.in comment may also not be visible, leaving the user in the dark.
Quoted 6 lines
This commit fixes the dependencies of the Config.in comment so that they match the one of the
BR2_INIT_SYSTEMDoption.Reported-by Raphael Jacob <[email protected]>Cc Raphael Jacob <[email protected]>Signed-off-by Thomas Petazzoni <[email protected]>
Committed to 2018.05.x and 2018.08.x, thanks.
Signature · 1 line
Bye, Peter Korsgaard