Skip to contentSkip to conversation

acl_test01: Add setfacl as an explicit dependency

PATCH New Punit Agrawal 2 participants 3 messages Jul 6, 2018 – Jul 10, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 acl_test01: Add setfacl as an explicit dependency

acl_test01 calls setfacl during execution but does not explicitly check for its presence during setup.

Add this dependency to correctly report the failure mode when setfacl is not found.

---
 testcases/kernel/fs/acls/acl_test01 | 1 +
 1 file changed, 1 insertion(+)
testcases/kernel/fs/acls/acl_test01 +1 -0
index c91eb5686..14b62e895 100755
@@ -64,6 +64,7 @@ fi
 do_setup()
 {
 	tst_require_root
+	tst_check_cmds setfacl
 
 	if ! ( test -d $TMP/tacl || mkdir -m 777 $TMP/tacl) ; then
 		tst_brkm TBROK "Failed to create $TMP/tacl directory."
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/1 acl_test01: Add setfacl as an explicit dependency

----- Original Message -----

Quoted 7 lines

acl_test01 calls setfacl during execution but does not explicitly check for its presence during setup.

Add this dependency to correctly report the failure mode when setfacl is not found.

Pushed.

Thanks,
Jan

#2 lore raw

PATCH 1/1 acl_test01: Add setfacl as an explicit dependency

Quoted 10 lines · Jan Stancek

----- Original Message -----

Quoted 7 lines

acl_test01 calls setfacl during execution but does not explicitly check for its presence during setup.

Add this dependency to correctly report the failure mode when setfacl is not found.

Pushed.

Thanks!

Since sending this commit I've hit other tests which don't do a full dependency check - many of them seem to be using 'killall'. I'll try and collect all the patches and send them out together.

Quoted 3 lines

Thanks,
Jan