Skip to contentSkip to conversation

ARM: dts: armada-38x: use the new thermal binding

PATCH New Baruch Siach 2 participants 2 messages Jul 3, 2018 – Jul 4, 2018

Subsystems (2)
Stable branch Device tree bindings
lore
Share & tools
lore

Baruch Siach

author
#0 lore raw

PATCH v2 1/1 ARM: dts: armada-38x: use the new thermal binding

Commit 2f28e4c24b10e (thermal: armada: Clarify control registers accesses) introduced the new thermal binding. The new binding extends the second registers field size to 8. Switch to the new binding to fix thermal reading values. Without this change the fix for errata #132698 introduced in commit 8c0b888f661 (thermal: armada: Change sensors trim default value) has no effect.

Cc stable at vger.kernel.org # v4.16+
Reviewed-by Miquel Raynal <[email protected]>
Signed-off-by Baruch Siach <[email protected]>

---
v2:
* Typo fixes (Andreas F?rber)
* Add Miquel's review tag
* Minor wording changes
* Cc stable

---
 arch/arm/boot/dts/armada-38x.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/armada-38x.dtsi +1 -1
index 18edc9bc7927..929459c42760 100644
@@ -547,7 +547,7 @@
 
 			thermal: thermal at e8078 {
 				compatible = "marvell,armada380-thermal";
-				reg = <0xe4078 0x4>, <0xe4074 0x4>;
+				reg = <0xe4078 0x4>, <0xe4070 0x8>;
 				status = "okay";
 			};
Signature · 1 line
2.18.0
#1 lore raw

PATCH v2 1/1 ARM: dts: armada-38x: use the new thermal binding

Hi Baruch,

Quoted 10 lines · Baruch Siach

Commit 2f28e4c24b10e (thermal: armada: Clarify control registers accesses) introduced the new thermal binding. The new binding extends the second registers field size to 8. Switch to the new binding to fix thermal reading values. Without this change the fix for errata #132698 introduced in commit 8c0b888f661 (thermal: armada: Change sensors trim default value) has no effect.

Cc stable at vger.kernel.org # v4.16+
Reviewed-by Miquel Raynal <[email protected]>
Signed-off-by Baruch Siach <[email protected]>

Applied on mvebu/fixes

Thanks,

Gregory

Quoted 26 lines

---
v2:
* Typo fixes (Andreas F?rber)
* Add Miquel's review tag
* Minor wording changes
* Cc stable

---
 arch/arm/boot/dts/armada-38x.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/armada-38x.dtsi +1 -1
index 18edc9bc7927..929459c42760 100644
@@ -547,7 +547,7 @@
 
 			thermal: thermal at e8078 {
 				compatible = "marvell,armada380-thermal";
-				reg = <0xe4078 0x4>, <0xe4074 0x4>;
+				reg = <0xe4078 0x4>, <0xe4070 0x8>;
 				status = "okay";
 			};
Signature · 1 line
2.18.0
Signature · 3 lines
Gregory Clement, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com