Skip to contentSkip to conversation

fbgrab: add patch fixing pixel format report

PATCH New Timo Ketola 3 participants 6 messages Mar 8, 2018 – Mar 30, 2018

lore
Share & tools
lore

Timo Ketola

author
#0 lore raw

PATCH v2 1/1 fbgrab: add patch fixing pixel format report

When verbosive, fbgrab reports pixel format. Green and blue offset and msb_right fields are accidentally swapped there. This commit adds a patch which straightens them up.

Upstream-Status: Submitted [Gunnar Monell <[email protected]>]

Signed-off-by Timo Ketola <[email protected]>

---
No changes in the payload. Only added Upstream-status (Adrian) and adjusted subject line (Thomas).

---
 package/fbgrab/0100-fix-pixfmt-report.patch | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)
 create mode 100644 package/fbgrab/0100-fix-pixfmt-report.patch
package/fbgrab/0100-fix-pixfmt-report.patch new file +22 -0
new file mode 100644
index 0000000..18bcf96
@@ -0,0 +1,22 @@
+Fix pixel format report
+
+When fbgrab tells about the framebuffer pixel format, blue and green
+are accidentally swapped in 'length' and 'msb_right' columns. Let's
+order everything as RGB.
+
+Signed-off-by timo.ketola at exertus.fi
+
+diff -u a/fbgrab.c b/fbgrab.c
+--- a/fbgrab.c	2018-03-07 11:42:04.739250433 +0200
++++ b/fbgrab.c	2018-03-07 11:43:26.128043877 +0200
+@@ -169,8 +169,8 @@
+         fprintf(stderr, "bits_per_pixel: %i\n", fb_varinfo_p->bits_per_pixel);
+         fprintf(stderr, "grayscale: %s\n", fb_varinfo_p->grayscale ? "true" : "false");
+         fprintf(stderr, "red:   offset: %i, length: %i, msb_right: %i\n", fb_varinfo_p->red.offset, fb_varinfo_p->red.length, fb_varinfo_p->red.msb_right);
+-        fprintf(stderr, "blue:  offset: %i, length: %i, msb_right: %i\n", fb_varinfo_p->blue.offset, fb_varinfo_p->green.length, fb_varinfo_p->green.msb_right);
+-        fprintf(stderr, "green: offset: %i, length: %i, msb_right: %i\n", fb_varinfo_p->green.offset, fb_varinfo_p->blue.length, fb_varinfo_p->blue.msb_right);
++        fprintf(stderr, "green: offset: %i, length: %i, msb_right: %i\n", fb_varinfo_p->green.offset, fb_varinfo_p->green.length, fb_varinfo_p->green.msb_right);
++        fprintf(stderr, "blue:  offset: %i, length: %i, msb_right: %i\n", fb_varinfo_p->blue.offset, fb_varinfo_p->blue.length, fb_varinfo_p->blue.msb_right);
+         fprintf(stderr, "alpha: offset: %i, length: %i, msb_right: %i\n", fb_varinfo_p->transp.offset, fb_varinfo_p->transp.length, fb_varinfo_p->transp.msb_right);
+         fprintf(stderr, "pixel format: %s\n", fb_varinfo_p->nonstd == 0 ? "standard" : "non-standard");
+     }
Signature · 1 line
2.7.4
#1 lore raw

PATCH v2 1/1 fbgrab: add patch fixing pixel format report

Quoted 6 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Timo" == Timo Ketola <[email protected]> writes:

When verbosive, fbgrab reports pixel format. Green and blue offset and msb_right fields are accidentally swapped there. This commit adds a patch which straightens them up.

Quoted 6 lines

Upstream-Status: Submitted [Gunnar Monell <[email protected]>]

Signed-off-by Timo Ketola <[email protected]>

---
No changes in the payload. Only added Upstream-status (Adrian) and adjusted subject line (Thomas).

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#2 lore raw

PATCH v2 1/1 fbgrab: add patch fixing pixel format report

In reply to Timo Ketola

Hello,

Quoted 5 lines · Timo Ketola

When verbosive, fbgrab reports pixel format. Green and blue offset and msb_right fields are accidentally swapped there. This commit adds a patch which straightens them up.

Upstream-Status: Submitted [Gunnar Monell <[email protected]>]

We normally put the Upstream-Status in the patch itself, i.e

Quoted 16 lines
Signed-off-by Timo Ketola <[email protected]>

---
No changes in the payload. Only added Upstream-status (Adrian) and adjusted subject line (Thomas).

---
 package/fbgrab/0100-fix-pixfmt-report.patch | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)
 create mode 100644 package/fbgrab/0100-fix-pixfmt-report.patch
package/fbgrab/0100-fix-pixfmt-report.patch new file +0 -0
new file mode 100644
index 0000000..18bcf96

package/fbgrab/0100-fix-pixfmt-report.patch line 5

Quoted 5 lines
package/fbgrab/0100-fix-pixfmt-report.patch new file +5 -0
@@ -0,0 +1,22 @@
+Fix pixel format report
+
+When fbgrab tells about the framebuffer pixel format, blue and green
+are accidentally swapped in 'length' and 'msb_right' columns. Let's
+order everything as RGB.

... here.

package/fbgrab/0100-fix-pixfmt-report.patch line 7

Quoted 2 lines
package/fbgrab/0100-fix-pixfmt-report.patch new file +2 -0
+
+Signed-off-by timo.ketola at exertus.fi

This Signed-off-by line doesn't follow the usual format, it should have been:

Signed-off-by Timo Ketola <[email protected]>

(But your patch has been applied already anyway).

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com
author
#3 lore raw

PATCH v2 1/1 fbgrab: add patch fixing pixel format report

Quoted 4 lines · Thomas Petazzoni
Quoted 1 line · Timo Ketola

Upstream-Status: Submitted [Gunnar Monell <[email protected]>]

We normally put the Upstream-Status in the patch itself...

Ah, makes sense of course.

Quoted 3 lines
Quoted 1 line

+Signed-off-by timo.ketola at exertus.fi

This Signed-off-by line doesn't follow the usual format...

Arg, I hand edited the patch from diff output.

Quoted 1 line

(But your patch has been applied already anyway).

Should I fix them anyway?

--

Timo

#4 lore raw

PATCH v2 1/1 fbgrab: add patch fixing pixel format report

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Timo" == Timo Ketola <[email protected]> writes:

Hi,

Quoted 6 lines
Quoted 1 line

We normally put the Upstream-Status in the patch itself...

Ah, makes sense of course.

Quoted 2 lines
Quoted 1 line

+Signed-off-by timo.ketola at exertus.fi

Quoted 7 lines
Quoted 1 line

This Signed-off-by line doesn't follow the usual format...

Arg, I hand edited the patch from diff output.

Quoted 1 line

(But your patch has been applied already anyway).

Should I fix them anyway?

yes, please send a followup patch - Thanks!

Signature · 1 line
Bye, Peter Korsgaard
#5 lore raw

PATCH v2 1/1 fbgrab: add patch fixing pixel format report

In reply to Timo Ketola
Quoted 6 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Timo" == Timo Ketola <[email protected]> writes:

When verbosive, fbgrab reports pixel format. Green and blue offset and msb_right fields are accidentally swapped there. This commit adds a patch which straightens them up.

Quoted 6 lines

Upstream-Status: Submitted [Gunnar Monell <[email protected]>]

Signed-off-by Timo Ketola <[email protected]>

---
No changes in the payload. Only added Upstream-status (Adrian) and adjusted subject line (Thomas).

Committed to 2018.02.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard