Skip to contentSkip to conversation

ARM64: dts: marvell: armada-cp110: Add registers clock for sata node

PATCH New Gregory CLEMENT 1 participant 2 messages Feb 15, 2018 – Feb 27, 2018

Subsystems (2)
lore
Share & tools
lore

Gregory CLEMENT

author maintainer
#0 lore raw

PATCH 1/1 ARM64: dts: marvell: armada-cp110: Add registers clock for sata node

This extra clock is needed to access the registers of the AHCI SATA controller used on the Armada 7K/8K SoCs.

The ahci drivers was already designed to support up to 5 clocks so there is only need to update the device tree to use it. It was not noticed until now because of wrong assumption in the clock drivers, but as this IP really needs 2 clocks, we had to declare both of them.

---
 arch/arm64/boot/dts/marvell/armada-cp110.dtsi | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
arch/arm64/boot/dts/marvell/armada-cp110.dtsi +2 -1
index 50038434dd53..b8cf1497dc22 100644
@@ -236,7 +236,8 @@
 			"generic-ahci";
 			reg = <0x540000 0x30000>;
 			interrupts = <ICU_GRP_NSR 107 IRQ_TYPE_LEVEL_HIGH>;
-			clocks = <&CP110_LABEL(clk) 1 15>;
+			clocks = <&CP110_LABEL(clk) 1 15>,
+				 <&CP110_LABEL(clk) 1 16>;
 			status = "disabled";
 		};
 
Signature · 1 line
2.15.1
author maintainer
#1 lore raw

PATCH 1/1 ARM64: dts: marvell: armada-cp110: Add registers clock for sata node

Hi,

Quoted 8 lines · Gregory CLEMENT

This extra clock is needed to access the registers of the AHCI SATA controller used on the Armada 7K/8K SoCs.

The ahci drivers was already designed to support up to 5 clocks so there is only need to update the device tree to use it. It was not noticed until now because of wrong assumption in the clock drivers, but as this IP really needs 2 clocks, we had to declare both of them.

Applied on mvebu/dt64

Gregory

Quoted 22 lines
---
 arch/arm64/boot/dts/marvell/armada-cp110.dtsi | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
arch/arm64/boot/dts/marvell/armada-cp110.dtsi +2 -1
index 50038434dd53..b8cf1497dc22 100644
@@ -236,7 +236,8 @@
 			"generic-ahci";
 			reg = <0x540000 0x30000>;
 			interrupts = <ICU_GRP_NSR 107 IRQ_TYPE_LEVEL_HIGH>;
-			clocks = <&CP110_LABEL(clk) 1 15>;
+			clocks = <&CP110_LABEL(clk) 1 15>,
+				 <&CP110_LABEL(clk) 1 16>;
 			status = "disabled";
 		};
 
Signature · 1 line
2.15.1
Signature · 3 lines
Gregory Clement, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com